Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 25 Nov 2020 15:14:49 +0300
From:   Serge Semin <fancer.lancer@gmail.com>
To:     Tian Tao <tiantao6@hisilicon.com>
Cc:     broonie@kernel.org, linux-spi@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] spi: dw: fixed missing resource_size
Message-ID: <20201125121449.zo2njliv4typz4ca@mobilestation>
References: <1606114975-31362-1-git-send-email-tiantao6@hisilicon.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1606114975-31362-1-git-send-email-tiantao6@hisilicon.com>
Precedence: bulk

On Mon, Nov 23, 2020 at 03:02:55PM +0800, Tian Tao wrote:
> fixed the coccicheck:
> drivers/spi/spi-dw-bt1.c:220:27-30: ERROR: Missing
> resource_size with mem.

Thanks, Tian!
Acked-by: Serge Semin <fancer.lancer@gmail.com>

> 
> Signed-off-by: Tian Tao <tiantao6@hisilicon.com>
> ---
>  drivers/spi/spi-dw-bt1.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/spi/spi-dw-bt1.c b/drivers/spi/spi-dw-bt1.c
> index f382dfad..da4f4d8 100644
> --- a/drivers/spi/spi-dw-bt1.c
> +++ b/drivers/spi/spi-dw-bt1.c
> @@ -217,7 +217,7 @@ static int dw_spi_bt1_sys_init(struct platform_device *pdev,
>  	if (mem) {
>  		dwsbt1->map = devm_ioremap_resource(&pdev->dev, mem);
>  		if (!IS_ERR(dwsbt1->map)) {
> -			dwsbt1->map_len = (mem->end - mem->start + 1);
> +			dwsbt1->map_len = resource_size(mem);
>  			dws->mem_ops.dirmap_create = dw_spi_bt1_dirmap_create;
>  			dws->mem_ops.dirmap_read = dw_spi_bt1_dirmap_read;
>  		} else {
> -- 
> 2.7.4
>