Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp343091pxu; Wed, 25 Nov 2020 04:49:35 -0800 (PST) X-Google-Smtp-Source: ABdhPJxFt1SX1QN44gHC45aeVeYhKbkhBaYG16Db3plAbzLfNnhIs7YGRWjDTa8mgis6uha8l54V X-Received: by 2002:aa7:ce12:: with SMTP id d18mr3283169edv.241.1606308575188; Wed, 25 Nov 2020 04:49:35 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1606308575; cv=none; d=google.com; s=arc-20160816; b=V7Y1w2FkSoXwDz7fP7Y/NEKh0USoNYViegy91lUHswadzkiywJlEOfTBKvm+BfQdDv 6ng04oYLmwQ8CEerGxomQJLeG5ztbiqwYeCnPTED7YymJTpsju20aLFgZMMd2pbwdS4F 5zwoQ0rlxq2Y4ruGTr2tizU0N7ef2wECLiwMVRSef7aYrHo/9ocHJEvDLODtkOYCEZHO m7ULCoxjnhm+N+t85eD7o3nYu6A8JaFpVJznMqYWhY8doqithIz9ER3SWT4j1y0WmQJU VxJZjucXS2z95myNAxUVDaxX8fFs80jwW79s5UjKfyzEU5OhItusi9HfsKVj7+QMiSRm jhHg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:sender:dkim-signature; bh=7R3km/7YgHo1sfvn914rRqBdqUPVd1zF91vgKVUo3Xc=; b=v2zir4cqfFTt+kokPARb2cdSAaFzTqIjMk4LjtVJKpHqXrfM0MVgXgfbDddYia+Eqt TimvC2M1jSzgl8PIYHRb4EfDGUcPUc+pZhmu8Ei5U4X3HGjMM8vZoNQ2WvkHBmC/icv6 CRFizBDoybbEis4AUHTz4fwmpVQdR0Cz98McGwREGPJ+Ryk1aL5lwMnqqvkS0naKstVC 4u11c2XbKRAhezn9LCMsJ184DuXNKkJM7hO9glsvgRNBZvFKhO//dmi2zjPkLlIvBr0K X9nZqqMD+lKn3+l987IWWIrhCC8vSaBSKVN6LJUzGOz7B5jA7YfjBvit/5P5wFZ82qzL taHg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b="M/mxYq+6"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id j7si1176892eje.191.2020.11.25.04.49.12; Wed, 25 Nov 2020 04:49:35 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b="M/mxYq+6"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728509AbgKYMqM (ORCPT + 99 others); Wed, 25 Nov 2020 07:46:12 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52042 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728361AbgKYMqL (ORCPT ); Wed, 25 Nov 2020 07:46:11 -0500 Received: from mail-qv1-xf42.google.com (mail-qv1-xf42.google.com [IPv6:2607:f8b0:4864:20::f42]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A42E1C0613D4 for ; Wed, 25 Nov 2020 04:46:11 -0800 (PST) Received: by mail-qv1-xf42.google.com with SMTP id dm12so838298qvb.3 for ; Wed, 25 Nov 2020 04:46:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=7R3km/7YgHo1sfvn914rRqBdqUPVd1zF91vgKVUo3Xc=; b=M/mxYq+6WVSJhqtHcll5G9Kc6LxBo4B/uly2oIt2xggPLKmAE5ON5TTsR4WRNE84F0 Sn2sYhIAcPCbulkEJYySVktqOr9fVzTbFTyaDhRvE7sa8aPagCShUpsN1zLfCANAi3VW a8gY6VcXQdm8NGzEGbhTULgG8H0ro9c+I7y15qVi5Ca+DiCiN9tObzcB0VklcePCvd+e 8UvMma0/Xy770YNeIbIP9FmJ+M5X2c1MM0tuDBk0mJvYwSMrthgS7rbsTHwehv12aCLv UrAHrnfeOiTqhKHt0xO10T9R//3yYaJx0D1wIs8xTWRR+PFMJ/gVVyCiEu7ldORDk/nV XaTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to; bh=7R3km/7YgHo1sfvn914rRqBdqUPVd1zF91vgKVUo3Xc=; b=OArQEHrz9xcbPd5lkLxB/AP8jA+KJMeS8DLvtFxXKNwSQwsDbVgREVNo4QIN3kRhbn gV5AcHMI8xbzwitTTA/HTOjvOlcmqjVClKuDd1x1B6fZcJsBiZZ9WUESO37rqh4osccw oEU4ffxuEHQnrPTQONUuHFkmt7VfQfn2xggGjPLEdUGno2fmymzDFcqycDTkeXeGeJzs PcFpeaUpPYAqI+VzJ4vyIUD6522ZJvmdDNRoWd0JxqRjcoQ4XMQbEgWsK5UcIU/EYIkM 2UB5GAVbaDjtnZNk7btwskXCp7jYQ/vwXLYUl18/x7Zb20Sbfh5fAcwGlBAB4/Ndqy05 /iXw== X-Gm-Message-State: AOAM530ZeUjzmsIDLm+YdCbGeZmmeGq6DUbxF/dK+3K7vLbBAL0+ssSR tFSfYIbsNlofgh6oxrflxfQ= X-Received: by 2002:a05:6214:1848:: with SMTP id d8mr2963731qvy.7.1606308370783; Wed, 25 Nov 2020 04:46:10 -0800 (PST) Received: from localhost (dhcp-6c-ae-f6-dc-d8-61.cpe.echoes.net. [72.28.8.195]) by smtp.gmail.com with ESMTPSA id s3sm2333587qtd.49.2020.11.25.04.46.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Nov 2020 04:46:10 -0800 (PST) Sender: Tejun Heo Date: Wed, 25 Nov 2020 07:45:47 -0500 From: Tejun Heo To: Yunfeng Ye Cc: jiangshanlai@gmail.com, linux-kernel@vger.kernel.org, Shiyuan Hu , Hewenliang Subject: Re: [PATCH v2] workqueue: Kick a worker based on the actual activation of delayed works Message-ID: References: <3837a2ee-f3d5-2732-7d15-7e9616319f05@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3837a2ee-f3d5-2732-7d15-7e9616319f05@huawei.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 19, 2020 at 02:21:25PM +0800, Yunfeng Ye wrote: > In realtime scenario, We do not want to have interference on the > isolated cpu cores. but when invoking alloc_workqueue() for percpu wq > on the housekeeping cpu, it kick a kworker on the isolated cpu. > > alloc_workqueue > pwq_adjust_max_active > wake_up_worker > > The comment in pwq_adjust_max_active() said: > "Need to kick a worker after thawed or an unbound wq's > max_active is bumped" > > So it is unnecessary to kick a kworker for percpu's wq when invoking > alloc_workqueue(). this patch only kick a worker based on the actual > activation of delayed works. > > Signed-off-by: Yunfeng Ye Applied to wq/for-5.10-fixes w/ minor comment updates. Thanks. -- tejun