Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp357745pxu; Wed, 25 Nov 2020 05:09:56 -0800 (PST) X-Google-Smtp-Source: ABdhPJwtzSIOT+SQ+43CE+b5lyhcJuQRFd+R+LHboHXhfbUQPFW/5la4VrK4TGKRS6lC7ogcOBal X-Received: by 2002:a17:906:3687:: with SMTP id a7mr3107739ejc.210.1606309796472; Wed, 25 Nov 2020 05:09:56 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1606309796; cv=none; d=google.com; s=arc-20160816; b=tQ57/azQGDiU/iSfiRPrRaRdBVgBVCvr1/rY/RA141K2DRKO1qiuUJ+N4wYPXAfJDt IC0/DdOwm8NTgVph0iANbSlrEfF7u0fXOJACtW3316TvDdOXzMWkWQqIH3SMOa4EfTtv 35RxMzNHSyeIAIDoJSXgx2Lze80mfCN3E1dcOsu3GcHGoBCPnPa0BA/BtgoXrO9DVC87 K2OMyxhRE5OrLip53GuwS8Qny0mn089eLAVXgkJrXcLxxMpK3Y7PwhfjX9oys9Au8nSn sggsXHkgbtHVAGANxgQ71LLDW4xStvffw/acEVCPNlhjj8AGoxEVp+fqw82Ti1je/K9T h3AQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=ZHgc2pWFlRKIo3GgAn47PzCYzIT9MLVKg5ne7N02cwE=; b=g8xbzanjH/sRwW0jDLRReCa8rWVmQa3mSi0s3JhGzvGfgNXZQ1NxQ1OX2cK5AWURJJ MqOBBTkt492Y9WoHtiuRXg/6OWZAr0fEIp3hCHV9dexuo9Ms/7Upi5aE5a7US120Lr4R LrxSQvHDIavlXXJxtcvYDnHYI6MnPzFffTrk1Y0xe5oah5+5+cyMDrGQutJpMfq8ZeRX Odnb4CemNMb108E2ikF9+H+Qy8V1aK1wcT4AR40uXTdAVd5dnUQnqwA7PrMK3t/Xucxx jCvngF7kOMyrFS6Ct6xtvPbupg0mq+yqyjzt/k4alJi3o6xEan1lt4MtWpstquFl8mvT Zl2w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=cpIerSnL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id y4si1223987ejj.723.2020.11.25.05.09.33; Wed, 25 Nov 2020 05:09:56 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=cpIerSnL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729634AbgKYNFE (ORCPT + 99 others); Wed, 25 Nov 2020 08:05:04 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54976 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729619AbgKYNFD (ORCPT ); Wed, 25 Nov 2020 08:05:03 -0500 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9229FC0613D4 for ; Wed, 25 Nov 2020 05:05:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=ZHgc2pWFlRKIo3GgAn47PzCYzIT9MLVKg5ne7N02cwE=; b=cpIerSnLuILHY54dZ+2SZiKSJo 4MUhfRXl+TZN2jMAcWScWeIxbi57lztmVMrnyIX77hxjYiK07ihIbYPelYR/FNoF1vukWU+I9pi4j aRrXIt1nn7JCL7snKSabN2WjAr4arvT3vPGgtrvQCBvVfesh5AviUjBmd8YE2h4wXEmRj+U+I5gNz 8KNJKPwNU2/uKx7+yZ0VY3x9WRH1XSFb+ylq0DtAAgA7m2z4pJt/3S44oWJ860coqnFkAlDkWdk6Q 1VjEvJog80YQWZaHvCliBQiWRfEZEasuV9ttkxAVEaUPvZIAqJ7sH504BDp5vUVtbZQcEaN0eyZG+ KQ3cfC6g==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=noisy.programming.kicks-ass.net) by casper.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux)) id 1khuSe-0005m1-1j; Wed, 25 Nov 2020 13:03:52 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id 4D6DD30280E; Wed, 25 Nov 2020 14:03:50 +0100 (CET) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 3DA2A22B9CF3D; Wed, 25 Nov 2020 14:03:50 +0100 (CET) Date: Wed, 25 Nov 2020 14:03:50 +0100 From: Peter Zijlstra To: "Joel Fernandes (Google)" Cc: Nishanth Aravamudan , Julien Desfossez , Tim Chen , Vineeth Pillai , Aaron Lu , Aubrey Li , tglx@linutronix.de, linux-kernel@vger.kernel.org, mingo@kernel.org, torvalds@linux-foundation.org, fweisbec@gmail.com, keescook@chromium.org, kerrnel@google.com, Phil Auld , Valentin Schneider , Mel Gorman , Pawan Gupta , Paolo Bonzini , vineeth@bitbyteword.org, Chen Yu , Christian Brauner , Agata Gruza , Antonio Gomez Iglesias , graf@amazon.com, konrad.wilk@oracle.com, dfaggioli@suse.com, pjt@google.com, rostedt@goodmis.org, derkling@google.com, benbjiang@tencent.com, Alexandre Chartre , James.Bottomley@hansenpartnership.com, OWeisse@umich.edu, Dhaval Giani , Junaid Shahid , jsbarnes@google.com, chris.hyser@oracle.com, Ben Segall , Josh Don , Hao Luo , Tom Lendacky , Aubrey Li , "Paul E. McKenney" , Tim Chen Subject: Re: [PATCH -tip 24/32] sched: Release references to the per-task cookie on exit Message-ID: <20201125130350.GX2414@hirez.programming.kicks-ass.net> References: <20201117232003.3580179-1-joel@joelfernandes.org> <20201117232003.3580179-25-joel@joelfernandes.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201117232003.3580179-25-joel@joelfernandes.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 17, 2020 at 06:19:54PM -0500, Joel Fernandes (Google) wrote: > During exit, we have to free the references to a cookie that might be shared by > many tasks. This commit therefore ensures when the task_struct is released, any > references to cookies that it holds are also released. This is one of those patches that just shouldn't exist. Squash it into whatever patch that introduces this nonsense.