Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 25 Nov 2020 15:15:31 +0100
From:   Jiri Olsa <jolsa@redhat.com>
To:     Namhyung Kim <namhyung@kernel.org>
Cc:     Jiri Olsa <jolsa@kernel.org>,
        Arnaldo Carvalho de Melo <acme@kernel.org>,
        lkml <linux-kernel@vger.kernel.org>,
        Peter Zijlstra <a.p.zijlstra@chello.nl>,
        Ingo Molnar <mingo@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Michael Petlan <mpetlan@redhat.com>,
        Song Liu <songliubraving@fb.com>,
        Ian Rogers <irogers@google.com>,
        Stephane Eranian <eranian@google.com>,
        Alexey Budankov <alexey.budankov@linux.intel.com>,
        Andi Kleen <ak@linux.intel.com>,
        Adrian Hunter <adrian.hunter@intel.com>
Subject: Re: [PATCH 13/25] perf tools: Store build id from mmap2 events
Message-ID: <20201125141531.GE2164284@krava>
References: <20201123230512.2097312-1-jolsa@kernel.org>
 <20201123230512.2097312-14-jolsa@kernel.org>
 <CAM9d7ciq_D2F_bPoq7S5aw+0jPZ0EokCNDadEcO2KF_rYsL8VQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAM9d7ciq_D2F_bPoq7S5aw+0jPZ0EokCNDadEcO2KF_rYsL8VQ@mail.gmail.com>
Precedence: bulk

On Wed, Nov 25, 2020 at 09:56:31PM +0900, Namhyung Kim wrote:
> On Tue, Nov 24, 2020 at 8:06 AM Jiri Olsa <jolsa@kernel.org> wrote:
> >
> > When processing mmap2 event, check on the build id
> > misc bit: PERF_RECORD_MISC_MMAP_BUILD_ID and if it
> > is set, store the build id in mmap's dso object.
> >
> > Also adding the build id data arts to struct
> 
> s/arts/args/ ?

right, perhaps also s/arts// 

thanks,
jirka

> 
> Thanks,
> Namhyung
> 
> 
> > perf_record_mmap2 event definition.
> >
> > Signed-off-by: Jiri Olsa <jolsa@kernel.org>
>