Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 25 Nov 2020 09:17:58 -0500
From:   "J. Bruce Fields" <bfields@fieldses.org>
To:     Huang Guobin <huangguobin4@huawei.com>
Cc:     chuck.lever@oracle.com, trond.myklebust@primarydata.com,
        richard.sharpe@primarydata.com, dros@primarydata.com,
        jeff.layton@primarydata.com, linux-nfs@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] nfsd: Fix error return code in nfsd_file_cache_init()
Message-ID: <20201125141758.GB2811@fieldses.org>
References: <20201125083933.2386059-1-huangguobin4@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20201125083933.2386059-1-huangguobin4@huawei.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Precedence: bulk

On Wed, Nov 25, 2020 at 03:39:33AM -0500, Huang Guobin wrote:
> Fix to return PTR_ERR() error code from the error handling case instead of
> 0 in function nfsd_file_cache_init(), as done elsewhere in this function.
> 
> Fixes: 65294c1f2c5e7("nfsd: add a new struct file caching facility to nfsd")
> Signed-off-by: Huang Guobin <huangguobin4@huawei.com>
> ---
>  fs/nfsd/filecache.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/fs/nfsd/filecache.c b/fs/nfsd/filecache.c
> index c8b9d2667ee6..a8a5b555f08b 100644
> --- a/fs/nfsd/filecache.c
> +++ b/fs/nfsd/filecache.c
> @@ -686,6 +686,7 @@ nfsd_file_cache_init(void)
>  		pr_err("nfsd: unable to create fsnotify group: %ld\n",
>  			PTR_ERR(nfsd_file_fsnotify_group));
>  		nfsd_file_fsnotify_group = NULL;
> +		ret = PTR_ERR(nfsd_file_fsnotify_group);

I think you meant to add that one line earlier.

Otherwise fine, but it looks like an unlikely case so can probably wait
for the merge window.

--b.

>  		goto out_notifier;
>  	}
>  
> -- 
> 2.22.0