Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 25 Nov 2020 19:50:36 +0100
From:   Andrea Mayer <andrea.mayer@uniroma2.it>
To:     Jakub Kicinski <kuba@kernel.org>
Cc:     "David S. Miller" <davem@davemloft.net>,
        David Ahern <dsahern@kernel.org>,
        Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>,
        Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,
        Shuah Khan <shuah@kernel.org>,
        Shrijeet Mukherjee <shrijeet@gmail.com>,
        Alexei Starovoitov <ast@kernel.org>,
        Daniel Borkmann <daniel@iogearbox.net>,
        Andrii Nakryiko <andrii@kernel.org>,
        Martin KaFai Lau <kafai@fb.com>,
        Song Liu <songliubraving@fb.com>, Yonghong Song <yhs@fb.com>,
        John Fastabend <john.fastabend@gmail.com>,
        KP Singh <kpsingh@chromium.org>, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
        Nathan Chancellor <natechancellor@gmail.com>,
        Stefano Salsano <stefano.salsano@uniroma2.it>,
        Paolo Lungaroni <paolo.lungaroni@cnit.it>,
        Ahmed Abdelsalam <ahabdels.dev@gmail.com>,
        Andrea Mayer <andrea.mayer@uniroma2.it>
Subject: Re: [net-next v3 5/8] seg6: add support for the SRv6 End.DT4
 behavior
Message-Id: <20201125195036.4b5b5645ff32926ca83b1359@uniroma2.it>
In-Reply-To: <20201124154017.4b1a905c@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
References: <20201123182857.4640-1-andrea.mayer@uniroma2.it>
        <20201123182857.4640-6-andrea.mayer@uniroma2.it>
        <20201124154017.4b1a905c@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi Jakub,
thanks for your review.

On Tue, 24 Nov 2020 15:40:17 -0800
Jakub Kicinski <kuba@kernel.org> wrote:

> On Mon, 23 Nov 2020 19:28:53 +0100 Andrea Mayer wrote:
> > +static int cmp_nla_vrftable(struct seg6_local_lwt *a, struct seg6_local_lwt *b)
> > +{
> > +	struct seg6_end_dt_info *info_a = seg6_possible_end_dt_info(a);
> > +	struct seg6_end_dt_info *info_b = seg6_possible_end_dt_info(b);
> > +
> > +	if (IS_ERR(info_a) || IS_ERR(info_b))
> > +		return 1;
> 
> Isn't this impossible? I thought cmp() can only be called on fully
> created lwtunnels and if !CONFIG_NET_L3_MASTER_DEV the tunnel won't 
> be created?
> 

The function cmp_nla_vrftable() can be called only if the lwtunnel is created
successfully.

A SRv6 behavior using a vrftable attribute can be successfully instantiated only
if CONFIG_NET_L3_MASTER_DEV is set. Otherwise (CONFIG_NET_L3_MASTER_DEV not set),
the function parse_nla_vrftable() returns an error (obtained from the
seg6_possible_end_dt_info()) and tunnel creation fails.

The pointer returned from seg6_possible_end_dt_info() depends on
CONFIG_NET_L3_MASTER_DEV. I thought it would be reasonable to check its validity
in functions that make explicit use of seg6_possible_end_dt_info() even in cases
where this was not strictly necessary (i.e: cmp_nla_vrftable()).

Therefore, it turns out to be an impossible case. I can remove these checks in
the next v4.

Thank you,
Andrea

> > +	if (info_a->vrf_table != info_b->vrf_table)
> > +		return 1;
> > +
> > +	return 0;