Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Content-Type: text/plain; charset="UTF-8"
MIME-Version: 1.0
References: <acf595c3-1b0a-4d73-8087-784d89bdec91@email.android.com> <nycvar.YFH.7.76.2011251439500.3441@cbobk.fhfr.pm>
In-Reply-To: <nycvar.YFH.7.76.2011251439500.3441@cbobk.fhfr.pm>
From:   Pascal Giard <pascal.giard@etsmtl.ca>
Date:   Wed, 25 Nov 2020 10:06:03 -0500
Message-ID: <CAJNNDm=2mh43JxrLkpPM6Nuag-9d1acyQH=uwJyQzxOy-gO8rA@mail.gmail.com>
Subject: Re: [PATCH v2] HID: sony: support for ghlive ps3/wii u dongles
To:     Jiri Kosina <jikos@kernel.org>
CC:     Benjamin Tissoires <benjamin.tissoires@redhat.com>,
        <linux-input@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        Sanjay Govind <sanjay.govind9@gmail.com>
Precedence: bulk

Apologies for the resend. I had not realized that gmail's app for
smartphones didn't really support plaintext.

On Wed, Nov 25, 2020 at 8:41 AM Jiri Kosina <jikos@kernel.org> wrote:
>
> On Wed, 25 Nov 2020, Pascal.Giard@etsmtl.ca wrote:
>
> > Thank you for reviewing this new version.
> >
> > You are right, we could totally do without GHL_GUITAR_CONTROLLER.
> >
> > This can be seen as premature generalization or an excess of optimism;
> > I'm assuming that the PS4 also needs magic control messages to behave
> > correctly, and that I will figure those sooner than later. But I may be
> > assuming too much and this will be trivial to add when the time comes.
>
> Yeah, let's extend this only when really needed.

Fair.

> > Do you want me to submit a v3?
>
> Please do, thanks. I'll merge that one, I promise :) Sorry for not
> having catched this in v1 already.

No worries, will do.

Thanks again!

-Pascal