Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp198609pxu; Wed, 25 Nov 2020 17:28:19 -0800 (PST) X-Google-Smtp-Source: ABdhPJx1SnXszXSbRhnacp807ltDJqLgCZ6ZhdgYU5GpYZBpomoYb9Vd5qb9oIOBN7+jF2HK50I4 X-Received: by 2002:a50:9f61:: with SMTP id b88mr392742edf.282.1606354099574; Wed, 25 Nov 2020 17:28:19 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1606354099; cv=none; d=google.com; s=arc-20160816; b=dBgbCRNAHtFMyyg9fh/gWgc2oGApbnqusVWdk0Pdxj16IKIxCCDWPvAb6uMEp5duCf 78OpMkD3aKeWbpsuhnDcZpoXpNT0HYMCJmDX/tFTU4vKEwLpP9SfyZq+vABO8Uy4YnBO BTSWceEObiox9NmZ+ltfoK/7mOWGfSsdLWb8GTKNZGglmWQOpTlNtrcyB63RJozbVPgc QZHHXruLWMcyaCFiquttjhTtv6PwG4u5zOBWxhifLD/e9/tMfJT3fkJ2jRm9FFB8S4oF SM30+XtEBRJtRkqOgNo0y9gfFb6oRa9I0KDAobB2+NBItNk6URLXzx+51rY7OT4m2xr7 rXlg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:message-id:references:in-reply-to :subject:cc:to:from:date:content-transfer-encoding:mime-version :sender:dkim-signature; bh=V16thVLdBJdUt6KU8AVud/cH+EtHnsC94YUQORQwInc=; b=Y1MWomJs59aw1Ur/fdpychbQ4lU95XGJBPHYKuahG4Y4MqcbubMJUIzsccTu2BefxA JVDHL0IQEbTc+6yraUAEgE54+Taaquf1KA+ipWt73VTTE5n3DPrlt7c7ZHzngV00HBX4 +9yb+/SiCv63ql6adRdidVojNAFsYOfCaTEbW3+c6a9gUsKrzhrF/QTd3Mg6NSM7L3xv wNDdPwbt2GLXapK6YAU5/iCTEnIJsMuFo+PoJcy/deeV2wwQXEIKzcmI8hhLg3gC+KQo cWcI/I0vxvT/ltS87xCmu4aQb+ML+JVhirob1hEa+IvdsX7nrOafaM5sobsfJd9YEMhl KeeQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@mg.codeaurora.org header.s=smtp header.b=pPkEQDCu; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id p15si2170757edx.69.2020.11.25.17.27.56; Wed, 25 Nov 2020 17:28:19 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@mg.codeaurora.org header.s=smtp header.b=pPkEQDCu; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730060AbgKZBZ3 (ORCPT + 99 others); Wed, 25 Nov 2020 20:25:29 -0500 Received: from m42-4.mailgun.net ([69.72.42.4]:49995 "EHLO m42-4.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727062AbgKZBZ3 (ORCPT ); Wed, 25 Nov 2020 20:25:29 -0500 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1606353929; h=Message-ID: References: In-Reply-To: Subject: Cc: To: From: Date: Content-Transfer-Encoding: Content-Type: MIME-Version: Sender; bh=V16thVLdBJdUt6KU8AVud/cH+EtHnsC94YUQORQwInc=; b=pPkEQDCu0/IionCXxC9sDpcereCAzcdoE/7T2TCFo3IRcd31LnpHN9ZVvlD1aAWbJ9+ljBnC xlEIYutbwjadys+AkgIK0lFs3RQgSaZlwbEBatIMRk7syi5nbGpaXcysD4UftrfFhKtocsL+ 8QdF8PSzqr5gFqNGUFxf4o0Xeds= X-Mailgun-Sending-Ip: 69.72.42.4 X-Mailgun-Sid: WyI0MWYwYSIsICJsaW51eC1rZXJuZWxAdmdlci5rZXJuZWwub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n03.prod.us-west-2.postgun.com with SMTP id 5fbf040022377520eec09503 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Thu, 26 Nov 2020 01:25:20 GMT Sender: cang=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 65DD8C43465; Thu, 26 Nov 2020 01:25:20 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-caf-mail-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=ALL_TRUSTED,BAYES_00, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: cang) by smtp.codeaurora.org (Postfix) with ESMTPSA id 32D74C433ED; Thu, 26 Nov 2020 01:25:19 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Thu, 26 Nov 2020 09:25:19 +0800 From: Can Guo To: Stanley Chu Cc: asutoshd@codeaurora.org, nguyenb@codeaurora.org, hongwus@codeaurora.org, ziqichen@codeaurora.org, rnayak@codeaurora.org, linux-scsi@vger.kernel.org, kernel-team@android.com, saravanak@google.com, salyzyn@google.com, Alim Akhtar , Avri Altman , "James E.J. Bottomley" , "Martin K. Petersen" , Tomas Winkler , Bean Huo , Bart Van Assche , Satya Tangirala , open list Subject: Re: [PATCH v2 1/2] scsi: ufs: Refector ufshcd_setup_clocks() to remove skip_ref_clk In-Reply-To: <1606352316.23925.1.camel@mtkswgap22> References: <1606202906-14485-1-git-send-email-cang@codeaurora.org> <1606202906-14485-2-git-send-email-cang@codeaurora.org> <1606352316.23925.1.camel@mtkswgap22> Message-ID: <07687efa0e49a5c2266deadad94c92dd@codeaurora.org> X-Sender: cang@codeaurora.org User-Agent: Roundcube Webmail/1.3.9 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2020-11-26 08:58, Stanley Chu wrote: > Hi Can, > > "Refector" in title shall be "Refactor"? > > On Mon, 2020-11-23 at 23:28 -0800, Can Guo wrote: >> Remove the param skip_ref_clk from __ufshcd_setup_clocks(), but keep a >> flag >> in struct ufs_clk_info to tell whether a clock can be disabled or not >> while >> the link is active. >> >> Signed-off-by: Can Guo > > Otherwise looks good to me. > Sorry, will fix it in next version. Thanks, Can Guo. > Reviewed-by: Stanley Chu