Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp343746pxu; Wed, 25 Nov 2020 23:18:14 -0800 (PST) X-Google-Smtp-Source: ABdhPJwOIy09RSgyRuTdY5k5B3QoLzfBGhvIC/15hvN5WtgntP0hxwQWFLONlnszLluCKjrGzHnR X-Received: by 2002:a17:906:b255:: with SMTP id ce21mr1407945ejb.137.1606375094314; Wed, 25 Nov 2020 23:18:14 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1606375094; cv=none; d=google.com; s=arc-20160816; b=hGuZeNyL3b/HK04QdZsJMiGPjvN1Xk76N/iq1idRGWhskWBHg5zI0tjVLz3fgB/6Vi J/1vsN3anq0gCAzVrIIMDSOruJUPAOIFbAhBevZLGd8s/uaZtCB7Hwl2Tryv5/MpI4wN tSiT2H2gjzLlgCq0mg0OZTQTV6MioOsGnVggCil9VqHpZLmIyJQFNb0h9zyvNtdbf9EX n+SF7MUpivTCNgOrs5JyOdb90iifsinn7hpzy6316QZ9Q/oD02VhpsQne9sYWar6hrCm KZGSX4qIAeyDh0s4SUe7Nf46VBThOJ+2M60ZYkenkfp0uot3rkycdJLygHRAgSKavJ8X 7apw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:date:cc:to:from:subject:message-id :dkim-signature; bh=Z/DMutLBZGxo9NPXVt+YC6BHVS50FEMIayBNNBBTrxg=; b=P8kyr3Pwtk9d73VluCGkAv6Q9SjRVzLIfncj3bP+iAkPVD5DPFJRT9iXtNhicQ2C6T 453P4aMkJ3gZxNh8V5mVuE2zT244iN5iejoUYAFQf7NMAqxLIEFZRj/0ApquVKminLmq jzLDeOiq8Z1A3OF4l5ocf3i7ula0PhlbDWZTS6DucSETmHqYycL2WgakVTo7nIwWombO oRFQaRg9qKIIEV0HkKYinyX/uVbRWfld3M4bU+0WyADSL6sQ/8M0OisUT5bVLWRfjj+P t+WEOGMSGKNpqahcKbbeFfKuCG0TNCStOnj/qksoUz4xo0Lw86FK9PhjG5pESSG7uwt0 C0rA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b="I/hFdSZ6"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id w10si738935edv.243.2020.11.25.23.17.50; Wed, 25 Nov 2020 23:18:14 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b="I/hFdSZ6"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731457AbgKYTC4 (ORCPT + 99 others); Wed, 25 Nov 2020 14:02:56 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54358 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730650AbgKYTC4 (ORCPT ); Wed, 25 Nov 2020 14:02:56 -0500 Received: from mail-ej1-x644.google.com (mail-ej1-x644.google.com [IPv6:2a00:1450:4864:20::644]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 00A0AC0613D4; Wed, 25 Nov 2020 11:02:55 -0800 (PST) Received: by mail-ej1-x644.google.com with SMTP id o9so4550447ejg.1; Wed, 25 Nov 2020 11:02:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=message-id:subject:from:to:cc:date:in-reply-to:references :mime-version:content-transfer-encoding; bh=Z/DMutLBZGxo9NPXVt+YC6BHVS50FEMIayBNNBBTrxg=; b=I/hFdSZ61wW4zv+ApmY7lxUsaIp8/Ht/WLIjx4mGzVGJkA07n2VIuxhY3jEvUXPQvv ZNjIjH6KgoPIfMWoSjoaxhaQNNkUwhwCeuxTKLhQZfX3QuMcY/ttJ50cXsMHM+ii0nir aE9+flY3yltw4sgY2OEoHQaAAyG3WiqH64Hwxl/PRH/K9QIg7kFD93Ackwr7eAhKS/nv NUhd+259EsOF7v1Kvy2uj1afCr02O28+Hy+GjeO4MBqZtON/cHP4noWjjn92vDSTKtkO /kmNA/brbx92McZ2es0qIxUEbsBZlcwfNnS/PgUWni1yEw4/6DMtBFjI8mnEk16di+P9 B12w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:mime-version:content-transfer-encoding; bh=Z/DMutLBZGxo9NPXVt+YC6BHVS50FEMIayBNNBBTrxg=; b=a5NG2kI3INyvdrxCc+Z9aB4T/9NPzM+C9bB2wxhzwrP8YDtE/xj7bVFe44+HX4QZlA cVwxTrFHSG9XqILyhEWDeT8HqCvOfvbAMUve4qCgsAuYWGnQRDB/+h/S3Qg9oTGRW/Bh Vx4KyiFvqd4E+zv8OL8wWV3HgPnZRK9Xy9O4DkB/8LG/hHlrT7EQNaHcO2BSaZzVpxQ6 pFFo5bFfh1jn8DpI7LOQ16gWYHJHmJMfM2yvEVapwPIBI7mr0QtikjiKkXezyCeEz84b nuWTeUYNhTO+z5dL3qlkjNB5QewNUazJ/PNHi+32EvCm+2sKAqlb78+Wfdt8O1OIec/a 80ug== X-Gm-Message-State: AOAM5330yOfoKDRH87M8AdmjA8I1ilTqe52X1IUvg+4S2NezXbA7rEsu BaQl7E2tm+nAuBNDnsk4K+E= X-Received: by 2002:a17:906:35da:: with SMTP id p26mr4512672ejb.256.1606330974561; Wed, 25 Nov 2020 11:02:54 -0800 (PST) Received: from ubuntu-laptop (ip5f5bee2a.dynamic.kabel-deutschland.de. [95.91.238.42]) by smtp.googlemail.com with ESMTPSA id s19sm1271788ejz.69.2020.11.25.11.02.52 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 25 Nov 2020 11:02:53 -0800 (PST) Message-ID: <4e84df2ecb17dfb1fc8070953d8690b29615f409.camel@gmail.com> Subject: Re: [PATCH v2 1/2] scsi: ufs: Refector ufshcd_setup_clocks() to remove skip_ref_clk From: Bean Huo To: Can Guo Cc: asutoshd@codeaurora.org, nguyenb@codeaurora.org, hongwus@codeaurora.org, ziqichen@codeaurora.org, rnayak@codeaurora.org, linux-scsi@vger.kernel.org, kernel-team@android.com, saravanak@google.com, salyzyn@google.com, Alim Akhtar , Avri Altman , "James E.J. Bottomley" , "Martin K. Petersen" , Tomas Winkler , Bean Huo , Stanley Chu , Bart Van Assche , Satya Tangirala , open list Date: Wed, 25 Nov 2020 20:02:52 +0100 In-Reply-To: <9484cba7b95c6c6fcbafd96bc35c1dee@codeaurora.org> References: <1606202906-14485-1-git-send-email-cang@codeaurora.org> <1606202906-14485-2-git-send-email-cang@codeaurora.org> <9070660d115dd96c70bc3cc90d5c7dab833f36a8.camel@gmail.com> <0b0c545d80f9a0e8106a634063c23a8f0ba895fc.camel@gmail.com> <9484cba7b95c6c6fcbafd96bc35c1dee@codeaurora.org> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.2 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2020-11-25 at 20:28 +0800, Can Guo wrote: > > On Wed, 2020-11-25 at 08:53 +0800, Can Guo wrote: > > > > > + bool always_on_while_link_active; > > > > > > > > Can, > > > > using a sentence as a parameter name looks a little bit clumsy > > > > to > > > > me. > > > > The meaning has been explained in the comments section. How > > > > about > > > > simplify it and in line with other parameters in the structure? > > > > > > > > > > Do you have a better name in mind? > > > > > > > no specail input in mind, maybe just "bool eternal_on" > > It is like plain "always_on", but it cannot tell the whole story. > If it is not something crutial, let's just let it go first so long > as it does not break the original functionality. What do you say? > > Thanks, > > Can Guo. Can, yes, it is not functional change, but always_on_while_link_active is too fat, and not non-productive way. anyway, Reviewed-by: Bean Huo