Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp347255pxu; Wed, 25 Nov 2020 23:26:25 -0800 (PST) X-Google-Smtp-Source: ABdhPJzPoTEkNhjrcxE2oKYoaf91WC7AJuuuIJzFtjbetUG2kuom40x81izVb1AyVQg52uWRhQZP X-Received: by 2002:a05:6402:142f:: with SMTP id c15mr1240812edx.33.1606375585279; Wed, 25 Nov 2020 23:26:25 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1606375585; cv=none; d=google.com; s=arc-20160816; b=Hs5I3PFX2O5hbSp69HaJ3BwIfdDXDfMkXP+++yeGcdmrstol8wySvpWWwzb6nvy2WJ EMNhZuBIm9QV8JDhkr+q8AGOckkrDntNFrvMMG6PqEAQyU2BK15S6fBCWcaG1KuJ1aWD csXXThq/UWxhULiw1jdqAiOgpXTwQd1XbByxHJWdF5uCEVErVEWJb2L905lLHNTMz5F5 59Q/ZSKDmjL03PoI704t5RKWyBSkywiRn4rsnybY+m1lMk7ae1nuXDm6zwVp9DIKmFET SLELqulSRB4PHQsp2s5YtUrKIQ7d/KLDKxq2CwkElrB5CB80bxbSNZ0YCRTSonVZznWj ZtoQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=8QfaVxiDLB3Gr4Kzl+UMgDXrlciFAc5utbuwTD4kc9A=; b=HS9G89KGhKE/IRGIwzKGdDpP5by3Pp0prqo+9t/XI/VYHaiSIADueeWTQ2LfH6Y+vG xyTOImJWtyDKyAtwb9mIEAxxjXjBjqF7OIokU5PYdlYy4BgB/aZthr5NTyfi3+Mgx357 5L1fiQQBwTbrJhfZLA43QtlbfJhO2cfBdV1Zq6ruZVy7Y7A8NS3T8dMcVKzxVm/iwpvJ O5OB8zqrK4HNqAcz7LU+Zcglp8HXEoUmN96S4fIYJjBgSnUaHAAR+C1yURlvAOQyg0HS xpS8/XoZwO1bYGSPGKBzBCwul7S7/3m+qtlyymR7vbJ80P85SJWyoesOEqc11G/bM+bN cNsQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id b5si2618696ejj.52.2020.11.25.23.25.59; Wed, 25 Nov 2020 23:26:25 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729092AbgKYTsa (ORCPT + 99 others); Wed, 25 Nov 2020 14:48:30 -0500 Received: from jabberwock.ucw.cz ([46.255.230.98]:38154 "EHLO jabberwock.ucw.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729007AbgKYTs3 (ORCPT ); Wed, 25 Nov 2020 14:48:29 -0500 Received: by jabberwock.ucw.cz (Postfix, from userid 1017) id 0FA611C0B81; Wed, 25 Nov 2020 20:48:26 +0100 (CET) Date: Wed, 25 Nov 2020 20:48:25 +0100 From: Pavel Machek To: Qinglang Miao Cc: Dan Murphy , linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] leds: lp50xx: add missing fwnode_handle_put in error handling case Message-ID: <20201125194825.GC9791@amd> References: <20201119070841.712-1-miaoqinglang@huawei.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="eHhjakXzOLJAF9wJ" Content-Disposition: inline In-Reply-To: <20201119070841.712-1-miaoqinglang@huawei.com> User-Agent: Mutt/1.5.23 (2014-03-12) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --eHhjakXzOLJAF9wJ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi! > Fix to set ret and goto child_out for fwnode_handle_put(child) > in the error handling case rather than simply return, as done > elsewhere in this function. >=20 > Fixes: 242b81170fb8 ("leds: lp50xx: Add the LP50XX family of the RGB LED = driver") > Reported-by: Hulk Robot > Suggested-by: Pavel Machek > Signed-off-by: Qinglang Miao Thanks, applied. Best regards, Pavel =09 --=20 http://www.livejournal.com/~pavelmachek --eHhjakXzOLJAF9wJ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAl++tQkACgkQMOfwapXb+vJG0wCaAlLJdIuFosHFwt3YMwltlylb wFcAoLER+4Rr7BWnyCik1CE2QBeu/YA+ =/Cv4 -----END PGP SIGNATURE----- --eHhjakXzOLJAF9wJ--