Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp347286pxu; Wed, 25 Nov 2020 23:26:30 -0800 (PST) X-Google-Smtp-Source: ABdhPJw8UQscXOtRz0LD/2rNeCxtYeQ20EQZOJts+MrtOnGuDam/sUt9MbhnbBbQ5y5CJTYkN98a X-Received: by 2002:a17:906:254d:: with SMTP id j13mr1476544ejb.376.1606375590459; Wed, 25 Nov 2020 23:26:30 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1606375590; cv=none; d=google.com; s=arc-20160816; b=dSYD2xMR2ehIo1upesrCxQMMm9cEOfNr6g02VW7eiahHiFVm7iTiZt2xt4Q4wUjyQ3 6DK33bbRlfdwXFAaeQE27NpG2vLJEmQqANomE7JU68Y4SmScPyf25HzXzIgXS2s3ish5 ITbMQZQuPhXPotN0k6Rqv996xNjDUn4j7m/Lt4jXWV/AW+qaQKqULWv5R3Q6cuPQdkA6 oFhni4ZvXu3R4KiP6JdBs90Ow8m4U16aSVrIrdcHH9gXFnJd47DNzA8/Il0b8qQjL7Dc wDKrg5FXvGdONjuZnKSJGkr/ovgak1Hh1QPaEJc0bLCPQbiSuzzeI9Yn9FOVmsF4RDib Apsg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=YnT2SRQnEqHJxmnDetz9zuQnCXZTtJuQ0xVRC+i6FAE=; b=mxgAqlZVDkTxDLUDBK8uD4UjAex59Z0jicGid2hgLYKdKREALsevtVg69NiDfF2DpK +ib8D4GngXsvO6bA7vKtxt7zaFgscd8r9h63XRdcgYazkZrdjqY7iiuJqbSKvZSDyltb d9igUQjF0FSAt/i0qpK3b2iTF1Vvvhxy8s5L5SipLlrd4he/+Cuzjj6aJkiG+P2ve2g6 qfk96tDQyihkquVpIjUJ5XTp4DxXsQOVJyxEZmV62TSksDRCtvpEiVL/W4UJDlMyeueB acZchqf0On2etAXnbhETIH4JmFC15t3mIG5FekaShbZI/61yiymdbpcMWu2yINiKWHKb QVHQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id c1si2569107edx.275.2020.11.25.23.26.07; Wed, 25 Nov 2020 23:26:30 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727251AbgKYTu2 (ORCPT + 99 others); Wed, 25 Nov 2020 14:50:28 -0500 Received: from jabberwock.ucw.cz ([46.255.230.98]:38274 "EHLO jabberwock.ucw.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728552AbgKYTu2 (ORCPT ); Wed, 25 Nov 2020 14:50:28 -0500 Received: by jabberwock.ucw.cz (Postfix, from userid 1017) id 937791C0B7A; Wed, 25 Nov 2020 20:50:25 +0100 (CET) Date: Wed, 25 Nov 2020 20:50:24 +0100 From: Pavel Machek To: Qinglang Miao Cc: Dan Murphy , linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] leds: lp50xx: add missing fwnode_handle_put in error handling case Message-ID: <20201125195024.GD9791@amd> References: <20201119070841.712-1-miaoqinglang@huawei.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="+KJYzRxRHjYqLGl5" Content-Disposition: inline In-Reply-To: <20201119070841.712-1-miaoqinglang@huawei.com> User-Agent: Mutt/1.5.23 (2014-03-12) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --+KJYzRxRHjYqLGl5 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu 2020-11-19 15:08:41, Qinglang Miao wrote: > Fix to set ret and goto child_out for fwnode_handle_put(child) > in the error handling case rather than simply return, as done > elsewhere in this function. >=20 > Fixes: 242b81170fb8 ("leds: lp50xx: Add the LP50XX family of the RGB LED = driver") > Reported-by: Hulk Robot > Suggested-by: Pavel Machek > Signed-off-by: Qinglang Miao Sorry, spoke too fast. We already had equivalent patch in by Fixes: 242b81170fb8 ("leds: lp50xx: Add the LP50XX family of the RGB LED driver") Signed-off-by: Christophe JAILLET Let me push that out in few minutes.. so you can double-check. Sorry for confusion, Pavel --=20 http://www.livejournal.com/~pavelmachek --+KJYzRxRHjYqLGl5 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAl++tYAACgkQMOfwapXb+vLd2ACbBWbO0idpuWB6UwZ2t6VBJjqE yl8AoJmjVq45nB0tbbqMtP8K3Xjwihbc =Ht2Z -----END PGP SIGNATURE----- --+KJYzRxRHjYqLGl5--