Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v3 1/5] genirq/affinity: Add irq_update_affinity_desc()
To:     Daniel Wagner <dwagner@suse.de>
CC:     <jejb@linux.ibm.com>, <martin.petersen@oracle.com>,
        <lenb@kernel.org>, <rjw@rjwysocki.net>,
        <gregkh@linuxfoundation.org>, <tglx@linutronix.de>,
        <linux-scsi@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <linuxarm@huawei.com>, <linux-acpi@vger.kernel.org>,
        <maz@kernel.org>
References: <1606324841-217570-1-git-send-email-john.garry@huawei.com>
 <1606324841-217570-2-git-send-email-john.garry@huawei.com>
 <20201126085145.jjioc7belyny5kp4@beryllium.lan>
From:   John Garry <john.garry@huawei.com>
Message-ID: <47442f07-4ea2-46ed-59a8-c1fa2857f4c4@huawei.com>
Date:   Thu, 26 Nov 2020 08:54:37 +0000
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101
 Thunderbird/68.1.2
MIME-Version: 1.0
In-Reply-To: <20201126085145.jjioc7belyny5kp4@beryllium.lan>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi Daniel,

> 
> On Thu, Nov 26, 2020 at 01:20:37AM +0800, John Garry wrote:
>> +	activated = irqd_is_activated(&desc->irq_data);
>> +	if (activated)
>> +		irq_domain_deactivate_irq(&desc->irq_data);
>> +
>> +	if (affinity->is_managed) {
>> +		irqd_set(&desc->irq_data, IRQD_AFFINITY_MANAGED);
>> +		irqd_set(&desc->irq_data, IRQD_MANAGED_SHUTDOWN);
>> +	}
>> +
>> +	cpumask_copy(desc->irq_common_data.affinity, &affinity->mask);
>> +
>> +	/* Restore the activation state */
>> +	if (activated)
>> +		irq_domain_deactivate_irq(&desc->irq_data);
> Shouldn't this be irq_domain_activate_irq() ?

Yeah, I think so. Blushes.

Cheers,
John