Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 26 Nov 2020 10:15:37 +0100
From:   Christoph Hellwig <hch@lst.de>
To:     Yicong Yang <yangyicong@hisilicon.com>
Cc:     Christoph Hellwig <hch@lst.de>, viro@zeniv.linux.org.uk,
        linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
        prime.zeng@huawei.com, linuxarm@huawei.com
Subject: Re: [PATCH] fs: export vfs_stat() and vfs_fstatat()
Message-ID: <20201126091537.GA21957@lst.de>
References: <1606374948-38713-1-git-send-email-yangyicong@hisilicon.com> <20201126071848.GA17990@lst.de> <696f0e06-4f4d-0a61-6e13-f5af433594bf@hisilicon.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <696f0e06-4f4d-0a61-6e13-f5af433594bf@hisilicon.com>
User-Agent: Mutt/1.5.17 (2007-11-01)
Precedence: bulk

On Thu, Nov 26, 2020 at 05:08:26PM +0800, Yicong Yang wrote:
> > And why would you want to use them in kernel module?  Please explain
> > that in the patch that exports them, and please send that patch in the
> > same series as the patches adding the users.
> 
> we're using it in the modules for testing our crypto driver on our CI system.
> is it mandatory to upstream it if we want to use this function?

Yes.  And chances are that you do not actaully need these functions
either, but to suggest a better placement I need to actually see the
code.