Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] can: m_can: add support for bosch mcan version 3.3.0
To:     Marc Kleine-Budde <mkl@pengutronix.de>,
        Pankaj Sharma <pankj.sharma@samsung.com>,
        linux-can@vger.kernel.org, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Cc:     sriram.dash@samsung.com, dmurphy@ti.com, wg@grandegger.com,
        davem@davemloft.net, kuba@kernel.org, pankaj.dubey@samsung.com
References: <CGME20201126045221epcas5p46f00cd452b8023262f5556e6f4567352@epcas5p4.samsung.com>
 <1606366302-5520-1-git-send-email-pankj.sharma@samsung.com>
 <e7a65c29-d0b0-358f-fc5f-c08944ada4df@pengutronix.de>
From:   Oliver Hartkopp <socketcan@hartkopp.net>
Message-ID: <e6f36ce5-1197-d93b-705b-2f7d68761f04@hartkopp.net>
Date:   Thu, 26 Nov 2020 12:21:36 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.12.0
MIME-Version: 1.0
In-Reply-To: <e7a65c29-d0b0-358f-fc5f-c08944ada4df@pengutronix.de>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 26.11.20 11:48, Marc Kleine-Budde wrote:
> On 11/26/20 5:51 AM, Pankaj Sharma wrote:
>> Add support for mcan bit timing and control mode according to bosch mcan IP
>> version 3.3.0
>> The mcan version read from the Core Release field of CREL register would be
>> 33. Accordingly the properties are to be set for mcan v3.3.0
> 
> BTW: do you have the v3.2 and v3.1 datasheets?

Unfortunately Bosch does not give access to older documents, so I tried 
to concentrate all my downloaded versions of public available 
information here:

https://github.com/hartkopp/M_CAN-User-Manual-History

PR's with updates are welcome ;-)

Best,
Oliver

ps. @Bosch Semiconductors - Read the README there! I would like to 
remove my own collection.

> 
> Marc
> 
>> Signed-off-by: Pankaj Sharma <pankj.sharma@samsung.com>
>> ---
>> Depends on:
>> https://marc.info/?l=linux-can&m=160624495218700&w=2
>>
>>   drivers/net/can/m_can/m_can.c | 2 ++
>>   1 file changed, 2 insertions(+)
>>
>> diff --git a/drivers/net/can/m_can/m_can.c b/drivers/net/can/m_can/m_can.c
>> index 86bbbfa..7652175 100644
>> --- a/drivers/net/can/m_can/m_can.c
>> +++ b/drivers/net/can/m_can/m_can.c
>> @@ -1385,6 +1385,8 @@ static int m_can_dev_setup(struct m_can_classdev *m_can_dev)
>>   						&m_can_data_bittiming_const_31X;
>>   		break;
>>   	case 32:
>> +	case 33:
>> +		/* Support both MCAN version v3.2.x and v3.3.0 */
>>   		m_can_dev->can.bittiming_const = m_can_dev->bit_timing ?
>>   			m_can_dev->bit_timing : &m_can_bittiming_const_31X;
>>   
>>
> 
>