Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 26 Nov 2020 12:33:46 +0100
From:   Thierry Reding <thierry.reding@gmail.com>
To:     Vidya Sagar <vidyas@nvidia.com>
Cc:     lorenzo.pieralisi@arm.com, robh+dt@kernel.org, bhelgaas@google.com,
        jonathanh@nvidia.com, amanharitsh123@gmail.com,
        dinghao.liu@zju.edu.cn, kw@linux.com, linux-pci@vger.kernel.org,
        linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org,
        kthota@nvidia.com, mmaddireddy@nvidia.com, sagar.tv@gmail.com
Subject: Re: [PATCH V4 2/6] PCI: tegra: Map configuration space as nGnRnE
Message-ID: <X7+SmtN+8T4HQb/M@ulmo>
References: <20201109171937.28326-1-vidyas@nvidia.com>
 <20201109171937.28326-3-vidyas@nvidia.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="1uHNs3U+2+JtnK0v"
Content-Disposition: inline
In-Reply-To: <20201109171937.28326-3-vidyas@nvidia.com>
User-Agent: Mutt/2.0.2 (d9268908) (2020-11-20)
Precedence: bulk


--1uHNs3U+2+JtnK0v
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Nov 09, 2020 at 10:49:33PM +0530, Vidya Sagar wrote:
> As specified in the comment for pci_remap_cfgspace() define in
> arch/arm64/include/asm/io.h file, PCIe configuration space should be
> mapped as nGnRnE. Hence changing to dev_pci_remap_cfgspace() from
> devm_ioremap_resource() for mapping DBI space as that is nothing but
> the root port's own configuration space.
>=20
> Signed-off-by: Vidya Sagar <vidyas@nvidia.com>
> ---
> V4:
> * None
>=20
> V3:
> * None
>=20
> V2:
> * Changed 'Strongly Ordered' to 'nGnRnE'
>=20
>  drivers/pci/controller/dwc/pcie-tegra194.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>=20
> diff --git a/drivers/pci/controller/dwc/pcie-tegra194.c b/drivers/pci/con=
troller/dwc/pcie-tegra194.c
> index b172b1d49713..7a0c64436861 100644
> --- a/drivers/pci/controller/dwc/pcie-tegra194.c
> +++ b/drivers/pci/controller/dwc/pcie-tegra194.c
> @@ -2108,7 +2108,9 @@ static int tegra_pcie_dw_probe(struct platform_devi=
ce *pdev)
>  	}
>  	pcie->dbi_res =3D dbi_res;
> =20
> -	pci->dbi_base =3D devm_ioremap_resource(dev, dbi_res);
> +	pci->dbi_base =3D devm_pci_remap_cfgspace(dev,
> +						dbi_res->start,
> +						resource_size(dbi_res));
>  	if (IS_ERR(pci->dbi_base))
>  		return PTR_ERR(pci->dbi_base);
> =20

Similarly to patch 1/6, this is no longer required because it's already
part of one of Rob's earlier patches, so this, too, can be dropped.

Thierry

--1uHNs3U+2+JtnK0v
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAl+/kpoACgkQ3SOs138+
s6FSExAAr30Qy/vBX5DBl5fVA3FJkfeNDnUmzkwemY51MjQZsvbjc7NdbLfDrcaf
0UgdOICWxs+07FnROnyM3rQbOy3HDwqOV6AGlq+68P3FigHd5tdBRxNTi+8827gU
562X/fULH4g9qYmUyPuGl6Q5FrJNRedwfYR7s79eoVYkxxvfLMk0KSFemLUxPf8M
koduuwGmB2tQje3PgkmU6a/nA3wrrVwD6FC9KDhA5YPG6a1LRku/t1e6bpUBnyzk
TwE4s5OzWNZXR07BFQTLrIBE3dSHVSDMVQOKmtOtquBtlJ1bpVOFyY9gSwYx9LV3
1nnHtU+COmdj2d78yuR1Fbkzi1l5dfcmhe1tYX45FJfTVFnGUOrACKesKj0bZqbh
3DfiT7sVgS69EJKpqSJWUPRezeAMxCgvUqvrdZi3vXwZY1LPuOkqexM0rHkWnWZN
1OZI/zsdZJ8Pf49YUMNE1JG0G4PpgvEtkVdFUDVDsHi4MbevbZ6v4UJya5iPHVlW
LM3SBqPhnnM6dKg5bPoVqAETHbS7T6HTe6YL8R98hN0dIhF8T3GkMiRD4m92MCiJ
kYdYvsMyf0WGQT5GKIDcwmPd1OQrZzUcOrYP7tNOFBg3xhjzMGQGHqcCdd0itmXh
P3478M5nngyTcz7vgocQDQ14FUWnruLmDH88NfY0FGvbLZirNtI=
=qdzW
-----END PGP SIGNATURE-----

--1uHNs3U+2+JtnK0v--