Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 26 Nov 2020 12:33:07 +0100
From:   Thierry Reding <thierry.reding@gmail.com>
To:     Vidya Sagar <vidyas@nvidia.com>
Cc:     lorenzo.pieralisi@arm.com, robh+dt@kernel.org, bhelgaas@google.com,
        jonathanh@nvidia.com, amanharitsh123@gmail.com,
        dinghao.liu@zju.edu.cn, kw@linux.com, linux-pci@vger.kernel.org,
        linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org,
        kthota@nvidia.com, mmaddireddy@nvidia.com, sagar.tv@gmail.com
Subject: Re: [PATCH V4 1/6] PCI: tegra: Fix ASPM-L1SS advertisement disable
 code
Message-ID: <X7+Sc5Mtp4OvrO4P@ulmo>
References: <20201109171937.28326-1-vidyas@nvidia.com>
 <20201109171937.28326-2-vidyas@nvidia.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="QUSexSbmiWV2+Jzb"
Content-Disposition: inline
In-Reply-To: <20201109171937.28326-2-vidyas@nvidia.com>
User-Agent: Mutt/2.0.2 (d9268908) (2020-11-20)
Precedence: bulk


--QUSexSbmiWV2+Jzb
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Nov 09, 2020 at 10:49:32PM +0530, Vidya Sagar wrote:
> If the absence of CLKREQ# signal is indicated by the absence of
> "supports-clkreq" in the device-tree node, current driver is disabling
> the advertisement of ASPM-L1 Sub-States *before* the ASPM-L1 Sub-States
> offset is correctly initialized. Since default value of the ASPM-L1SS
> offset is zero, this is causing the Vendor-ID wrongly programmed to 0x10d2
> instead of Nvidia's 0x10de thereby the quirks applicable for Tegra194 are
> not being applied. This patch fixes this issue by refactoring the
> code that disables the ASPM-L1SS advertisement.
>=20
> Fixes: 56e15a238d92 ("PCI: tegra: Add Tegra194 PCIe support")
> Signed-off-by: Vidya Sagar <vidyas@nvidia.com>
> ---
> V4:
> * None
>=20
> V3:
> * None
>=20
> V2:
> * None
>=20
>  drivers/pci/controller/dwc/pcie-tegra194.c | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)

Looks like this no longer applies cleanly after that other fix that you
sent earlier. But looking more closely, that's because that other fix
already incorporates an equivalent change, so I think this can be
dropped from this series.

Thierry

--QUSexSbmiWV2+Jzb
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAl+/knMACgkQ3SOs138+
s6HZMw/+Np2N2UUAqaMpg/MvWdVK9xG7mYjMmqccpmf8B2Gan0nXW9a4cWUC8OIa
TfEuy9GaHiBWdQKnYgtawXmPen/ZremoFl3EbIqcgOuMzkV28dpRBqFu4yaOmnun
JaSMo3R21yv4gjH5lHTmimcXeHIKKizQhkw0t8uov+Qdo8coypV/85vuxCh8c1XR
7LBFG/fUyZjip4H2rLygZyF6eKDPSa6ydYhb1PytrNtYz99kjPOzyOtsTA/P7N5A
2sGVxvF/o7UR1rVHmBSiUr4tPKEDW1Wy/37rygvJ04vWIO9hgaITGCCnjTMe7zG2
3OQnV5hS8QwAfVeW5RMuNcnq/wpG/v3sZWwqkU9clhC4eNfXsJ431ORKWrUB2CAG
0HFro8bFVxPcKxJ1MehA0b+yB1k9CwwjBsMn0GnqKQE1EmHcT51mLfjMmtxHhAoJ
Ss2/eXvWFV7p8uTrwir4ExKAiaOzEe4jWPp0SemPlrXftCJqsi3WSor/bTZLRmVA
ORGbqfXdG3wnw2Qj0gV9sL4qu7XU92V+ARAuE/f9cZt9ZbI+ffVy3BQwZsF9/zmp
VsAFPQColm4qbJFWoPuS6MwL2ajnSQyr37/wBv5Ik8eHTAGdKUWFE+1Ie+8aPSWR
rzDfC4KzLCsjZnDhiPc/lwzKoZPpKG4UUnNWdItoaBP+TQKNHHU=
=UII4
-----END PGP SIGNATURE-----

--QUSexSbmiWV2+Jzb--