Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp676241pxu; Thu, 26 Nov 2020 08:48:24 -0800 (PST) X-Google-Smtp-Source: ABdhPJyVyVU7fQLwjnziQgRThXgzVsneQVtxbfPRBh3HDvmu+sgWu4OokN8D63hBV54rgEZEZWXr X-Received: by 2002:aa7:c61a:: with SMTP id h26mr3450742edq.327.1606409304775; Thu, 26 Nov 2020 08:48:24 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1606409304; cv=none; d=google.com; s=arc-20160816; b=g46GZUqjWZ+CdarxXcWDuetOIfrxl1GKwygE9xFko4CsoeMdhhYosYqEBb4zJg2veI 4hyHlFIldblahdm2Og+yyX1EPuCLMyr+h7NPZlcXLjlR6cCl3Tkkzapt9GSfnsOWUk+q Ch76JzS9dBU46tnwXTejcr/9uMX7wvAoQ1AS4+DV+Ctb72Fui7gCkbjTDZ7m9EpQrmOR 2KLcTI5mWRZWvdsVCAr5ys8RbckWTJD3xQD+ff+MTNWbvrf/lBR3z/J07bkqzEjBOaNt r/p8aGZwyxV6YnECu08vOg0uG8tKA5xrDvm5rW9cTzv6YNXdXgVPHLTBzhhdwiCYFegw +Djg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:date:cc:to:from:subject :message-id:dkim-signature; bh=cd7iNQed0zlJwSeDfpiUl39uv1gJodD4NzCVOu8rCLs=; b=QcIYEbIHjTVLMP2zP18YBy16yHd3wthr+WrZxgPDKtgzihXa80WBB2Et7DMSx8a+aH InqMdX1IywdRMFgGsl8diY3PYo4Q1zqPaNVMZ1NjnyGUvgpZw7oVAmsU26OTAYYlBlMP bFlhqcb0jA84EqPp/Br1JyBBHmjiGr02w04zP0rfoXqWcMNK3K0NIqVioD2ybOkvpBLA DtvhBWAz2LfJjLHl2qFFqCAc41WGmoilbL97UrJmIm6d0J4A9c0FuLMvACGmApSQclmp +SXXKn/qvw0Lb4Ju/rVE7I8oe8FjklnH/ga+MlkFcJegujgRPJaq/jyewp+PatHhFpxm zqXA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=fAOYntqj; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id ox26si3680355ejb.107.2020.11.26.08.48.00; Thu, 26 Nov 2020 08:48:24 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=fAOYntqj; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2403889AbgKZQoN (ORCPT + 99 others); Thu, 26 Nov 2020 11:44:13 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58832 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2403862AbgKZQoN (ORCPT ); Thu, 26 Nov 2020 11:44:13 -0500 Received: from mail-wr1-x444.google.com (mail-wr1-x444.google.com [IPv6:2a00:1450:4864:20::444]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E0102C0613D4 for ; Thu, 26 Nov 2020 08:44:11 -0800 (PST) Received: by mail-wr1-x444.google.com with SMTP id g14so2771408wrm.13 for ; Thu, 26 Nov 2020 08:44:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=message-id:subject:from:to:cc:date:in-reply-to:references :user-agent:mime-version:content-transfer-encoding; bh=cd7iNQed0zlJwSeDfpiUl39uv1gJodD4NzCVOu8rCLs=; b=fAOYntqjNSrmZCwKFUIYdAFgeo+8pFj+pDznCxjxqeJdUzBJ/0eMOlnLYFOU8NqK3Y HlUHqRm9tqTPXXGghmEX5SORn5DSzu2nfA2JTibhv0xMElsW3qEU/uh8qLNiaeWmkxtZ Rb7pgkmYZj/F55O9vuMC6rivibeoTzHQwaVpo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=cd7iNQed0zlJwSeDfpiUl39uv1gJodD4NzCVOu8rCLs=; b=lWb7r1XqiS01BrII243Xn8E8geRojHqALFYV1fOFUQu8GVqVWVyX3dyRXdCTjmYmhE Ld1ekjWppoSG/EjRMvqdCyLVI1sXJuB0V9fAfF25zuKFihxQvieZWt/WEbXRlxLIldUF Hi2QdjA+h+oHk1aezEagiZixRgGTU+cqwJSe9P3zyWZ2piY/OMlFvVodFrI67iGLmORu 8CIG//2l+HyEYvJuCWAEmHoLsIrQMTavPY8SwNA62+rzYBxuAsxNXvMQLMUGyzPYJq8z sU99qAyJLaCtoCc47cuJS40h63OCgeByPBQkYiWgJ+P52ySCYvgxMdrakD35hTYY9Ryc UzRg== X-Gm-Message-State: AOAM5311+jtWvZmnrDZ1XJeSX1AgQFN3n7qtkPs3Klb4S9cqdBzZi2Ad nUF05v67rwVl53cLgwcWSJniAQ== X-Received: by 2002:adf:f181:: with SMTP id h1mr4829890wro.267.1606409050689; Thu, 26 Nov 2020 08:44:10 -0800 (PST) Received: from ?IPv6:2a04:ee41:4:1318:ea45:a00:4d43:48fc? ([2a04:ee41:4:1318:ea45:a00:4d43:48fc]) by smtp.gmail.com with ESMTPSA id v7sm2871733wma.26.2020.11.26.08.44.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Nov 2020 08:44:10 -0800 (PST) Message-ID: <7893b7adbe4a3e676b329cb0d88cf315217686b2.camel@chromium.org> Subject: Re: [PATCH v2 5/5] bpf: Add an iterator selftest for bpf_sk_storage_get From: Florent Revest To: Martin KaFai Lau Cc: bpf@vger.kernel.org, viro@zeniv.linux.org.uk, davem@davemloft.net, kuba@kernel.org, ast@kernel.org, daniel@iogearbox.net, yhs@fb.com, andrii@kernel.org, kpsingh@chromium.org, revest@google.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org Date: Thu, 26 Nov 2020 17:44:09 +0100 In-Reply-To: <20201120003217.pnqu66467punkjln@kafai-mbp.dhcp.thefacebook.com> References: <20201119162654.2410685-1-revest@chromium.org> <20201119162654.2410685-5-revest@chromium.org> <20201120003217.pnqu66467punkjln@kafai-mbp.dhcp.thefacebook.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.36.4-2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2020-11-19 at 16:32 -0800, Martin KaFai Lau wrote: > Does it affect all sk(s) in the system? Can it be limited to > the sk that the test is testing? Oh I just realized I haven't answered you here yet! Thanks for the reviews. :D I'm sending a v3 addressing your comments