Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 26 Nov 2020 17:55:18 +0100
From:   Jiri Olsa <jolsa@redhat.com>
To:     Peter Zijlstra <peterz@infradead.org>
Cc:     Jiri Olsa <jolsa@kernel.org>,
        Arnaldo Carvalho de Melo <acme@kernel.org>,
        lkml <linux-kernel@vger.kernel.org>,
        Ingo Molnar <mingo@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>,
        Namhyung Kim <namhyung@kernel.org>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Michael Petlan <mpetlan@redhat.com>,
        Song Liu <songliubraving@fb.com>,
        Ian Rogers <irogers@google.com>,
        Stephane Eranian <eranian@google.com>,
        Alexey Budankov <alexey.budankov@linux.intel.com>,
        Andi Kleen <ak@linux.intel.com>,
        Adrian Hunter <adrian.hunter@intel.com>
Subject: Re: [PATCH 03/24] perf: Add build id data in mmap2 event
Message-ID: <20201126165518.GQ2164284@krava>
References: <20201117110053.1303113-1-jolsa@kernel.org>
 <20201117110053.1303113-4-jolsa@kernel.org>
 <20201117111334.GL3121392@hirez.programming.kicks-ass.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20201117111334.GL3121392@hirez.programming.kicks-ass.net>
Precedence: bulk

On Tue, Nov 17, 2020 at 12:13:34PM +0100, Peter Zijlstra wrote:
> On Tue, Nov 17, 2020 at 12:00:32PM +0100, Jiri Olsa wrote:
> > Adding support to carry build id data in mmap2 event.
> > 
> > The build id data replaces maj/min/ino/ino_generation
> > fields, which are also used to identify map's binary,
> > so it's ok to replace them with build id data:
> > 
> >   union {
> >           struct {
> >                   u32       maj;
> >                   u32       min;
> >                   u64       ino;
> >                   u64       ino_generation;
> >           };
> >           struct {
> >                   u8        build_id_size;
> >                   u8        __reserved_1;
> >                   u16       __reserved_2;
> >                   u8        build_id[20];
> >           };
> >   };
> > 
> > Replaced maj/min/ino/ino_generation fields give us size
> > of 24 bytes. We use 20 bytes for build id data, 1 byte
> > for size and rest is unused.
> > 
> > There's new misc bit for mmap2 to signal there's build
> > id data in it:
> > 
> >   #define PERF_RECORD_MISC_MMAP_BUILD_ID   (1 << 14)
> > 
> > Signed-off-by: Jiri Olsa <jolsa@kernel.org>
> 
> Seems sane enough; how do we want to route this?
> 
> Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org>
> 

I still need review from bpf folks, but then I guess
Arnaldo's tree would be the best, because it's mostly
tools changes.. I'm sending new version

jirka