Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp880545pxu; Thu, 26 Nov 2020 14:59:56 -0800 (PST) X-Google-Smtp-Source: ABdhPJwrQkIcewFkQqKGWob4+Wxjvm0GgFngsJiQo1hcovWFd+Anl5HG2uXPAIIqeicR7dRZvuPg X-Received: by 2002:a17:906:ca93:: with SMTP id js19mr4679354ejb.537.1606431596450; Thu, 26 Nov 2020 14:59:56 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1606431596; cv=none; d=google.com; s=arc-20160816; b=s4WVZf4c9IUfAXTi55SD8Ygt7C+Jn91QDNJO+Bi4v5+nNRprfj6EaBVMQ2140Eh+tA YtX3upgXq6v/Qzo6ktESxSy0qOQ2f8C/X9QTE3rWiIyIYRxm9XAVz5xR68b18EncRyuO 7CWpaSMTg7YQpvFL586gTwFIOHWF7yZB8JSw1jK3AOcxQNEGbpIUvAHNrGLgG86JxX+Z WR0euIQdM6UVeyz1A8n7G0wlxsKN5cAQgCyA5UQ4iwCed1gsbD+nvoGhD6lTQdzac9rr WWrsHEioEBdcPbp7PNdTgNVSuEtRe5qAeoSOwl4YzrqLnjXr6mEnE2hmEUBTUAGJdCRC UfJg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=ZMbyPeWloZkz/VYBirWruAeglk3oSVtJYOWDOIjBn5A=; b=jMAJorPEMsCObhB9e4M/wUIaY0smZR+S761k1kF7sGReVCXe/fIpfnBZ96wr5Fhwqz 5oHH52SwmP9PbIebV57kGBl5C6TmDvoQfSMKfyF09Xy7fcSNCwqKEyJMIARfVY9QNjXi bbwdjxamRwEVMGTD70QJICmFm8Pd5RKVXpqUl7Loaz3PFZYjUD8yZ/lrU8VX1rKm7tUr uXN4pHFXerh5G9rXihf4mle8BfDrQzRAMAG5FrIw0JRmz+YJ9+RqXt7Z4mVJpxuc/n2+ 8vk5ncJ5qnlxog7044A8s74dSOpH2wqwW52i8NJ61ruSnQtVUl6y9SxIU87N+tDJWMQP TYRQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id e17si2516319ejc.373.2020.11.26.14.59.34; Thu, 26 Nov 2020 14:59:56 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388400AbgKZHSv (ORCPT + 99 others); Thu, 26 Nov 2020 02:18:51 -0500 Received: from verein.lst.de ([213.95.11.211]:33267 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388325AbgKZHSv (ORCPT ); Thu, 26 Nov 2020 02:18:51 -0500 Received: by verein.lst.de (Postfix, from userid 2407) id 281DA68B02; Thu, 26 Nov 2020 08:18:49 +0100 (CET) Date: Thu, 26 Nov 2020 08:18:48 +0100 From: Christoph Hellwig To: Yicong Yang Cc: viro@zeniv.linux.org.uk, linux-fsdevel@vger.kernel.org, hch@lst.de, linux-kernel@vger.kernel.org, prime.zeng@huawei.com, linuxarm@huawei.com Subject: Re: [PATCH] fs: export vfs_stat() and vfs_fstatat() Message-ID: <20201126071848.GA17990@lst.de> References: <1606374948-38713-1-git-send-email-yangyicong@hisilicon.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1606374948-38713-1-git-send-email-yangyicong@hisilicon.com> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 26, 2020 at 03:15:48PM +0800, Yicong Yang wrote: > The public function vfs_stat() and vfs_fstatat() are > unexported after moving out of line in > commit 09f1bde4017e ("fs: move vfs_fstatat out of line"), > which will prevent the using in kernel modules. > So make them exported. And why would you want to use them in kernel module? Please explain that in the patch that exports them, and please send that patch in the same series as the patches adding the users.