Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp900903pxu; Thu, 26 Nov 2020 15:35:38 -0800 (PST) X-Google-Smtp-Source: ABdhPJxj11ojozGFvg+GGdFJwfxcy946j6Jheg0bYG1JR+JtWXWZHOJuNpWiHk3fQNacb7DdcwpF X-Received: by 2002:a17:906:9252:: with SMTP id c18mr4774209ejx.489.1606433738776; Thu, 26 Nov 2020 15:35:38 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1606433738; cv=none; d=google.com; s=arc-20160816; b=Au4T7qEJyUIjH5G2ShgjBvCGJK9rWoV/SXetZy9Hw6/NMHoUmdGnvOE1ugo3VWxxkD g600f0zKJxzFM00cDOMtZbPp6AqgqCF6AQs5YE4v+3krtyhkERkYNtLqtcBaNYEvEbHB gtMEKpvuIMx55rUET5W/nM4wJVyIONOE0pVHNNAEO3q8tcFImsWQAsP2O4uBkrGgTy9z ZaSPLvtkReuh8aUjTAiAgRQlTNWZZ74PG9ClnpFPYY4KvPEQ9tAolWWZlus0Vz/e2C5A dmh1BYbSvXHfkQBFTGhx9tIz8WXV1336rz9jXXcxkMdZEjx67A53gCC342U5QhAaj3v7 3Gzg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject; bh=cRsJXFfQwoT7y0T+5D+0DFHvxTrx0dNc9QiuLC0Z3Ns=; b=DJKGI6TnfUOgS7QD8BZ367GQi6EEsQqHn6uAObElccCCStzvJiO7aYFQXaYWrvuxhy NQl1Lm78JRaR5V089d7kwEVtTobJ7yKgWIURzanQxetbN7cz8C1rs7abGxlsfj3Tu9cq newlkHPgE6i5ztvHML/W4xxwiD8GHAScN2c+YqASMJ8KEEOBDyA1f4caWjZJH1g/Cr2j MBUup8sAfI5d22Sg9WWm6ibn7Ygt+dZuj0RRSiy6nQ/sXx/6Mg7LdbrIl7MK38YpGI+c kJ+62bJoi67msQaHhAF8qrZCwtVuhLpWVXLbmlfaY1oaUImDAeoN6kKKXYdfXA1TAdEq 8n7Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id um9si3916561ejb.521.2020.11.26.15.35.16; Thu, 26 Nov 2020 15:35:38 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388229AbgKZG6F (ORCPT + 99 others); Thu, 26 Nov 2020 01:58:05 -0500 Received: from www262.sakura.ne.jp ([202.181.97.72]:59781 "EHLO www262.sakura.ne.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388217AbgKZG6F (ORCPT ); Thu, 26 Nov 2020 01:58:05 -0500 Received: from fsav106.sakura.ne.jp (fsav106.sakura.ne.jp [27.133.134.233]) by www262.sakura.ne.jp (8.15.2/8.15.2) with ESMTP id 0AQ6vn4d083776; Thu, 26 Nov 2020 15:57:49 +0900 (JST) (envelope-from penguin-kernel@i-love.sakura.ne.jp) Received: from www262.sakura.ne.jp (202.181.97.72) by fsav106.sakura.ne.jp (F-Secure/fsigk_smtp/550/fsav106.sakura.ne.jp); Thu, 26 Nov 2020 15:57:49 +0900 (JST) X-Virus-Status: clean(F-Secure/fsigk_smtp/550/fsav106.sakura.ne.jp) Received: from [192.168.1.9] (M106072142033.v4.enabler.ne.jp [106.72.142.33]) (authenticated bits=0) by www262.sakura.ne.jp (8.15.2/8.15.2) with ESMTPSA id 0AQ6vnYB083773 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NO); Thu, 26 Nov 2020 15:57:49 +0900 (JST) (envelope-from penguin-kernel@i-love.sakura.ne.jp) Subject: Re: [PATCH] tomoyo: Avoid potential null pointer access To: Zheng Zengkai Cc: linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org, jmorris@namei.org, serge@hallyn.com, weiyongjun1@huawei.com References: <20201125121043.107662-1-zhengzengkai@huawei.com> <01d29bbf-9d77-c787-b2c2-d88a6a5047f7@huawei.com> From: Tetsuo Handa Message-ID: <59e0abdd-88a9-6269-9cd1-0f65792784ec@i-love.sakura.ne.jp> Date: Thu, 26 Nov 2020 15:57:46 +0900 User-Agent: Mozilla/5.0 (Windows NT 6.3; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.5.0 MIME-Version: 1.0 In-Reply-To: <01d29bbf-9d77-c787-b2c2-d88a6a5047f7@huawei.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2020/11/26 15:33, Zheng Zengkai wrote: > As your say,  I found the function tomoyo_assign_namespace( ) > > in security/tomoyo/domain.c has the similar situation, > > Can I add __GFP_NOWARN for both and remove the null check for _entry_ in tomoyo_assign_namespace( )? > Good catch. Yes, please send as a patch.