Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp1080376pxu; Thu, 26 Nov 2020 22:12:09 -0800 (PST) X-Google-Smtp-Source: ABdhPJyAZAZSG586bCbl0ZVeK4qHuEFQvkMV5VYag/pZDMklFd6ZSmTo7H7EyMzicUI2uq9RQ7Na X-Received: by 2002:aa7:dc48:: with SMTP id g8mr5866490edu.181.1606457529183; Thu, 26 Nov 2020 22:12:09 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1606457529; cv=none; d=google.com; s=arc-20160816; b=AxjeM4e2ff71PaxiLP3SOUGsJiIzGyR4Fb4KRIHGck7rsOObXjARH3torlPtoTJWeB ZmGHpTa+XayTyOHtbB9BriCYzBJ83bQgWijAXHRZJqedr5SrkXty5Nh+36IosBgj+8yB 5Dt0dTmW4RemT0lyChGhEPg8fJQYZv8yKoS7llnC3eoiQDZVlKS50l9IQIkzh1NuoLoj rYc/p5NTX+ePEhoBchGSVOOu87/YBLwtCfQC7SXtKF1UFzDRVC/7dkxSsnHgfHHc2Und 6OK+VaaZPy3K3B0lEcCD7h7boPl4JjJ1PbU9ZKx8pOnhwkYuF+IGZYf+y8Sbo10Im+JS Qi6g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=2hbfdccyBBUc90VyfkGgaRPT3jwOgID3Mqq37Sl62ao=; b=IeC16GVarRzm9OMX/fvIPlmv+u9xhV4JhW/LlxFkZKOS8+lNjw7gO8+ZkIoV4f+oyo yosoyrcG/wgVnXcbJzQ/C0HO5ukenuUENazlJoMW0nfLIcpiVKOVcWcOntsYJ+HH4pRf izpIkq22Mr6EVfen88ZMhOgJHGfGO2a6EgzNhGxgW0+eWfm0pdvwTBfQpD8YNYDIU/5i CeoE2vBLbOpXts/62c0IHk6QufOKwWtg9AsWU3O8xMyO3+hIDNeBeSw4FSXVhlvzMTN5 dLbtT4a0yHC65XfdI+qujyG5nfd2c7WNDAzxg/1Y6INquXWRkBZeDKANboCpDD3tS7ne hbzQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id p1si4283825ejx.531.2020.11.26.22.11.47; Thu, 26 Nov 2020 22:12:09 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1733281AbgKZJuH (ORCPT + 99 others); Thu, 26 Nov 2020 04:50:07 -0500 Received: from verein.lst.de ([213.95.11.211]:33696 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732410AbgKZJuH (ORCPT ); Thu, 26 Nov 2020 04:50:07 -0500 Received: by verein.lst.de (Postfix, from userid 2407) id CD50E68B02; Thu, 26 Nov 2020 10:50:04 +0100 (CET) Date: Thu, 26 Nov 2020 10:50:04 +0100 From: Christoph Hellwig To: Yicong Yang Cc: Christoph Hellwig , viro@zeniv.linux.org.uk, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, prime.zeng@huawei.com, linuxarm@huawei.com Subject: Re: [PATCH] fs: export vfs_stat() and vfs_fstatat() Message-ID: <20201126095004.GA23930@lst.de> References: <1606374948-38713-1-git-send-email-yangyicong@hisilicon.com> <20201126071848.GA17990@lst.de> <696f0e06-4f4d-0a61-6e13-f5af433594bf@hisilicon.com> <20201126091537.GA21957@lst.de> <79b19660-f418-f5ac-943c-bc49a88eb949@hisilicon.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <79b19660-f418-f5ac-943c-bc49a88eb949@hisilicon.com> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 26, 2020 at 05:48:25PM +0800, Yicong Yang wrote: > Sorry for not describing the issues I met correctly in the commit message. > Actually we're using inline function vfs_stat() for getting the > attributes, which calls vfs_fstatat(): Again, there generally isn't much need to look at the stat data for an in-kernel caller. But without you submitting the code I can't really help you anyway.