Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 26 Nov 2020 12:30:07 +0100
From:   Thierry Reding <thierry.reding@gmail.com>
To:     Vidya Sagar <vidyas@nvidia.com>
Cc:     lorenzo.pieralisi@arm.com, robh@kernel.org, bhelgaas@google.com,
        jonathanh@nvidia.com, jingoohan1@gmail.com, kw@linux.com,
        gregkh@linuxfoundation.org, linux-pci@vger.kernel.org,
        linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org,
        kthota@nvidia.com, mmaddireddy@nvidia.com, sagar.tv@gmail.com
Subject: Re: [PATCH] PCI: tegra: Move "dbi" accesses to post common DWC
 initialization
Message-ID: <X7+Rv8iK84k/lWlc@ulmo>
References: <20201125192234.2270-1-vidyas@nvidia.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="uRpyf/ZCw+A6MDI4"
Content-Disposition: inline
In-Reply-To: <20201125192234.2270-1-vidyas@nvidia.com>
User-Agent: Mutt/2.0.2 (d9268908) (2020-11-20)
Precedence: bulk


--uRpyf/ZCw+A6MDI4
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Nov 26, 2020 at 12:52:34AM +0530, Vidya Sagar wrote:
> commit a0fd361db8e5 ("PCI: dwc: Move "dbi", "dbi2", and "addr_space"
> resource setup into common code") moved the code that sets up dbi_base
> to DWC common code thereby creating a requirement to not access the "dbi"
> region before calling common DWC initialization code. But, Tegra194
> already had some code that programs some of the "dbi" registers resulting
> in system crash. This patch addresses that issue by refactoring the code
> to have accesses to the "dbi" region only after common DWC initialization.
>=20
> Fixes: a0fd361db8e5 ("PCI: dwc: Move "dbi", "dbi2", and "addr_space" reso=
urce setup into common code")
> Signed-off-by: Vidya Sagar <vidyas@nvidia.com>
> ---
>  drivers/pci/controller/dwc/pcie-tegra194.c | 19 ++++++++++---------
>  1 file changed, 10 insertions(+), 9 deletions(-)

This, together with your other patch fixes Tegra194 PCI on top of
next-20201126 for me, so:

Tested-by: Thierry Reding <treding@nvidia.com>
Acked-by: Thierry Reding <treding@nvidia.com>

--uRpyf/ZCw+A6MDI4
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAl+/kbsACgkQ3SOs138+
s6Fk1w/+Mq+/FnR7JB8L8JAdeYVHpnSPDhRK2/CIhYAjkL8BC5MOu6+d/0f3yeE/
UV4jBmvKO+bGV386mBWMtCYxEDPgMh5D6Fem3EVs2y5siekXvDSiIsH0vbcPAbNM
B4XU0eTzINlrQN+la5MWHCVbb/RapCbdL8F1ygKbMxVXNKfnzEP03QQpYNhvRjTX
ys5TJY0ds3ILTL3mQ2aCy8Rk8c+wYafNk5yqgxDTvMTkYVfGeSuUECyM23rFe3Le
6TpOPQ/ZpaSa7jjxzkkGLAkVnJB2MPv4FyguMrrRy9pUGQfqxvyrpRlQ8l9y5dyK
O6hGQclhyAM5biNuCntcGZpr2mLvCp43lYiZs0QVNPsiiZeC1Xgt9TtkiEyb64Ko
azW8gwo4O8zGTGOq6YKeQXpUOrcOSqysaldxQKB4cyLtrL5K5digBTdzLL9LdOXd
ZbuyeTQeGElYMjKGCniriofPmI1TLYiTMPLm83kk6SAFKrAa1a4aVyp/6VyRENou
U/fC2ko6cWQo/r6Hvr/is6d8QB89f4ekj4e2YEnpX4//t6GqixM7Qmxe31u3kR0F
PQjaeUpmk1r3qdYH9O3fYSjwhZMj+sy+zNzOy8NHZD0EHUdCpqXHfB6bVUxC98jq
IsctYY9Ij52LNQW8d9EW8+XFrhgluiWuUepM545GsYLSZKce07Y=
=qg65
-----END PGP SIGNATURE-----

--uRpyf/ZCw+A6MDI4--