Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 26 Nov 2020 14:51:37 -0300
From:   Arnaldo Carvalho de Melo <acme@kernel.org>
To:     Jiri Olsa <jolsa@kernel.org>
Cc:     Ian Rogers <irogers@google.com>,
        lkml <linux-kernel@vger.kernel.org>,
        Peter Zijlstra <a.p.zijlstra@chello.nl>,
        Ingo Molnar <mingo@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>,
        Namhyung Kim <namhyung@kernel.org>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Michael Petlan <mpetlan@redhat.com>,
        Song Liu <songliubraving@fb.com>,
        Stephane Eranian <eranian@google.com>,
        Alexey Budankov <alexey.budankov@linux.intel.com>,
        Andi Kleen <ak@linux.intel.com>,
        Adrian Hunter <adrian.hunter@intel.com>
Subject: Re: [PATCH 20/25] perf tools: Add is_perf_data function
Message-ID: <20201126175137.GE70905@kernel.org>
References: <20201126170026.2619053-1-jolsa@kernel.org>
 <20201126170026.2619053-21-jolsa@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20201126170026.2619053-21-jolsa@kernel.org>
Precedence: bulk

Em Thu, Nov 26, 2020 at 06:00:21PM +0100, Jiri Olsa escreveu:
> Adding is_perf_data function that returns true if
> the given path is perf data file. It will be used
> in following patches.

Thanks, applied.

- Arnaldo

 
> Acked-by: Ian Rogers <irogers@google.com>
> Signed-off-by: Jiri Olsa <jolsa@kernel.org>
> ---
>  tools/perf/util/data.c | 19 +++++++++++++++++++
>  tools/perf/util/data.h |  1 +
>  2 files changed, 20 insertions(+)
> 
> diff --git a/tools/perf/util/data.c b/tools/perf/util/data.c
> index 05bbcb663c41..f29af4fc3d09 100644
> --- a/tools/perf/util/data.c
> +++ b/tools/perf/util/data.c
> @@ -492,3 +492,22 @@ char *perf_data__kallsyms_name(struct perf_data *data)
>  
>  	return kallsyms_name;
>  }
> +
> +bool is_perf_data(const char *path)
> +{
> +	bool ret = false;
> +	FILE *file;
> +	u64 magic;
> +
> +	file = fopen(path, "r");
> +	if (!file)
> +		return false;
> +
> +	if (fread(&magic, 1, 8, file) < 8)
> +		goto out;
> +
> +	ret = is_perf_magic(magic);
> +out:
> +	fclose(file);
> +	return ret;
> +}
> diff --git a/tools/perf/util/data.h b/tools/perf/util/data.h
> index c563fcbb0288..62a3e66fbee8 100644
> --- a/tools/perf/util/data.h
> +++ b/tools/perf/util/data.h
> @@ -98,4 +98,5 @@ int perf_data__update_dir(struct perf_data *data);
>  unsigned long perf_data__size(struct perf_data *data);
>  int perf_data__make_kcore_dir(struct perf_data *data, char *buf, size_t buf_sz);
>  char *perf_data__kallsyms_name(struct perf_data *data);
> +bool is_perf_data(const char *path);
>  #endif /* __PERF_DATA_H */
> -- 
> 2.26.2
> 

-- 

- Arnaldo