Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20201120162133.472938-1-krzk@kernel.org> <20201127080619.GJ2455276@dell>
In-Reply-To: <20201127080619.GJ2455276@dell>
From:   Krzysztof Kozlowski <krzk@kernel.org>
Date:   Fri, 27 Nov 2020 09:17:33 +0100
Message-ID: <CAJKOXPfdEbax7Z4xpu2QcLSND6fvWK__5hTKOESaO0n2pBMhtA@mail.gmail.com>
Subject: Re: [PATCH 01/16] mfd: bcm590xx: drop of_match_ptr from of_device_id table
To:     Lee Jones <lee.jones@linaro.org>
Cc:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Fri, 27 Nov 2020 at 09:06, Lee Jones <lee.jones@linaro.org> wrote:
>
> On Fri, 20 Nov 2020, Krzysztof Kozlowski wrote:
>
> > The driver can match only via the DT table so the table should be alway=
s
> > used and the of_match_ptr does not have any sense (this also allows ACP=
I
> > matching via PRP0001, even though it is not relevant here).  This fixes
> > compile warning (!CONFIG_OF on x86_64):
> >
> >   drivers/mfd/bcm590xx.c:95:34: warning: =E2=80=98bcm590xx_of_match=E2=
=80=99 defined but not used [-Wunused-const-variable=3D]
> >
> > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> > ---
> >  drivers/mfd/bcm590xx.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
>
> Couple of small points:
>
> - Patch-sets, particularly large ones should have a cover letter.
> - Subject lines follow English grammar conventions and should start
>   with an uppercase character.

Thanks for fixing this. I am not a native English speaker and I make
mistakes. Either it is a grammar or convention mistake, I would
appreciate it if you point them out, so I could learn from them.
About the "start with an uppercase character", I actually on purpose
changed my approach some time ago after seeing more senior kernel
developers using this method (see commits from Linus Torvalds, Andrew
Morton). After the subsystem prefix "mfd: ...." they start with
lowercase. If you still insist that commit titles in MFD subsystem
should use capital letter after the prefix, I will try to remember and
follow this approach when sending patches to you.

Best regards,
Krzysztof