Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
User-Agent: Cyrus-JMAP/3.3.0-622-g4a97c0b-fm-20201115.001-g4a97c0b3
Mime-Version: 1.0
Message-Id: <ea40c3e8-0be1-4783-ba1e-86c96cf8e4af@www.fastmail.com>
In-Reply-To: <875z5rk68z.fsf@nanos.tec.linutronix.de>
References: <20201126074734.12664-1-lnicola@dend.ro>
 <875z5rk68z.fsf@nanos.tec.linutronix.de>
Date:   Fri, 27 Nov 2020 10:03:50 +0200
From:   =?UTF-8?Q?Lauren=C8=9Biu_Nicola?= <lnicola@dend.ro>
To:     "Thomas Gleixner" <tglx@linutronix.de>
Cc:     mingo@redhat.com, bp@alien8.de, x86@kernel.org, trivial@kernel.org,
        LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] x86/irq: Lower unhandled irq error severity
Content-Type: text/plain;charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hello,

On Fri, Nov 27, 2020, at 02:12, Thomas Gleixner wrote:
> On Thu, Nov 26 2020 at 09:47, Lauren=C8=9Biu Nicola wrote:
> > These messages are described as warnings in the MSI code.
>=20
> Where and what has MSI to do with these messages?

There's a comment referring to it as a warning, but an error seemed a mo=
re appropriate severity:

     * If the vector is unused, then it is marked so it won't
     * trigger the 'No irq handler for vector' warning in
     * common_interrupt().

> > Spotted because they break quiet boot on a Ryzen 5000 CPU.
>=20
> They don't break the boot.
>=20
> The machine boots fine, but having interrupts raised on a vector which=

> is unused is really bad.

That's right, sorry. It still boots, but it's no longer "quiet", that's =
what I meant.

> Can you please provide the actual message from dmesg?

Sure:

[    0.316902] __common_interrupt: 1.55 No irq handler for vector
[    0.316902] __common_interrupt: 2.55 No irq handler for vector
[    0.316902] __common_interrupt: 3.55 No irq handler for vector
[    0.316902] __common_interrupt: 4.55 No irq handler for vector
[    0.316902] __common_interrupt: 5.55 No irq handler for vector
[    0.316902] __common_interrupt: 6.55 No irq handler for vector
[    0.316902] __common_interrupt: 7.55 No irq handler for vector
[    0.316902] __common_interrupt: 8.55 No irq handler for vector
[    0.316902] __common_interrupt: 9.55 No irq handler for vector
[    0.316902] __common_interrupt: 10.55 No irq handler for vector

These only show up during boot (and not e.g. when a disabling and enabli=
ng again a CPU).

Lauren=C8=9Biu