Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] tomoyo: Avoid potential null pointer access
To:     Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>
CC:     <linux-security-module@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <jmorris@namei.org>,
        <serge@hallyn.com>, <weiyongjun1@huawei.com>
References: <20201125121043.107662-1-zhengzengkai@huawei.com>
 <cfc96d99-adff-6eb9-9685-422587830eb8@i-love.sakura.ne.jp>
 <01d29bbf-9d77-c787-b2c2-d88a6a5047f7@huawei.com>
 <59e0abdd-88a9-6269-9cd1-0f65792784ec@i-love.sakura.ne.jp>
From:   Zheng Zengkai <zhengzengkai@huawei.com>
Message-ID: <dfb6829e-0fb6-7dbc-5dfa-9707b2f0ae16@huawei.com>
Date:   Fri, 27 Nov 2020 15:17:12 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101
 Thunderbird/60.8.0
MIME-Version: 1.0
In-Reply-To: <59e0abdd-88a9-6269-9cd1-0f65792784ec@i-love.sakura.ne.jp>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

Hello Tetsuo,
> On 2020/11/26 15:33, Zheng Zengkai wrote:
>> As your say,  I found the function tomoyo_assign_namespace( )
>>
>> in security/tomoyo/domain.c has the similar situation,
>>
>> Can I add __GFP_NOWARN for both and remove the null check for _entry_ in tomoyo_assign_namespace( )?
>>
> Good catch. Yes, please send as a patch.
> .

I have resent a patch, thanks!