Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp1162548pxu; Fri, 27 Nov 2020 00:54:26 -0800 (PST) X-Google-Smtp-Source: ABdhPJxSt671XI1b4roXT4li7Z4dQpHAUY0fmR6ki1U6oBa+6PIeBqMxxMoZsF+uOq0zYmVWj470 X-Received: by 2002:a05:6402:19b4:: with SMTP id o20mr6515464edz.103.1606467265851; Fri, 27 Nov 2020 00:54:25 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1606467265; cv=none; d=google.com; s=arc-20160816; b=pf+J4EIV7039QLQKRXs8e2BLslPOFoHXSBzDC72hYqlEhQbwqxKOT5n3kPLB0m953l 7mjtZZEkIpw6937Ywyh93AQCzihTfaxtEHEZKxh4OZkH6/rKem/XuZKheXjq7LWI28p9 nYNvGHxftWqsfPqWpLTOR+k6McheyLIqhrNY/lDP+MZB/OvbiCSzfeKCPOON0hJQubty T7uFeWdbAutuCpPt/fAQpBRCSY7sDM1BOMaqU+edC1ZfOGuRbocweh6rwkyi7sbocOZM VHLV96b3t9ih9/ixMy8/t/WDp19Jt5qvZkRhANYs5M4yttpPGpei0dgJqIvT9oZTeLMR WpHA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to :mime-version:user-agent:date:message-id:from:references:cc:to :subject; bh=48q9MygfhOzxnX/Ng5c34rvs4okb0KqY3QbJ0GGQy7k=; b=LKuICm+Q7m+7kSVTKw/XpqbEgKG5wwKbDajXffq23Zt24xBWmxu7m5sE/mVhJfMHyP XjySK2GmIFbVHm/5kkXAVQDRcZ0/AngPNNooAdLlMQwxONeVWd2oZ3sANuTxQUirepmB h9TPplWBNT2I5qFXK56rRDGsbQuwfZjfc6FteIobgBhmfo4ikwVhl+OFyAssvLg62ApW HvlSJqdOWRBkPxBnFVKWPP/HqbETRVz4uOx+uaGiOCuK24E45dTeZ1yqyjUpnXy18Yon aCeyuJh8lTF7WXPb7wPdvoDwT6uJqHrD5BwLKl2oJhNueTA//t6t8MSbSfU151ocna/q 9YMg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id j15si679983ejt.513.2020.11.27.00.54.03; Fri, 27 Nov 2020 00:54:25 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2405333AbgK0HbQ (ORCPT + 99 others); Fri, 27 Nov 2020 02:31:16 -0500 Received: from szxga07-in.huawei.com ([45.249.212.35]:8417 "EHLO szxga07-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726408AbgK0HbQ (ORCPT ); Fri, 27 Nov 2020 02:31:16 -0500 Received: from DGGEMS412-HUB.china.huawei.com (unknown [172.30.72.59]) by szxga07-in.huawei.com (SkyGuard) with ESMTP id 4Cj5rq6ZfCz6wBk; Fri, 27 Nov 2020 15:30:51 +0800 (CST) Received: from [10.174.178.154] (10.174.178.154) by smtp.huawei.com (10.3.19.212) with Microsoft SMTP Server (TLS) id 14.3.487.0; Fri, 27 Nov 2020 15:31:11 +0800 Subject: Re: [PATCH] usb: dwc3: meson-g12a: disable clk on error handling path in probe To: Martin Blumenstingl CC: , , , Neil Armstrong , , , , References: <20201111095256.10477-1-zhengzengkai@huawei.com> From: Zheng Zengkai Message-ID: <7ea6de9c-f482-2f8e-1d54-b8c127d10f22@huawei.com> Date: Fri, 27 Nov 2020 15:31:11 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.178.154] X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Ping... > On Wed, Nov 11, 2020 at 10:48 AM Zheng Zengkai wrote: >> dwc3_meson_g12a_probe() does not invoke clk_bulk_disable_unprepare() >> on one error handling path. This patch fixes that. >> >> Fixes: 347052e3bf1b ("usb: dwc3: meson-g12a: fix USB2 PHY initialization on G12A and A1 SoCs") >> Reported-by: Hulk Robot >> Signed-off-by: Zheng Zengkai > Reviewed-by: Martin Blumenstingl > > many thanks for this fix! > > > Best regards > Martin > . >