Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <540fd8fd4542c9737224a43fa4123ceb679a7b59.camel@chromium.org>
Subject: Re: [PATCH bpf-next 2/2] bpf: Add a selftest for the tracing
 bpf_get_socket_cookie
From:   Florent Revest <revest@chromium.org>
To:     Yonghong Song <yhs@fb.com>, bpf@vger.kernel.org
Cc:     ast@kernel.org, daniel@iogearbox.net, andrii@kernel.org,
        kpsingh@chromium.org, revest@google.com,
        linux-kernel@vger.kernel.org
Date:   Fri, 27 Nov 2020 10:17:31 +0100
In-Reply-To: <8b0529f0-5f1e-b403-2772-7a56c44a3a55@fb.com>
References: <20201126170212.1749137-1-revest@google.com>
         <20201126170212.1749137-2-revest@google.com>
         <8b0529f0-5f1e-b403-2772-7a56c44a3a55@fb.com>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.36.4-2 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Thu, 2020-11-26 at 23:56 -0800, Yonghong Song wrote:
> 
> On 11/26/20 9:02 AM, Florent Revest wrote:
> > This builds up on the existing socket cookie test which checks
> > whether
> > the bpf_get_socket_cookie helpers provide the same value in
> > cgroup/connect6 and sockops programs for a socket created by the
> > userspace part of the test.
> > 
> > Adding a tracing program to the existing objects requires a
> > different
> > attachment strategy and different headers.
> > 
> > Signed-off-by: Florent Revest <revest@google.com>
> > ---
> >   .../selftests/bpf/progs/socket_cookie_prog.c  | 41
> > ++++++++++++++++---
> >   .../selftests/bpf/test_socket_cookie.c        | 18 +++++---
> 
> Do you think it is possible to migrate test_socket_cookie.c to
> selftests/bpf/prog_tests so it can be part of test_progs so
> it will be regularly exercised?

I suppose it's possible, I can give it a try :)