Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp1178967pxu; Fri, 27 Nov 2020 01:23:02 -0800 (PST) X-Google-Smtp-Source: ABdhPJy7t/vR/luiXHRdryE5DOaPRm/kq0k9UqQW/zeXSaoMuUhk1UHqQ4juIOdiRmVEi2RLoGhZ X-Received: by 2002:a17:906:ece7:: with SMTP id qt7mr6950616ejb.316.1606468982525; Fri, 27 Nov 2020 01:23:02 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1606468982; cv=none; d=google.com; s=arc-20160816; b=wlMr5Ia/blbbiQd9HnDDqa5bwm78maQlTVvWipOYhQ5tMnuZuIXObDosDpoidH9coa HaKR/u31yc7h7QwFPe2NfSYdi65ET9tBVls/vwUf7c+9M7XD8DK6OGlMmnCkkcux9lKE t6H1icUdbKtpKm/NhJh/WTDvUz6nGSFhW/xIAhQhWjO0hMcs64qrCMSufy36yD8Iyaap lVObJeL2esv2jQlub3TS/+yHVkbebq9c/OECZAPQmJ03mR1+1fKcGA1SSnrUpHP2j+z2 TyVF5qHkYf0YS5RZDF/4ccosLWilCx4B3q49eDd+S+ZPRxuX30Ep495qMr15fc7lgKdX scRQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:subject:cc:to:from; bh=+zms6C8x3xM2B7EKzWQ4EEKy+aHllS/3JzgB/lOmo48=; b=t+NrMWtH4DTa6FZH1rFVprjY96zQm+bkam4H0tyecga7uIF5/Ts3numb3kZv6802L+ UwgNktxI4ekPvdqHdeUfkS+fiBrtaBx8NWDmPWxHhSpQgUUKkFDMzkchLl+X61joYELy T2j28nuyYvPE8mm1mjYuU+pWtsO4+IEjmAlrEM8eLhBqNF124zTx261DUKUkQuDqtSDa w7TzF8oLxqZ1Pospg0uyhxkZAo5lcbUWq1S8O9TdvM8QmrgtHOQv8BboO9OaMzHXMYmC BuWCM8DVjAtigN8iLAuD+Y3sk15yVJHPM8oQNzB1WDeoFrRb2Z6SDz8jI50ZzSW3C13F Zgbg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id e17si3328666ejc.373.2020.11.27.01.22.40; Fri, 27 Nov 2020 01:23:02 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727933AbgK0JSz (ORCPT + 99 others); Fri, 27 Nov 2020 04:18:55 -0500 Received: from smtp25.cstnet.cn ([159.226.251.25]:43534 "EHLO cstnet.cn" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727333AbgK0JSz (ORCPT ); Fri, 27 Nov 2020 04:18:55 -0500 Received: from localhost.localdomain (unknown [124.16.141.242]) by APP-05 (Coremail) with SMTP id zQCowADXcghnxMBfjngQAA--.27352S2; Fri, 27 Nov 2020 17:18:31 +0800 (CST) From: Xu Wang To: a.hajda@samsung.com, narmstrong@baylibre.com, Laurent.pinchart@ideasonboard.com, jonas@kwiboo.se, jernej.skrabec@siol.net, airlied@linux.ie, daniel@ffwll.ch, sam@ravnborg.org, bogdan.togorean@analog.com, laurentiu.palcu@nxp.com Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH] drm: bridge: adv7511: Remove redundant null check before clk_disable_unprepare Date: Fri, 27 Nov 2020 09:18:29 +0000 Message-Id: <20201127091829.50695-1-vulab@iscas.ac.cn> X-Mailer: git-send-email 2.17.1 X-CM-TRANSID: zQCowADXcghnxMBfjngQAA--.27352S2 X-Coremail-Antispam: 1UD129KBjvJXoW7ur4ruw15WFy7GFykCw4fAFb_yoW8GF4xpw 47uFZIkry8XrZFga1DAF45ta4Y9a1Uta4rZFZI9wnF9wsruFy0qFWDAw18ZFy7JFW8C347 tr1UKrykWF1ayaUanT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUUvlb7Iv0xC_tr1lb4IE77IF4wAFF20E14v26r4j6ryUM7CY07I2 0VC2zVCF04k26cxKx2IYs7xG6rWj6s0DM7CIcVAFz4kK6r1j6r18M28lY4IEw2IIxxk0rw A2F7IY1VAKz4vEj48ve4kI8wA2z4x0Y4vE2Ix0cI8IcVAFwI0_Xr0_Ar1l84ACjcxK6xII jxv20xvEc7CjxVAFwI0_Cr0_Gr1UM28EF7xvwVC2z280aVAFwI0_Cr1j6rxdM28EF7xvwV C2z280aVCY1x0267AKxVW0oVCq3wAS0I0E0xvYzxvE52x082IY62kv0487Mc02F40EFcxC 0VAKzVAqx4xG6I80ewAv7VC0I7IYx2IY67AKxVWUXVWUAwAv7VC2z280aVAFwI0_Gr0_Cr 1lOx8S6xCaFVCjc4AY6r1j6r4UM4x0Y48IcxkI7VAKI48JM4IIrI8v6xkF7I0E8cxan2IY 04v7MxkIecxEwVAFwVW8uwCF04k20xvY0x0EwIxGrwCFx2IqxVCFs4IE7xkEbVWUJVW8Jw C20s026c02F40E14v26r1j6r18MI8I3I0E7480Y4vE14v26r106r1rMI8E67AF67kF1VAF wI0_Jw0_GFylIxkGc2Ij64vIr41lIxAIcVC0I7IYx2IY67AKxVWUJVWUCwCI42IY6xIIjx v20xvEc7CjxVAFwI0_Gr0_Cr1lIxAIcVCF04k26cxKx2IYs7xG6rWUJVWrZr1UMIIF0xvE x4A2jsIE14v26r1j6r4UMIIF0xvEx4A2jsIEc7CjxVAFwI0_Gr0_Gr1UYxBIdaVFxhVjvj DU0xZFpf9x07jztCwUUUUU= X-Originating-IP: [124.16.141.242] X-CM-SenderInfo: pyxotu46lvutnvoduhdfq/1tbiBgkNA10Tey1--QAAsb Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Because clk_disable_unprepare() already checked NULL clock parameter, so the additional check is unnecessary, just remove them. Signed-off-by: Xu Wang --- drivers/gpu/drm/bridge/adv7511/adv7511_drv.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c index a0d392c338da..76555ae64e9c 100644 --- a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c +++ b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c @@ -1292,8 +1292,7 @@ static int adv7511_probe(struct i2c_client *i2c, const struct i2c_device_id *id) err_unregister_cec: i2c_unregister_device(adv7511->i2c_cec); - if (adv7511->cec_clk) - clk_disable_unprepare(adv7511->cec_clk); + clk_disable_unprepare(adv7511->cec_clk); err_i2c_unregister_packet: i2c_unregister_device(adv7511->i2c_packet); err_i2c_unregister_edid: @@ -1311,8 +1310,7 @@ static int adv7511_remove(struct i2c_client *i2c) if (adv7511->type == ADV7533 || adv7511->type == ADV7535) adv7533_detach_dsi(adv7511); i2c_unregister_device(adv7511->i2c_cec); - if (adv7511->cec_clk) - clk_disable_unprepare(adv7511->cec_clk); + clk_disable_unprepare(adv7511->cec_clk); adv7511_uninit_regulators(adv7511); -- 2.17.1