Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp1187265pxu; Fri, 27 Nov 2020 01:37:57 -0800 (PST) X-Google-Smtp-Source: ABdhPJwGOTQovDJ7p4fkz5JcOsf4NohIW5heRfVFJ2A4OEXXKHqTstpx/14c0maDYzaa3F6H9VFg X-Received: by 2002:a17:906:b847:: with SMTP id ga7mr6920481ejb.200.1606469877087; Fri, 27 Nov 2020 01:37:57 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1606469877; cv=none; d=google.com; s=arc-20160816; b=B8SrgplKxG/vwfU6f4Fp/KUdgA2AauTpOtai1FK+7gOed0100uWXj5HV6Cj4vGOZuw 3mvuUDRN6Ov75FhAbF+hmM1MHYs3lXtTj8gT2t63mQE1qhLteFuPM2JlvPbwyEd/HkYp NIbpJCeli+1UJDqnmvzeq35jrLgU/ZeK1LjZAomuxrd2fjfSc4wjXpvNI/SvDHOvNK8i vfXJLxP7Oo1Z9uTH4wqHL6myE2G4xtfSTh9wgI2lGMimWJZL6+Is5OoXkAp1sLzcpd0M XGwvnubAKjXhSNfSHH4+eUhDccC/F6fQJOc6tE1PxV2ouTgG0Vt+sutdHPxJdDRnFqyB mkWw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version; bh=VG9mvGWzcOlgITQm7N6zcafZvGmScFIc66IwQJRIyJM=; b=vU7P02NgWQWE/boR7cjHF019MzxyqNXkdnvfveDDuxqaj4wPIHXL0Yws2OGnvkD6O5 7n6UsmMjWN2VoflaTjeXDEz90SkwVkfSEdu7BVCDMBiK+eTilWb8LBD4CWHmyv/FMzlw F9xNGDYLtalXXrzh5LSWgG8sgrFqu4CwzXypkegTy8qCesnKqPpVR2jZGqi1+zBclI7y 3++oGzZV8zwRhdjxtKZHXx8E6seqdauutC8twupXzamU63CNPjmk17iP4dM27YxkYwFZ kpRLX9WLuIMrcmOXuZU3w1MSz4ngGkpBRNBkiHfS7j05UM+35o8+8Ze/3k6Vl52BLdCT uivA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id i5si4595526edx.188.2020.11.27.01.37.34; Fri, 27 Nov 2020 01:37:57 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728033AbgK0Jdb (ORCPT + 99 others); Fri, 27 Nov 2020 04:33:31 -0500 Received: from mail-ot1-f66.google.com ([209.85.210.66]:33983 "EHLO mail-ot1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726039AbgK0Jda (ORCPT ); Fri, 27 Nov 2020 04:33:30 -0500 Received: by mail-ot1-f66.google.com with SMTP id h19so4187926otr.1; Fri, 27 Nov 2020 01:33:29 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=VG9mvGWzcOlgITQm7N6zcafZvGmScFIc66IwQJRIyJM=; b=bP8meu9s/uNvdmFI7HyMB0IT8Xu6nXeUfKeUL6MjR++/E3/TBXfbDdE3yuFhoJ2JKm 5AXOdkpi0ZkPoIYE+zHlvYJByuIbH3GdsEm0YDXDoRpQhqMIV6e2yBBn8qWqdn3wUp9Q IllnxAr1GEIjaiwP+JEHatUUtgIfM9UEfAxOQNOaRqvnH00iumm/B7sunqjBV9857Gi9 zCK+2LeTpjBX7ipaq5s+qrs6VRu9VYZ3iYUfXmYT7/9Inhqz1leSEt2+f4y73FY3j48Z +7MQgsKHRTzfKYlJy6yJONgoaySyNVwLZ/40iojDcfzfndLxcHJRXnNXUnF9xT9S2psS pa6Q== X-Gm-Message-State: AOAM532RuRf4WoFSvs7+ReFXDxBpvfSAgJabIk3aDaoNytzWCQR0B0b9 diEV+jPMnUpCw4JsB/ohLYztKKqQNktdslkqoZ8= X-Received: by 2002:a05:6830:1f5a:: with SMTP id u26mr5385465oth.250.1606469608748; Fri, 27 Nov 2020 01:33:28 -0800 (PST) MIME-Version: 1.0 References: <20201126191146.8753-1-prabhakar.mahadev-lad.rj@bp.renesas.com> <20201126191146.8753-4-prabhakar.mahadev-lad.rj@bp.renesas.com> In-Reply-To: <20201126191146.8753-4-prabhakar.mahadev-lad.rj@bp.renesas.com> From: Geert Uytterhoeven Date: Fri, 27 Nov 2020 10:33:17 +0100 Message-ID: Subject: Re: [PATCH v2 3/5] memory: renesas-rpc-if: Fix a reference leak in rpcif_probe() To: Lad Prabhakar Cc: Sergei Shtylyov , Krzysztof Kozlowski , Philipp Zabel , Jiri Kosina , Mark Brown , Linux-Renesas , Pavel Machek , Geert Uytterhoeven , Linux Kernel Mailing List , Prabhakar , stable Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 26, 2020 at 8:12 PM Lad Prabhakar wrote: > Release the node reference by calling of_node_put(flash) in the probe. > > Fixes: ca7d8b980b67f ("memory: add Renesas RPC-IF driver") > Reported-by: Pavel Machek > Signed-off-by: Lad Prabhakar > Cc: stable@vger.kernel.org > Reviewed-by: Sergei Shtylyov Reviewed-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds