Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 26 Nov 2020 12:30:23 +0100
From:   Thierry Reding <thierry.reding@gmail.com>
To:     Vidya Sagar <vidyas@nvidia.com>
Cc:     lorenzo.pieralisi@arm.com, robh@kernel.org, bhelgaas@google.com,
        jonathanh@nvidia.com, jingoohan1@gmail.com, kw@linux.com,
        amanharitsh123@gmail.com, gregkh@linuxfoundation.org,
        linux-pci@vger.kernel.org, linux-tegra@vger.kernel.org,
        linux-kernel@vger.kernel.org, kthota@nvidia.com,
        mmaddireddy@nvidia.com, sagar.tv@gmail.com
Subject: Re: [PATCH] PCI: tegra: Read "dbi" base address to program in
 application logic
Message-ID: <X7+Rz4lvlj6P50NF@ulmo>
References: <20201125192554.5401-1-vidyas@nvidia.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="//RXht02A0QUFTjI"
Content-Disposition: inline
In-Reply-To: <20201125192554.5401-1-vidyas@nvidia.com>
User-Agent: Mutt/2.0.2 (d9268908) (2020-11-20)
Precedence: bulk


--//RXht02A0QUFTjI
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Nov 26, 2020 at 12:55:54AM +0530, Vidya Sagar wrote:
> PCIe controller in Tegra194 requires the "dbi" region base address to be
> programmed in one of the application logic registers to enable CPU access
> to the "dbi" region. But, commit a0fd361db8e5 ("PCI: dwc: Move "dbi",
> "dbi2", and "addr_space" resource setup into common code") moved the code
> that reads the whereabouts of "dbi" region to the common code causing the
> existing code in pcie-tegra194.c file to program NULL in the application
> logic registers. This is causing null pointer dereference when the "dbi"
> registers are accessed. This issue is fixed by explicitly reading the
> "dbi" base address from DT node.
>=20
> Fixes: a0fd361db8e5 ("PCI: dwc: Move "dbi", "dbi2", and "addr_space" reso=
urce setup into common code")
> Signed-off-by: Vidya Sagar <vidyas@nvidia.com>
> ---
>  drivers/pci/controller/dwc/pcie-tegra194.c | 7 +++++++
>  1 file changed, 7 insertions(+)

Tested-by: Thierry Reding <treding@nvidia.com>
Acked-by: Thierry Reding <treding@nvidia.com>

--//RXht02A0QUFTjI
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAl+/kc8ACgkQ3SOs138+
s6GZcBAAoY4Nqbq7gKfaQbDed8Xk1c8+IaOEkq5u7nZq+YZ+CXogL4atxCGkrNIs
XGk7XUNEzB8T7KiVLQmTW6K4ZhE6J4z8BRZB+H7SyOOp3Go+VRGobOjTbv4+lb9s
uAQQzd1XJ1Cw+KhAfgAR1sirTTAUDIrsTHakYimdybMwcfVH/5Nka/f0WSk0NvCv
wzWOAV4jk4s4fSRVLbJnc2u1PNGjsD6z7DlHwGVxl/zo6KTk0MjFE1tR2l7briqt
nuW0q0ACoHI6IvYb+bKkSgesE/WyVAbV2F/FULixHttvhiHCeLjasXD2XgSYHqkQ
rrBkJvZafbii5rhW7IJs2qk8QSxFkFJ6ESD7qzc6dQlJ741HOLtSU2FdWyRd3kwl
nRyfvA8b/ZhaLN5ivOQBjTTgwvf95Wsk1Bs/BGcvCJ4p1M6HnSbgwVXvF0IxrS6L
GqKMyKzh5y6zGVytc7mIuebCYuP92EVdHBkDeapJf7bR8u7o8lurHPrlFDWALuD8
ftjYqdTA4qEhXA+ITGy75T5Ba5Dz+OV0qWJf6l5sdlLx3Y/27Eec/m3YlJmqaHO0
pAt2RhA442E8haNsRrvFoIzyHy4ubFH6qIC3wWySw7H+S1VpsvFgVm/g7kVbi+B9
t/rDBF+DQQ3L8MWut7T7oTg6dg9GglXZoakNnxyAEoj3ZlG5Jd0=
=j3Wn
-----END PGP SIGNATURE-----

--//RXht02A0QUFTjI--