Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 27 Nov 2020 11:23:49 +0100
From:   Johan Hovold <johan@kernel.org>
To:     "Wang, Sheng Long" <shenglong.wang.ext@siemens.com>
Cc:     Johan Hovold <johan@kernel.org>,
        Sheng Long Wang <china_shenglong@163.com>,
        "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
        "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "lkp@intel.com" <lkp@intel.com>
Subject: Re: [PATCH v6] usb-serial:cp210x: add support to software flow
 control
Message-ID: <X8DTtVEzL4X8UJCH@localhost>
References: <20201016022428.9671-1-china_shenglong@163.com>
 <X66l44MqSlj774DL@localhost>
 <520e730958174cb39561a94d03e4727e@siemens.com>
 <X7Kq6fJ/VMnB3Nt0@localhost>
 <496f2cc77b4d4c3a9b49410ac318b927@siemens.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <496f2cc77b4d4c3a9b49410ac318b927@siemens.com>
Precedence: bulk

[ Again, please do not top-post. Quoting Greg:

  A: http://en.wikipedia.org/wiki/Top_post
  Q: Were do I find info about this thing called top-posting?
  A: Because it messes up the order in which people normally read text.
  Q: Why is top-posting such a bad thing?
  A: Top-posting.
  Q: What is the most annoying thing in e-mail?

  A: No.
  Q: Should I include quotations after my reply?

  http://daringfireball.net/2007/07/on_top
]

On Mon, Nov 23, 2020 at 01:11:24AM +0000, Wang, Sheng Long wrote:
> Hi,  Johan
> 
> Do I add my  software flow control  patch directly to the branch you
> gave me now ? 
> https://git.kernel.org/pub/scm/linux/kernel/git/johan/usb-serial.git/log/?h=cp210x-termios

Yes, please rebase your work on top of that branch. I'll merge it to my
usb-next branch before applying your patch.

> Then, I also need the cp210x_ get_ terminus()  add ixoff / iXon handling?

No, if you rebase your work on top of the above branch, you won't have
to deal with cp210x_get_termios() which has now been removed.

Just add support for software flow control to the new
cp210x_set_flow_control() function (and cp210x_termios_change()).

I think you can even drop get_special_chars() and just leave the rest
set as NUL, which appears to be the default.

Johan