Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Peter Chen <peter.chen@nxp.com>
To:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>
CC:     "balbi@kernel.org" <balbi@kernel.org>,
        "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Will McVicker <willmcvicker@google.com>,
        stable <stable@vger.kernel.org>
Subject: Re: [PATCH 4/4] USB: gadget: f_midi: setup SuperSpeed Plus
 descriptors
Thread-Topic: [PATCH 4/4] USB: gadget: f_midi: setup SuperSpeed Plus
 descriptors
Thread-Index: AQHWxB9kjqaqi8p2XkafJ7Illnrgjanb4zGA
Date:   Fri, 27 Nov 2020 12:06:50 +0000
Message-ID: <20201127120621.GD22238@b29397-desktop>
References: <20201126180937.255892-1-gregkh@linuxfoundation.org>
 <20201126180937.255892-4-gregkh@linuxfoundation.org>
In-Reply-To: <20201126180937.255892-4-gregkh@linuxfoundation.org>
Accept-Language: en-US
Content-Language: en-US
user-agent: Mutt/1.9.4 (2018-02-28)
Content-Type: text/plain; charset="us-ascii"
Content-ID: <433BF40DE4B49F4881522FE4D01E8F02@eurprd04.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 5430de21-dc72-4acc-d0f1-08d892ccec5a
X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Nov 2020 12:06:50.8576
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: U8btwrphde97GHepeUJPBhIoBA+jLdV/z4yqIUa/eLXU+UfOmUWIUnKIK/cGCtVMiXAQcoUTrshdZHTyh8FxFw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR04MB7179
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 20-11-26 19:09:37, Greg Kroah-Hartman wrote:
> From: Will McVicker <willmcvicker@google.com>
>=20
> Needed for SuperSpeed Plus support for f_midi.  This allows the
> gadget to work properly without crashing at SuperSpeed rates.
>=20
> Cc: Felipe Balbi <balbi@kernel.org>
> Cc: stable <stable@vger.kernel.org>
> Signed-off-by: Will McVicker <willmcvicker@google.com>
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> ---
>  drivers/usb/gadget/function/f_midi.c | 5 +++++
>  1 file changed, 5 insertions(+)
>=20
> diff --git a/drivers/usb/gadget/function/f_midi.c b/drivers/usb/gadget/fu=
nction/f_midi.c
> index 85cb15734aa8..ceb67651de4f 100644
> --- a/drivers/usb/gadget/function/f_midi.c
> +++ b/drivers/usb/gadget/function/f_midi.c
> @@ -1048,6 +1048,11 @@ static int f_midi_bind(struct usb_configuration *c=
, struct usb_function *f)
>  		f->ss_descriptors =3D usb_copy_descriptors(midi_function);
>  		if (!f->ss_descriptors)
>  			goto fail_f_midi;

Add one blank line, otherwise:

Reviewed-by: Peter Chen <peter.chen@nxp.com>

Peter
> +		if (gadget_is_superspeed_plus(c->cdev->gadget)) {
> +			f->ssp_descriptors =3D usb_copy_descriptors(midi_function);
> +			if (!f->ssp_descriptors)
> +				goto fail_f_midi;
> +		}
>  	}
> =20
>  	kfree(midi_function);
> --=20
> 2.29.2
>=20

--=20

Thanks,
Peter Chen=