Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] media: vb2: always set buffer cache sync hints
To:     Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
Cc:     Tomasz Figa <tfiga@chromium.org>,
        Marek Szyprowski <m.szyprowski@samsung.com>,
        Mauro Carvalho Chehab <mchehab@kernel.org>,
        linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
        Sergey Senozhatsky <senozhatsky@chromium.org>
References: <20201127094136.1051071-1-sergey.senozhatsky@gmail.com>
 <0dbfa509-8c82-7470-c18b-24ab5c92dc4b@xs4all.nl>
 <X8ENifLanjYuhF/r@jagdpanzerIV.localdomain>
From:   Hans Verkuil <hverkuil@xs4all.nl>
Message-ID: <509cc69b-39d7-4b13-f392-ebf25530c8fe@xs4all.nl>
Date:   Fri, 27 Nov 2020 15:56:47 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.12.0
MIME-Version: 1.0
In-Reply-To: <X8ENifLanjYuhF/r@jagdpanzerIV.localdomain>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 27/11/2020 15:30, Sergey Senozhatsky wrote:
> On (20/11/27 13:59), Hans Verkuil wrote:
>>
>> I think this needs a comment, basically explaining what you said in
>> the commit log. It's not obvious from the code that this is a
>> workaround.
> 
> Something like this?

Yes.

BTW, wouldn't it be sufficient to change this code to:

	if (!q->allow_cache_hints && q->memory != VB2_MEMORY_DMABUF) {
		vb->need_cache_sync_on_prepare = 1;
		vb->need_cache_sync_on_finish = 1;
	}

Or am I missing something?

DVB drivers do not set this flag, and even for DVB cache sync shouldn't be
needed for DMABUF, right?

Regards,

	Hans

> 
> ---
> 
> diff --git a/drivers/media/common/videobuf2/videobuf2-core.c b/drivers/media/common/videobuf2/videobuf2-core.c
> index 5499013cf82e..21b2b0ae3629 100644
> --- a/drivers/media/common/videobuf2/videobuf2-core.c
> +++ b/drivers/media/common/videobuf2/videobuf2-core.c
> @@ -414,6 +414,16 @@ static int __vb2_queue_alloc(struct vb2_queue *q, enum vb2_memory memory,
>                 vb->index = q->num_buffers + buffer;
>                 vb->type = q->type;
>                 vb->memory = memory;
> +               /*
> +                * A workaround fix. We need to set these flags here so that
> +                * videobuf2 core will always call ->prepare()/->finish()
> +                * cache sync/flush on vb2 buffers. Otherwise, for backends
> +                * that don't rely on V4L2 (perhaps dvb) these flags will
> +                * always be false and, hence, videobuf2 core will skip cache
> +                * sync/flush operations.
> +                */
> +               vb->need_cache_sync_on_prepare = 1;
> +               vb->need_cache_sync_on_finish = 1;
>                 for (plane = 0; plane < num_planes; ++plane) {
>                         vb->planes[plane].length = plane_sizes[plane];
>                         vb->planes[plane].min_length = plane_sizes[plane];
>