Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp1480178pxu; Fri, 27 Nov 2020 08:09:59 -0800 (PST) X-Google-Smtp-Source: ABdhPJwbeiLKUMI+T23d6DE2OWafXc4iW9+50jWof88rLl1CZYZg43oHuWQEro3Q97XgIoWwvhFd X-Received: by 2002:a50:bc02:: with SMTP id j2mr8646952edh.317.1606493399700; Fri, 27 Nov 2020 08:09:59 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1606493399; cv=none; d=google.com; s=arc-20160816; b=yakrziPJcD8DV1TfNboMV4/ASmI4d3EIARNo+nRnyI+uyvRKVgeSa3A6LbqTtOnPZy DUPPhyySYYarMEsldrJxEj6XvPhyN09Hgiil2D7+2j2blCRKCqR46y8F7CRa9HCqQO45 9CfV8AoADSu1YCJiLHICcYRimj0IEKikhxEj9yANhUjty++KubCY9RWEs6RE7IUWHWz8 krn2muJh1enmG6LedNcOlRTSP7ji7pkzGRkxde2iTg1NktwOJwedB9Wt2v2rgAOHAvpx Sl5OEGtohfLSEmxLCHJJvm+Ya9VdEH9msRVkfMwCDaqEMoSWvb7C7xQt0zAMnN/lxigN KrJg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=5y0cnCOSgeEuZwjF+lwNyk9ZCoaXsS5uH8ZnqDQJLGw=; b=AoACYoOiy7salr01hAZe+yQxQDZcG1c0YjzYuGQN6ZX35OpSDE18L4zuUXiB9M03jx yOWNSpuGRj9CFx5Vs6UeWPyRFv2Oq6CJtYkyGiOMz+tRKwiQgeuGi5Q7UcwHdBdoOLog RauoDUcUoxFt6YcFKvukDqhlBKg7DVdcuBuGVTTT/MqN2OMpqAIwyGhdV3QbqYEiViqg GVJ6IiYcAt97qXKkLa0Thd3jSXTneXKq0eme+uOrXCkGVPsi1PteB2wMrmi1nznVcqSn UVHBB8hWlgp4Eju4E882NCboOGaHDcjWjqn+GA0Os9OYlzLCRx0IQMifTY8pjCsT0gRH vQBw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=tCTUScwH; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id w8si5763447ejv.263.2020.11.27.08.09.35; Fri, 27 Nov 2020 08:09:59 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=tCTUScwH; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731169AbgK0QGM (ORCPT + 99 others); Fri, 27 Nov 2020 11:06:12 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48238 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726889AbgK0QGM (ORCPT ); Fri, 27 Nov 2020 11:06:12 -0500 Received: from mail-pf1-x443.google.com (mail-pf1-x443.google.com [IPv6:2607:f8b0:4864:20::443]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1A437C0613D2 for ; Fri, 27 Nov 2020 08:06:12 -0800 (PST) Received: by mail-pf1-x443.google.com with SMTP id e8so4971902pfh.2 for ; Fri, 27 Nov 2020 08:06:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=5y0cnCOSgeEuZwjF+lwNyk9ZCoaXsS5uH8ZnqDQJLGw=; b=tCTUScwH0byDPkT48N7M1GJPlekh3+TwXyKTpUudGHK3ODmu1Dda/NPabCIFKJA1pq 6rU/C30wUUfgMrrNHYjIpriDpAs9V0g6yWCSMYmSgu/ucek7JCgCODNdz0CM/Knc3Rn5 JGLGwuD+HO0pizkWONJ0dlc3xSqEew9ssP3xbMAp2+qgn9qSw0M9gblYy3BgsgVXLusp 1v1S7hbPq1Q5L85LtddTcXBPznAoGvBuUIysz4NX8gDeNDmao6vOBDKnX19/KtuZhpH1 AbxAWnViK43ShTtxjpwXRiZX6BhzBq3vqniBFJGZliRhfb8LjXvGU/XiyI7JsAJt81w1 9qQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=5y0cnCOSgeEuZwjF+lwNyk9ZCoaXsS5uH8ZnqDQJLGw=; b=maC3S13EYYkMB234ZjHkEa/S5jdAGoHcK5jCR3eWEwgBj8cJd/26DNq6aV7900GanF 0Gjg/qWrb74tlJubV460TTK0cjultcKeF/fIIkeFyxjwuTUZo82BUXGn/ptWEwlvVyp/ 5f/cG+XmtPMPYVkF+zcA9DmysRIdpMZibJtVL+otiAIpdwzb3p6dym06eG8Loz9dDvJD +rB65OF2XQZtqvwTVVL8wwEbmAkTmQi+R7dltXrFE7PqKlkZ5jhjYbS9/baT7JN/iEmo wkJtzE3a4XFXPSVC1O/0vnCrTjgpSnXl4WCEgM6qusB+bPQ6bSOqQGxfQJnjLVYSiTpo wIxA== X-Gm-Message-State: AOAM5325+WoO+CC5WSLnST1NamMJIpoxUPoIIG2bWjKQEIwH1kEq+X3F iJXyJrIx15e/jcdrEzSDVHKa7lm0c2rV X-Received: by 2002:a17:90a:68c3:: with SMTP id q3mr10906760pjj.135.1606493171411; Fri, 27 Nov 2020 08:06:11 -0800 (PST) Received: from thinkpad ([2409:4072:88d:6f0d:1941:b53e:6208:a8c9]) by smtp.gmail.com with ESMTPSA id h11sm8258263pfn.27.2020.11.27.08.06.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Nov 2020 08:06:10 -0800 (PST) Date: Fri, 27 Nov 2020 21:36:02 +0530 From: Manivannan Sadhasivam To: Robert Foss Cc: loic.poulain@linaro.org, bjorn.andersson@linaro.org, wsa@kernel.org, todor.too@gmail.com, vkoul@kernel.org, linux-i2c@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] i2c: qcom: Fix IRQ error misassignement Message-ID: <20201127160602.GA3096@thinkpad> References: <20201127133937.93208-1-robert.foss@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201127133937.93208-1-robert.foss@linaro.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Nov 27, 2020 at 02:39:37PM +0100, Robert Foss wrote: > During cci_isr() errors read from register fields belonging to > i2c master1 are currently assigned to the status field belonging to > i2c master0. This patch corrects this error, and always assigns > master1 errors to the status field of master1. > > Fixes: e517526195de ("i2c: Add Qualcomm CCI I2C driver") > You don't need a new line here. > Reported-by: Loic Poulain > Suggested-by: Loic Poulain > Signed-off-by: Robert Foss Reviewed-by: Manivannan Sadhasivam Thanks, Mani