Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp1489539pxu; Fri, 27 Nov 2020 08:20:48 -0800 (PST) X-Google-Smtp-Source: ABdhPJw4PvBuwwDefsGXaGJ6WewDhlNMAe6cBo5LIWvSIYCBV8RgSxDYi+gbPAq86PoyfNMo7VZ6 X-Received: by 2002:a17:906:22c7:: with SMTP id q7mr801055eja.486.1606494048045; Fri, 27 Nov 2020 08:20:48 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1606494048; cv=none; d=google.com; s=arc-20160816; b=nLz385Zgta+Azfp4wD0eyURx/ekQV4mfEg88I4OJCqaggaL2huvsfeKu58PAAydfbV dK9gQIdGORpFMw5jgQ1Jbj2RGEtsQePoaepHqp52P10PU5AZsH6WbpbRE5HpvnrlHKze 0ybJLG/uazyukelNEZTbTzjvBEWRBlymVJT3p1n5v92WlvLaZN1q1u3pP1Po7viLf5Ym KFX/gkO9EMxfRnhQ/gRYmw2YJPUp++Y1FrXVc2opDu7PTmA0F8bJGhlxRW8TChqFM2tz KxWZoFioxtxaaAkenCPifdVYg0OQPnJU5SD+pqCHoCfH4GdmCuRldK9tCMqmtJj5rY29 yfJg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :ironport-sdr:ironport-sdr; bh=8VSMAId5Mb8v6Q90GIUCu7F25ozUybFnRhvYFgZt5qE=; b=sB6mYpovT8a116uNACz9nSGA6+N97i+CKukJSt6fBCZV/5fHG9tz1enYyc7ZQD2umv EEpsmPWef0NMQ/uvW3AVchG6xRKJevdIWhs9us+349qRPW0ZsbCInZII5zI2XgsHde6r d2vXlxxQZH1eAYferZRAIchw1LbdXIxqFllg9hIyo+dLeBXmVzF7lliI03eeMqIsKDIu CS0sXZfAi+g9qWEkM9Rea0uXIamD0+aM3J/46ObgFSNaSq5hh6qwDPoVsbXDnHiqv7jX 5dLBy2JlIz4oKr3c9eW8k4sSKPRRvbn3gJgI4IXIRGKVL4P6JwJKkgT0mziLNOP/tMvz FMFA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id m6si5578018eji.658.2020.11.27.08.20.25; Fri, 27 Nov 2020 08:20:48 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731367AbgK0QSe (ORCPT + 99 others); Fri, 27 Nov 2020 11:18:34 -0500 Received: from mga09.intel.com ([134.134.136.24]:46780 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730324AbgK0QSe (ORCPT ); Fri, 27 Nov 2020 11:18:34 -0500 IronPort-SDR: AK9qlcSie6WFqH5XJuObpH+7dxcYRutjdw0rXkKjEok94dKAqbTwb1q62aXe3xzTrW0omzhJPg RaVQoVRqA/bQ== X-IronPort-AV: E=McAfee;i="6000,8403,9818"; a="172567164" X-IronPort-AV: E=Sophos;i="5.78,375,1599548400"; d="scan'208";a="172567164" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Nov 2020 08:18:33 -0800 IronPort-SDR: LNRD34yjDKhKsejH9usrAuRXFZh1h9gtsXH3CebUPDjWub2FJGJHN03b1fseTFWRiEy4qQ0YV2 PlGvHyJk9HFA== X-IronPort-AV: E=Sophos;i="5.78,375,1599548400"; d="scan'208";a="548095161" Received: from paolonig001.ir.intel.com ([163.33.183.93]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Nov 2020 08:18:31 -0800 From: Gabriele Paoloni To: tony.luck@intel.com, bp@alien8.de, tglx@linutronix.de, mingo@redhat.com, x86@kernel.org, hpa@zytor.com, linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org Cc: gabriele.paoloni@intel.com, linux-safety@lists.elisa.tech Subject: [PATCH v2 4/5] x86/mce: remove redundant call to irq_work_queue() Date: Fri, 27 Nov 2020 16:18:18 +0000 Message-Id: <20201127161819.3106432-5-gabriele.paoloni@intel.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201127161819.3106432-1-gabriele.paoloni@intel.com> References: <20201127161819.3106432-1-gabriele.paoloni@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Right now in do_machine_check() __mc_scan_banks() triggers the following call tree: __mc_scan_banks()->mce_log()->irq_work_queue(&mce_irq_work). Hence the call of irq_work_queue() below after __mc_scan_banks() seems redundant. Just remove it. Signed-off-by: Gabriele Paoloni Reviewed-by: Tony Luck --- arch/x86/kernel/cpu/mce/core.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/arch/x86/kernel/cpu/mce/core.c b/arch/x86/kernel/cpu/mce/core.c index d766a3f6a343..802302c54762 100644 --- a/arch/x86/kernel/cpu/mce/core.c +++ b/arch/x86/kernel/cpu/mce/core.c @@ -1408,9 +1408,6 @@ noinstr void do_machine_check(struct pt_regs *regs) } } - if (worst > 0) - irq_work_queue(&mce_irq_work); - if (worst != MCE_AR_SEVERITY && !kill_it) goto out; -- 2.20.1 --------------------------------------------------------------------- INTEL CORPORATION ITALIA S.p.A. con unico socio Sede: Milanofiori Palazzo E 4 CAP 20094 Assago (MI) Capitale Sociale Euro 104.000,00 interamente versato Partita I.V.A. e Codice Fiscale 04236760155 Repertorio Economico Amministrativo n. 997124 Registro delle Imprese di Milano nr. 183983/5281/33 Soggetta ad attivita' di direzione e coordinamento di INTEL CORPORATION, USA This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies.