Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <3168a3aa5c4ac564340cba2a151359e8cd3dee5f.camel@perches.com>
Subject: Re: [PATCH] eCryptfs: add a semicolon
From:   Joe Perches <joe@perches.com>
To:     trix@redhat.com, code@tyhicks.com, hannes@cmpxchg.org,
        mhocko@suse.com, longman@redhat.com, herbert@gondor.apana.org.au,
        ebiggers@google.com
Cc:     ecryptfs@vger.kernel.org, linux-kernel@vger.kernel.org
Date:   Fri, 27 Nov 2020 10:11:23 -0800
In-Reply-To: <20201127160513.2619747-1-trix@redhat.com>
References: <20201127160513.2619747-1-trix@redhat.com>
Content-Type: text/plain; charset="ISO-8859-1"
User-Agent: Evolution 3.38.1-1 
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Precedence: bulk

On Fri, 2020-11-27 at 08:05 -0800, trix@redhat.com wrote:
> Function like macros should have a semicolon.
[]
> diff --git a/fs/ecryptfs/keystore.c b/fs/ecryptfs/keystore.c
[]
> @@ -1172,7 +1172,7 @@ decrypt_pki_encrypted_session_key(struct ecryptfs_auth_tok *auth_tok,
> ?	rc = ecryptfs_cipher_code_to_string(crypt_stat->cipher, cipher_code);
> ?	if (rc) {
> ?		ecryptfs_printk(KERN_ERR, "Cipher code [%d] is invalid\n",
> -				cipher_code)
> +				cipher_code);

As this is the only use that does not have a semicolon,
it'd be good to add the removal of the semicolon from
the #define at the same time.