Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp1595141pxu; Fri, 27 Nov 2020 10:32:51 -0800 (PST) X-Google-Smtp-Source: ABdhPJzZsXpLPxRmrtsnb/WYjF1heU7joeCU09L/CMGxugSmyIDFFP3YhlsHIdc6o59+xTsdOKtT X-Received: by 2002:a17:907:43ec:: with SMTP id ol20mr1294510ejb.164.1606501971260; Fri, 27 Nov 2020 10:32:51 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1606501971; cv=none; d=google.com; s=arc-20160816; b=iuQ9SacSpg/n4zvEjlWPtLifkd/c9ND7JwTs042cIpX0EA07oKpYzgzwLGbi5goezf CqvcT6rtUNI2UnkSqR/OkTE3XptoVOGNSfA7gNtv/97P0RAJXUQuylTWnaGsDFZbh/6J CsTtAZSeWQnLr8YbnPUAijVHqM5HU9HEshwP+RIww5dVEEjIuodL3wWNKfOCeKhexWbf m1cu8DC3a708BNtIkbOFxFoRD6/JdbE+OKfpFhZZaFfopbMWrmXHK/GUwlz4EQWdaUkr TEqUIE9Q98Q1xJQM/jo5ES/KjAutRXHyJ2S1DZWg19t1CfjWeMFKV5sgimZ6Ib3Y6WJq 7fKQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=+/0rW7TNirT7Yz6SJcksJ8iMKb+eobkF0dDsgxeuHGg=; b=xyUXDatQAPiso+dJN2daZV6iL7ZSGdljgsPK18omGYBsahr8OuYbgavb/NOJ1Hsdh0 RVoT06ysyWqC943TCOC6W6fsZP24LDiKy1znpkO3r5d/ZGrOrK9XzZGaHbTliWaJpvPa rRn4stWgMAqpOyQeOQCbUJU8F65iZEs6qSA4j5/FviYJeY3BrldRyBa13F1OodrCum1G s3wH/UMsnZyvfUTgDK0qgMrZAWJBdu7e8vmMoqZ+taK8fFYiGu24WN5WaE7+XfKKtpA1 KorvR6u75qf1Vl13JItlBMOj6KPJSEAK8mPsvFWF84DWdFn6SWyh9vBKctjcsIFgg0Xe 0jtQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b="qfV/BlxT"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id t21si6037118edq.546.2020.11.27.10.32.29; Fri, 27 Nov 2020 10:32:51 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b="qfV/BlxT"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730628AbgK0NsF (ORCPT + 99 others); Fri, 27 Nov 2020 08:48:05 -0500 Received: from mail.kernel.org ([198.145.29.99]:41304 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729662AbgK0NsF (ORCPT ); Fri, 27 Nov 2020 08:48:05 -0500 Received: from localhost (82-217-20-185.cable.dynamic.v4.ziggo.nl [82.217.20.185]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4889D20B1F; Fri, 27 Nov 2020 13:48:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1606484884; bh=s4L3W3v15jG9m4793BP8yzNg4FXIDOP6MeUh6vZiQrc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=qfV/BlxTzXCyLMkp7wyEqjKedhCJ2+5Ddu6UrrUYWq4le0iw+gfSeA/M0UCXLVbqx XuLQ8jILdgND4bwXUk2r0aOyYvPfLPJ27YXcVILoDdK0VgyyKua5gOliaJ5cIwpP9K YCVTRLJhI1FruS4lS8a3qSBiXZLFYthOpLyfWan4= Date: Fri, 27 Nov 2020 14:48:02 +0100 From: Greg Kroah-Hartman To: Peter Chen Cc: "balbi@kernel.org" , "linux-usb@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Will McVicker , stable Subject: Re: [PATCH 4/4] USB: gadget: f_midi: setup SuperSpeed Plus descriptors Message-ID: References: <20201126180937.255892-1-gregkh@linuxfoundation.org> <20201126180937.255892-4-gregkh@linuxfoundation.org> <20201127120621.GD22238@b29397-desktop> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201127120621.GD22238@b29397-desktop> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Nov 27, 2020 at 12:06:50PM +0000, Peter Chen wrote: > On 20-11-26 19:09:37, Greg Kroah-Hartman wrote: > > From: Will McVicker > > > > Needed for SuperSpeed Plus support for f_midi. This allows the > > gadget to work properly without crashing at SuperSpeed rates. > > > > Cc: Felipe Balbi > > Cc: stable > > Signed-off-by: Will McVicker > > Signed-off-by: Greg Kroah-Hartman > > --- > > drivers/usb/gadget/function/f_midi.c | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > diff --git a/drivers/usb/gadget/function/f_midi.c b/drivers/usb/gadget/function/f_midi.c > > index 85cb15734aa8..ceb67651de4f 100644 > > --- a/drivers/usb/gadget/function/f_midi.c > > +++ b/drivers/usb/gadget/function/f_midi.c > > @@ -1048,6 +1048,11 @@ static int f_midi_bind(struct usb_configuration *c, struct usb_function *f) > > f->ss_descriptors = usb_copy_descriptors(midi_function); > > if (!f->ss_descriptors) > > goto fail_f_midi; > > Add one blank line, otherwise: Will add it, good idea. > Reviewed-by: Peter Chen Thanks for reviewing all of these, much appreciated. greg k-h