Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp1605587pxu; Fri, 27 Nov 2020 10:47:50 -0800 (PST) X-Google-Smtp-Source: ABdhPJxdT+wkAyCFboQH8mQKyaAjjhOztsGG03xm8xKzwiUAzFMgbobdqYdgeR2nRr5AJwXF8eyz X-Received: by 2002:a17:906:ae95:: with SMTP id md21mr9252782ejb.425.1606502870774; Fri, 27 Nov 2020 10:47:50 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1606502870; cv=none; d=google.com; s=arc-20160816; b=fPO0GVgzyyNIZ+S61/WyhnElTdjAgvrC5DU6Wmjuja6qkncgAoR9YvdX6q/fa6PL6d VimeuRXmF9fIeBY7py7M5ixHYskJTnatiDunPqELA6aksuMWLapWyD7LEyNV5DWmh0uH Q2/TA0oNLC/eJ+E5Znm8F211zVZt06UE7ctHA2Js4yISmG8ctaWdeTwOdRpoZrBsYBpw h5d8pHCTW5Ekf0WOrIa7+5r/nBEUaa1XeSWdokSpULYhykZP3VZLMM+U0RrQx3asy2G9 AIkiCz4o7l8bwIIHrZOgy+8k8RoiyEN/4QaZcnNUItI1fUGoZp1nEMnnY53HEqGp90fl FBHw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject:dkim-signature; bh=3/ZVldWlmUIuJREyB1FkD2ej4pD6YkF1Luk5Fj3d0No=; b=nZFSVtV7rgkImw0atAtyrrS+OStxKBxGvPpIKM/LxurJD7ZnViDV20PKHM0lgl7bzN fMPk45F08LlIt/qqYZFL2LNq1z6v7bvdTHD+43h1FvILE9RzNIE2oZEQ2BpoVZcJONr8 YUZdE+1pKE0z7OfTI0UpjTQyhibA1TUj4IcsBUiCWFUJg9t3gmlu6RFTuiC333/1vdnn ufpI0uYIX4g7KX0oZ1nLwftOrriItCncb8TlaIz51iYhF8g2/kw2m7Uvk3Uk7nYWiNIB 5XHErGLXqxRUUviTqMmmUj43OrdksaOnQCZ5Xzalqo1coj2coiUcmTFH7T50CzvUWaAK FTRA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ibm.com header.s=pp1 header.b=M0vCfNC9; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=ibm.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id u20si5616053ejt.331.2020.11.27.10.47.27; Fri, 27 Nov 2020 10:47:50 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@ibm.com header.s=pp1 header.b=M0vCfNC9; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=ibm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732361AbgK0RpT (ORCPT + 99 others); Fri, 27 Nov 2020 12:45:19 -0500 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:32626 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1731398AbgK0RpS (ORCPT ); Fri, 27 Nov 2020 12:45:18 -0500 Received: from pps.filterd (m0098419.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 0ARHVYU2036883; Fri, 27 Nov 2020 12:45:05 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=subject : to : cc : references : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=pp1; bh=3/ZVldWlmUIuJREyB1FkD2ej4pD6YkF1Luk5Fj3d0No=; b=M0vCfNC9KgfdSs1xC3Mgxm/SWoqau3dkh8ZGE8VwnmR1Dp4bI7DeBfG3pYjagcmI/k+F oPCqzykzpBXCCxKJEayMO/U6HOMAtqdd3onhY9jbYjVazZ2RxrJrbgn9wphrNMB1D2VQ 6bRuK0/12tIO7BxgI9FVew/lw2GQ0xaFvI7j8La7Sbs85ouh0pqRRZoPs4TTOJeOR7To I8+CBXehbGzkw9zTa4ZbDxZ4F/9kmy0AU33oIe4w9s9aASwrB1FmpobQfZ6PDthwpbbQ x7O57oqTervzxQlbync8rpokPscTHr6AJdwh93/i/KDHMWWZTaa2wTO4y3ynzXOKve7r vg== Received: from ppma02dal.us.ibm.com (a.bd.3ea9.ip4.static.sl-reverse.com [169.62.189.10]) by mx0b-001b2d01.pphosted.com with ESMTP id 3535utgbjw-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 27 Nov 2020 12:45:05 -0500 Received: from pps.filterd (ppma02dal.us.ibm.com [127.0.0.1]) by ppma02dal.us.ibm.com (8.16.0.42/8.16.0.42) with SMTP id 0ARHhD6k027669; Fri, 27 Nov 2020 17:45:05 GMT Received: from b03cxnp08026.gho.boulder.ibm.com (b03cxnp08026.gho.boulder.ibm.com [9.17.130.18]) by ppma02dal.us.ibm.com with ESMTP id 34xthav05c-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 27 Nov 2020 17:45:05 +0000 Received: from b03ledav006.gho.boulder.ibm.com (b03ledav006.gho.boulder.ibm.com [9.17.130.237]) by b03cxnp08026.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 0ARHisCM28508526 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 27 Nov 2020 17:44:54 GMT Received: from b03ledav006.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 6F2DDC605B; Fri, 27 Nov 2020 17:45:03 +0000 (GMT) Received: from b03ledav006.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id EF892C6057; Fri, 27 Nov 2020 17:45:02 +0000 (GMT) Received: from oc6034535106.ibm.com (unknown [9.163.79.105]) by b03ledav006.gho.boulder.ibm.com (Postfix) with ESMTP; Fri, 27 Nov 2020 17:45:02 +0000 (GMT) Subject: Re: [PATCH 01/13] ibmvfc: add vhost fields and defaults for MQ enablement To: Tyrel Datwyler , james.bottomley@hansenpartnership.com Cc: martin.petersen@oracle.com, linux-scsi@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, brking@linux.ibm.com References: <20201126014824.123831-1-tyreld@linux.ibm.com> <20201126014824.123831-2-tyreld@linux.ibm.com> From: Brian King Message-ID: <97e577a0-50f5-3ade-a377-7479f0f1c890@linux.vnet.ibm.com> Date: Fri, 27 Nov 2020 11:45:02 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.3.1 MIME-Version: 1.0 In-Reply-To: <20201126014824.123831-2-tyreld@linux.ibm.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.312,18.0.737 definitions=2020-11-27_10:2020-11-26,2020-11-27 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 malwarescore=0 suspectscore=0 adultscore=0 phishscore=0 spamscore=0 priorityscore=1501 clxscore=1015 lowpriorityscore=0 mlxlogscore=999 mlxscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2011270099 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/25/20 7:48 PM, Tyrel Datwyler wrote: > diff --git a/drivers/scsi/ibmvscsi/ibmvfc.h b/drivers/scsi/ibmvscsi/ibmvfc.h > index 9d58cfd774d3..8225bdbb127e 100644 > --- a/drivers/scsi/ibmvscsi/ibmvfc.h > +++ b/drivers/scsi/ibmvscsi/ibmvfc.h > @@ -41,6 +41,11 @@ > #define IBMVFC_DEFAULT_LOG_LEVEL 2 > #define IBMVFC_MAX_CDB_LEN 16 > #define IBMVFC_CLS3_ERROR 0 > +#define IBMVFC_MQ 0 Given that IBMVFC_MQ is getting set to 0 here, that means mq_enabled is also always zero, so am I correct that a lot of this code being added is not yet capable of being executed? > +#define IBMVFC_SCSI_CHANNELS 0 Similar comment here... > +#define IBMVFC_SCSI_HW_QUEUES 1 I don't see any subsequent patches in this series that would ever result in nr_hw_queues getting set to anything other than 1. Is that future work planned or am I missing something? > +#define IBMVFC_MIG_NO_SUB_TO_CRQ 0 > +#define IBMVFC_MIG_NO_N_TO_M 0 > > /* > * Ensure we have resources for ERP and initialization: > @@ -826,6 +831,10 @@ struct ibmvfc_host { > int delay_init; > int scan_complete; > int logged_in; > + int mq_enabled; > + int using_channels; > + int do_enquiry; > + int client_scsi_channels; > int aborting_passthru; > int events_to_log; > #define IBMVFC_AE_LINKUP 0x0001 > -- Brian King Power Linux I/O IBM Linux Technology Center