Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp1706031pxu; Fri, 27 Nov 2020 13:16:12 -0800 (PST) X-Google-Smtp-Source: ABdhPJzy8cULHd8Vjj+VlgAHmaxPr37f7JuQwD5eF0qvyfLtN1f2+Jg6Hyw0UzDfNR8Kc1odc9fe X-Received: by 2002:a50:8a9c:: with SMTP id j28mr10028558edj.254.1606511771985; Fri, 27 Nov 2020 13:16:11 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1606511771; cv=none; d=google.com; s=arc-20160816; b=QTrXCqZB/WOZoqmrPY0o14XSIW2glqn8dO4Q6ENT2d+/1ngdyetaR0gu51Ing46/yk PxueeH81U3A2KSBKu7Yb8gwxw5GV0pDrMqiyhtzcmtg1AljHe6maD+mVwT91pQ8rX36g SbkZBBhzhVXgJiXEwonGDjC6K9t0d6AAcb7XgwpTnPnpgHaKbgkKDX5PI16elYRv3Hjr QmV2Lh7gKarbMpI8ot/3UFi3FKMuvWbO0qLfJO+qGA6fxzepckAK2vFgiuaWnPydMiZO OFuZ2a99R4hf6K9o3ia8medvP6BJtddEmK2QWMODPjzbxWhAtuQd7ppSUG07hVCPtHW2 ALzg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=bAxPdn47aM9IdVglEAT8HlAHepHSwulRdTFGmjjNsxg=; b=Q5w37bgkUkai9ZVCKnyKjyPsZH6xkisY7PfVbbul5ZGlLqsM1Ll1mYBvrINkurk89f Rup2yvA5pnZrVmYC/Q7fw92AjtMphCGQxU6pFsbEizyWeazIOxNmACFIqNyy3VgerDNX aDxtbz4S9N1EYMdtDgZa0NtrI0qcMaLE2SJ4Cq9kdp3Dl8/L3Dv+ymi7cAjiY//F7lH7 g9jY/witalIhoy//hWZ4gxczG5SxVYTEUIdAOGn90hQ2hbT8svBslj3RqInVqJU5bABU 7BkJsKDOFjAD5/5EbYxntukMs+Fs7AWpJgALEUSGWMer65AYLav/bCxSTuvltiXBGoQ3 Ok9A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=JViVtJPh; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id w22si6036256ejf.740.2020.11.27.13.15.48; Fri, 27 Nov 2020 13:16:11 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=JViVtJPh; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728495AbgK0U53 (ORCPT + 99 others); Fri, 27 Nov 2020 15:57:29 -0500 Received: from mail.kernel.org ([198.145.29.99]:44936 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729708AbgK0Ux0 (ORCPT ); Fri, 27 Nov 2020 15:53:26 -0500 Received: from kicinski-fedora-pc1c0hjn.DHCP.thefacebook.com (unknown [163.114.132.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5026F2223D; Fri, 27 Nov 2020 20:52:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1606510372; bh=fA6BeuFD5oyyP5wjr3eiwdD8EAbpd24W7Vpd0iS8iQ4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=JViVtJPhtnwj/qmSlX1GNob+QbExO+i6gvfVlQsfiWm6OXFTrpp+DSmwiUagq5e55 axJStRDi2OvOho/U/Wc+AsTNkXsshdqlybUUyD1+qXuOnKLOSffvjqBp1/s+XDeceT ph/3CEK17cjN7XTxzCp9tIwPCC9RUWvd7Z+bjfAA= Date: Fri, 27 Nov 2020 12:52:51 -0800 From: Jakub Kicinski To: Huazhong Tan Cc: , , , , , Subject: Re: [PATCH net-next 1/7] net: hns3: add support for RX completion checksum Message-ID: <20201127125251.7d25bb1a@kicinski-fedora-pc1c0hjn.DHCP.thefacebook.com> In-Reply-To: <1606466842-57749-2-git-send-email-tanhuazhong@huawei.com> References: <1606466842-57749-1-git-send-email-tanhuazhong@huawei.com> <1606466842-57749-2-git-send-email-tanhuazhong@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 27 Nov 2020 16:47:16 +0800 Huazhong Tan wrote: > In some cases (for example ip fragment), hardware will > calculate the checksum of whole packet in RX, and setup > the HNS3_RXD_L2_CSUM_B flag in the descriptor, so add > support to utilize this checksum. > > Signed-off-by: Huazhong Tan drivers/net/ethernet/hisilicon/hns3/hns3_enet.c:2810:14: warning: incorrect type in assignment (different base types) drivers/net/ethernet/hisilicon/hns3/hns3_enet.c:2810:14: expected restricted __sum16 [usertype] csum drivers/net/ethernet/hisilicon/hns3/hns3_enet.c:2810:14: got unsigned int drivers/net/ethernet/hisilicon/hns3/hns3_enet.c:2812:14: warning: invalid assignment: |= drivers/net/ethernet/hisilicon/hns3/hns3_enet.c:2812:14: left side has type restricted __sum16 drivers/net/ethernet/hisilicon/hns3/hns3_enet.c:2812:14: right side has type unsigned int