Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp1806113pxu; Fri, 27 Nov 2020 16:12:16 -0800 (PST) X-Google-Smtp-Source: ABdhPJw5LYI/DrD1nPh3+ZkQzqNTdrIs0MvGndoIU2aq8s4LK+L+r/qOcalcQup4+TB5dv6vKTaN X-Received: by 2002:aa7:c358:: with SMTP id j24mr10736174edr.265.1606522336615; Fri, 27 Nov 2020 16:12:16 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1606522336; cv=none; d=google.com; s=arc-20160816; b=0HGqeaELnLvR2p/F+qfclDqWmWxCTS9SUImm5uxWPu/g0BvYpK2XHzD4J+2HpuucOc H03p0rO+AFca2Gtc0kNsW8bNGfpv9zKbeSR9l8dgCzhoTSsWXmbbnD07tyu73wl9DujH HAHiHLnOzXh7TqxdbTExt7SVIVZtPTV5dvQ3gFt9EMb1tpGyCc+HIjk3gXwPcayr7HOd 4WLonGZEuQiNcDDVzn731+AumqppYSf8dNiWAQOb1bApOcoeEOnCikXtR2XgPOF5i9ra qXACtfPBjVxz55+bkHX9+jH831LSsPQQEQ458lXzAWteDDisKRVuL5ggnbnIbihQeeZP p5mg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=B55PUlpCc3md5l5j08oU1bGihq0DhZzpycVXnyu/Nbo=; b=hZ3OlSBiLoX9rF5FdGWWHKcTJ9hJh6gDVr3uyRHJqwrr1lorsdFMjHLSBOrMUm+Ea1 Lhbjbt0KxI/JJcjW2clpW1wUMGsNrtERY6LQ6nnA82fY160j24uFt3ZdSUcQl+9e0pQb QBsgt2kwfysoTKALQ0NyxmyfG7BO6Ig4BjWjn0dntlO8rOskzkKBxcJcZW8MLSTFCB5P T7FFgJurjxlS5DBqwJi2MBVv4HLPCRCLkLfCUL6d2vVIdK3//+Bx/juKiKYKdbZ63AjE dqt71rljcO2/BnM9Hztw7EiQu9CK7W0okvdh9dH2pRcCN4ax6REq6HSIcpNolLQglVYU mEmQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=zBRzW+qN; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id s9si6487205edt.290.2020.11.27.16.11.37; Fri, 27 Nov 2020 16:12:16 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=zBRzW+qN; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732202AbgK1ACb (ORCPT + 99 others); Fri, 27 Nov 2020 19:02:31 -0500 Received: from mail.kernel.org ([198.145.29.99]:42670 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731565AbgK1AB6 (ORCPT ); Fri, 27 Nov 2020 19:01:58 -0500 Received: from kicinski-fedora-pc1c0hjn.DHCP.thefacebook.com (unknown [163.114.132.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 06A4A2223F; Sat, 28 Nov 2020 00:01:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1606521678; bh=LECueOqRQ+DDTtDsX3sm3StVu4cyL88reB7AmOrwxCo=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=zBRzW+qNqUsiEdE1j90KpYDOa1cDNWC+do23itXwZZNpZXSy2hyfRur9dmU4UmVy0 e+5qzHCfgx/euc2KZ7sYbW9o/RGFHP56CRuQ4Bd6cBZoYqUHS+i70XbxSbx6zV9DEJ Liqwq5tkqrvUNfBOby3eiASJcqr4aNxcvrv0lcAk= Date: Fri, 27 Nov 2020 16:01:16 -0800 From: Jakub Kicinski To: bongsu.jeon2@gmail.com Cc: krzk@kernel.org, k.opasiak@samsung.com, linux-nfc@lists.01.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Bongsu Jeon Subject: Re: [PATCH v2 net-next 3/3] nfc: s3fwrn5: extract the common phy blocks Message-ID: <20201127160116.5c8e6853@kicinski-fedora-pc1c0hjn.DHCP.thefacebook.com> In-Reply-To: <1606476138-31992-1-git-send-email-bongsu.jeon2@gmail.com> References: <1606476138-31992-1-git-send-email-bongsu.jeon2@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 27 Nov 2020 20:22:18 +0900 bongsu.jeon2@gmail.com wrote: > From: Bongsu Jeon > > Extract the common phy blocks to reuse it. > The UART module will use the common blocks. > > Signed-off-by: Bongsu Jeon > --- > Changes in v2: > - remove the common function's definition in common header file. > - make the common phy_common.c file to define the common function. > - wrap the lines. > - change the Header guard. > - remove the unused common function. You need to repost the entire series. Please wait around 8 hours and rebase on top of net-next. At that point Krzysztof's fix which you were including as patch 1 should already be in net-next, so you should be able to post just the latter two patches.