Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 27 Nov 2020 19:53:23 +0000
From:   Matthew Wilcox <willy@infradead.org>
To:     trix@redhat.com
Cc:     jlayton@kernel.org, bfields@fieldses.org, viro@zeniv.linux.org.uk,
        linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] locks: remove trailing semicolon in macro definition
Message-ID: <20201127195323.GZ4327@casper.infradead.org>
References: <20201127190707.2844580-1-trix@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20201127190707.2844580-1-trix@redhat.com>
Precedence: bulk

On Fri, Nov 27, 2020 at 11:07:07AM -0800, trix@redhat.com wrote:
> +++ b/fs/fcntl.c
> @@ -526,7 +526,7 @@ SYSCALL_DEFINE3(fcntl64, unsigned int, fd, unsigned int, cmd,
>  	(dst)->l_whence = (src)->l_whence;	\
>  	(dst)->l_start = (src)->l_start;	\
>  	(dst)->l_len = (src)->l_len;		\
> -	(dst)->l_pid = (src)->l_pid;
> +	(dst)->l_pid = (src)->l_pid

This should be wrapped in a do { } while (0).

Look, this warning is clearly great at finding smelly code, but the
fixes being generated to shut up the warning are low quality.