Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp2433404pxu; Sat, 28 Nov 2020 14:00:37 -0800 (PST) X-Google-Smtp-Source: ABdhPJxTufJsiHiDWKek8KqF1ei6qn8t8DnjLK7GzXCWKigwcctWKPUTRgB/6d724ythuPT49PIY X-Received: by 2002:a50:951e:: with SMTP id u30mr15053759eda.197.1606600837159; Sat, 28 Nov 2020 14:00:37 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1606600837; cv=none; d=google.com; s=arc-20160816; b=aInud+cplPl9EUgtwXW+V2w/zXOcv5wtt9Bp0pCN+dJ06lbdS5sANAHN1GWqzDR37n oDk6p7USV6QsdTZi3X6RLe+9XafwqbwOsp7F6NK9JoQaAHzWVw601H7N3ZN7W3Py1UJe pukp+6ua4nxbm6LXkTIzr+HWlHHYX0ryf0n1lhs2WuiX6CQLJLoTuCDHf6584zgCPRXu 10xhyWJr5aOK/H9SkDz84RJVxcRHVHyeBUoS+gMv8gXDYZzhFXz9tXvzrqFcfbeO5BSN CrJWkhfpJ0tAcBbi7QtY3lPMZK2qAhbu6Fi+Lh1/0Aua+SnQk20bdZAndmnAy26vdadC 1VRA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=xnguNqw8Jp/tgZl8ok35SN/m2Hk2x9K7SXVF85uOJBc=; b=i3Mfcuth+4R9stO8NBDVnRnQafksDs8cN33Gl9BVVTBJMiMqVCXqV9QcuwVTq7ttSh 2URyvKQEuA7G99UN4JyRcH3Z3fD4fmzC7A9JPpnWPN1kFZuP7PpmGmLuMmuoaNarKUQL LwlwlFJwNcbRAxQY58d4JRS4RcNwI9dJI5uByJmo6tmDXFUeaQHH9JicvL4mUySZTaK5 +J4xfdCcucVTOrSG8Q496QbBvyFKfK7vY3qOB2h+JLfnMckOZ+fao7nu0715CFCsRGyJ Hugazbmq2i7q2z6sgcYOAZeYbidaS9CdZ9k6if78bh5jZmNwa8sSj1wBAiMlEhlNgp3C 5fsA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id dt15si7132271ejc.661.2020.11.28.14.00.14; Sat, 28 Nov 2020 14:00:37 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391183AbgK1VwL (ORCPT + 99 others); Sat, 28 Nov 2020 16:52:11 -0500 Received: from asavdk3.altibox.net ([109.247.116.14]:44830 "EHLO asavdk3.altibox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732153AbgK1S7K (ORCPT ); Sat, 28 Nov 2020 13:59:10 -0500 Received: from ravnborg.org (unknown [188.228.123.71]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by asavdk3.altibox.net (Postfix) with ESMTPS id 5D02C2003A; Sat, 28 Nov 2020 19:58:22 +0100 (CET) Date: Sat, 28 Nov 2020 19:58:20 +0100 From: Sam Ravnborg To: Paul Cercueil Cc: David Airlie , Daniel Vetter , od@zcrc.me, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] drm/ingenic: Add basic PM support Message-ID: <20201128185820.GA1001988@ravnborg.org> References: <20201128171606.132830-1-paul@crapouillou.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201128171606.132830-1-paul@crapouillou.net> X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=Ibmpp1ia c=1 sm=1 tr=0 a=S6zTFyMACwkrwXSdXUNehg==:117 a=S6zTFyMACwkrwXSdXUNehg==:17 a=kj9zAlcOel0A:10 a=ER_8r6IbAAAA:8 a=7gkXJVJtAAAA:8 a=_LUwhb1OVfxuG1nTQZAA:9 a=CjuIK1q_8ugA:10 a=9LHmKk7ezEChjTCyhBa9:22 a=E9Po1WZjFZOl8hwRPBS3:22 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Paul. On Sat, Nov 28, 2020 at 05:16:06PM +0000, Paul Cercueil wrote: > Call drm_mode_config_helper_suspend() and > drm_mode_config_helper_resume() on suspend and resume, respectively. > > This makes sure that the display stack is properly disabled when the > hardware is put to sleep. > > Signed-off-by: Paul Cercueil As discussed on irc, with resume fixed to return the result of the drm_mode_config_helper_resume() call. Reviewed-by: Sam Ravnborg