Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp2434942pxu; Sat, 28 Nov 2020 14:02:51 -0800 (PST) X-Google-Smtp-Source: ABdhPJxmzfrDnrbdhbF8/cgk4t09lNC69dgJl2/oXHbBB15+CSSFVHrxE4u0pn5THlaj6ixMFP1I X-Received: by 2002:a50:b264:: with SMTP id o91mr14641176edd.7.1606600970997; Sat, 28 Nov 2020 14:02:50 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1606600970; cv=none; d=google.com; s=arc-20160816; b=gy9mGR8CtZSHcNVkmFKC6dPi9jHuU9/qO0UGfY/FPGNoPcSmPxrHUwpNnBCjTvPcX8 yU9Gcp+um/0m5TxY8qhwCioHPj8FdShZXk6wA5wJECbNuPkSB7dJQzIm91vOlYBmpiXw a6YZE6HF9L5ZQYa18XH/nY8IG1Bsr+4QGczToZWsgUol3FS9pqjSuQyXVVfTUkX22MZw 2Mbm9d7pCp0GAAOd8QXlcBNgaIT8fBiFColxhBsjynMFxXPWV5grguix8B98IQ4PylJs t6sg1EQLeCkjpWxevM0cVTlGbal6nQ+tqCRk02TavrWRi3CDceUTRRBeVgeZTPVvUsFk ElUA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject; bh=LJJaMcUgYXrr3nki5L4RKETC+IXIxh8LqKDxVdq7zqY=; b=NGWxIko1Y5MSafMWUUYVQrz/dbd2j4R+EqZTCYtln/UbU76BOj2+5HiwEdnHdzvqq1 6HLArFpLWrPc830Vvv3r39Ds1Jl4C5BHz8WIaHTgk4jZ288lL8CTXl1p2yIKE6+FnFk8 K5FPohdnHm+nF7FuRxAhkC14e/0VatlGZAbSsmaahbkjU2SUZWrRHLLxCK+QBrUGru1F ihQT54qHZoaitAaUK09lLYDwrgyvxkmX5fYZCj1IHVimMjItNKSNOxhxZvn6F/o5hgz7 78ww3WsjJe/IE/CIHZOeU9GdhpJuK/et/zMU6F2o38t7QBu3dhbTC/FzlDCRAq4DEmnT ZKkA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id a88si5933623ede.230.2020.11.28.14.02.28; Sat, 28 Nov 2020 14:02:50 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391403AbgK1WA6 (ORCPT + 99 others); Sat, 28 Nov 2020 17:00:58 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42842 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2391337AbgK1WA4 (ORCPT ); Sat, 28 Nov 2020 17:00:56 -0500 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 625CCC0613D3 for ; Sat, 28 Nov 2020 14:00:16 -0800 (PST) Received: from gallifrey.ext.pengutronix.de ([2001:67c:670:201:5054:ff:fe8d:eefb] helo=[127.0.0.1]) by metis.ext.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1kj8GF-0005eW-NB; Sat, 28 Nov 2020 23:00:07 +0100 Subject: Re: [Linux-stm32] [PATCH v8 3/5] ARM: dts: stm32: Fix schema warnings for pwm-leds To: Alexander Dahl , Rob Herring Cc: devicetree@vger.kernel.org, Alexander Dahl , linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Maxime Coquelin , linux-amlogic@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, linux-leds@vger.kernel.org References: <20201128215353.3991-1-post@lespocky.de> <20201128215353.3991-4-post@lespocky.de> From: Ahmad Fatoum Message-ID: <044d49be-2016-818e-b1b0-ee50c3b744e7@pengutronix.de> Date: Sat, 28 Nov 2020 23:00:06 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.3.1 MIME-Version: 1.0 In-Reply-To: <20201128215353.3991-4-post@lespocky.de> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 2001:67c:670:201:5054:ff:fe8d:eefb X-SA-Exim-Mail-From: a.fatoum@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 28.11.20 22:53, Alexander Dahl wrote: > The node names for devices using the pwm-leds driver follow a certain > naming scheme (now). Parent node name is not enforced, but recommended > by DT project. > > DTC arch/arm/boot/dts/stm32mp157c-lxa-mc1.dt.yaml > CHECK arch/arm/boot/dts/stm32mp157c-lxa-mc1.dt.yaml > /home/alex/build/linux/arch/arm/boot/dts/stm32mp157c-lxa-mc1.dt.yaml: led-rgb: 'led-blue', 'led-green', 'led-red' do not match any of the regexes: '^led(-[0-9a-f]+)?$', 'pinctrl-[0-9]+' > From schema: /home/alex/src/linux/leds/Documentation/devicetree/bindings/leds/leds-pwm.yaml > > Signed-off-by: Alexander Dahl > --- > > Notes: > v7 -> v8: > * rebased on v5.10-rc1 > * updated indexes and added comment (Ahmad Fatoum) Acked-by: Ahmad Fatoum Thanks, > > v6 -> v7: > * split up patch (one per sub arch) > * added actual warnings to commit message > > arch/arm/boot/dts/stm32mp157c-lxa-mc1.dts | 13 +++++++------ > 1 file changed, 7 insertions(+), 6 deletions(-) > > diff --git a/arch/arm/boot/dts/stm32mp157c-lxa-mc1.dts b/arch/arm/boot/dts/stm32mp157c-lxa-mc1.dts > index 1e5333fd437f..5ed58110d963 100644 > --- a/arch/arm/boot/dts/stm32mp157c-lxa-mc1.dts > +++ b/arch/arm/boot/dts/stm32mp157c-lxa-mc1.dts > @@ -36,34 +36,35 @@ > stdout-path = &uart4; > }; > > - led-act { > + led-controller-0 { > compatible = "gpio-leds"; > > - led-green { > + led-0 { > label = "mc1:green:act"; > gpios = <&gpioa 13 GPIO_ACTIVE_LOW>; > linux,default-trigger = "heartbeat"; > }; > }; > > - led-rgb { > + led-controller-1 { > compatible = "pwm-leds"; > > - led-red { > + /* led-1 to led-3 are part of a single RGB led */ > + led-1 { > label = "mc1:red:rgb"; > pwms = <&leds_pwm 1 1000000 0>; > max-brightness = <255>; > active-low; > }; > > - led-green { > + led-2 { > label = "mc1:green:rgb"; > pwms = <&leds_pwm 2 1000000 0>; > max-brightness = <255>; > active-low; > }; > > - led-blue { > + led-3 { > label = "mc1:blue:rgb"; > pwms = <&leds_pwm 3 1000000 0>; > max-brightness = <255>; > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |