Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964828AbWH1LQa (ORCPT ); Mon, 28 Aug 2006 07:16:30 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S964824AbWH1LQa (ORCPT ); Mon, 28 Aug 2006 07:16:30 -0400 Received: from ns.firmix.at ([62.141.48.66]:19152 "EHLO ns.firmix.at") by vger.kernel.org with ESMTP id S964780AbWH1LQ3 (ORCPT ); Mon, 28 Aug 2006 07:16:29 -0400 Subject: Re: Conversion to generic boolean From: Bernd Petrovitsch To: Jan Engelhardt Cc: Christoph Hellwig , Richard Knutsson , James.Bottomley@SteelEye.com, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org In-Reply-To: References: <44EFBEFA.2010707@student.ltu.se> <20060828093202.GC8980@infradead.org> Content-Type: text/plain Organization: Firmix Software GmbH Date: Mon, 28 Aug 2006 13:11:54 +0200 Message-Id: <1156763514.22346.7.camel@tara.firmix.at> Mime-Version: 1.0 X-Mailer: Evolution 2.2.3 (2.2.3-4.fc4) Content-Transfer-Encoding: 7bit X-Spam-Score: -2.381 () AWL,BAYES_00,FORGED_RCVD_HELO Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1337 Lines: 35 On Mon, 2006-08-28 at 12:58 +0200, Jan Engelhardt wrote: > >> Just would like to ask if you want patches for: > > > >Total NACK to any of this boolean ididocy. I very much hope you didn't > >get the impression you actually have a chance to get this merged. > > > >> * (Most importent, may introduce bugs if left alone) > >> Fixing boolean checking, ex: > >> if (bool == FALSE) > >> to > >> if (!bool) > > > >this one of course makes sense, but please do it without introducing > >any boolean type. Getting rid of all the TRUE/FALSE defines and converting > >all scsi drivers to classic C integer as boolean semantics would be > >very welcome janitorial work. > > I don't get it. You object to the 'idiocy' > (http://lkml.org/lkml/2006/7/27/281), but find the x==FALSE -> !x > a good thing? If the "if (x == FALSE) { ... }" would be a good thing, why don't we write "if ((x == FALSE) == TRUE) { ... }"? Bernd -- Firmix Software GmbH http://www.firmix.at/ mobil: +43 664 4416156 fax: +43 1 7890849-55 Embedded Linux Development and Services - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/