Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: SkQTdLysxNzMYBbnFs6aZO3Y9it79a1+VJnuVRY/V1M0c4yburRo4zwyQLGjFDtvY9JWmejflk
 P/QKu2AOZOZGHNhO4fXrbrdfYrgAt8nT043w+8jArJYLKKqn8hUYagvryibSUG7IYUFr2arpIg
 fFXoYqultz0ABZPEZGAwSRiOn2VAZu6g3ACP/GYusshrt3cKHP1FZ/2XSYHPFA1uKPXtRd+iPH
 BkaV6KogsQWkbfXhtsKPufsea+6AQYm92NavC01M0p2RKM7+N6gIcxfj6sFwENGwGJiiB+w5B2
 DHg=
From:   Avri Altman <Avri.Altman@wdc.com>
To:     Chris Ruehl <chris.ruehl@gtsys.com.hk>
CC:     Ulf Hansson <ulf.hansson@linaro.org>,
        =?iso-8859-2?Q?Micha=B3_Miros=B3aw?= <mirq-linux@rere.qmqm.pl>,
        "Gustavo A. R. Silva" <gustavoars@kernel.org>,
        Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>,
        Veerabhadrarao Badiganti <vbadigan@codeaurora.org>,
        Matthias Schiffer <matthias.schiffer@ew.tq-group.com>,
        Chris Ball <chris@printf.net>,
        Seungwon Jeon <tgih.jun@samsung.com>,
        "linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] mmc: core: MMC_CAP2_HS200_1_8V_SDR with mmc-hs400-1_8v
Thread-Topic: [PATCH] mmc: core: MMC_CAP2_HS200_1_8V_SDR with mmc-hs400-1_8v
Thread-Index: AQHWxHd+UJnrloRz6UOywQYV58SgA6nfDNEw
Date:   Sun, 29 Nov 2020 12:28:48 +0000
Message-ID: <DM6PR04MB65753FC7EE5058C4A20F6D6FFCF60@DM6PR04MB6575.namprd04.prod.outlook.com>
References: <20201127044044.1127-1-chris.ruehl@gtsys.com.hk>
In-Reply-To: <20201127044044.1127-1-chris.ruehl@gtsys.com.hk>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
Content-Type: text/plain; charset="iso-8859-2"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 21886604-1203-42d7-6d6d-08d89462529e
X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Nov 2020 12:28:48.5749
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: fMzQMTwJEe+qF+x0MNn3QETaCIZCkg7IbC/Cv6HR0OXvQY6sCDo1ctrpuMolcGXkipjjrnuPI2RD89ar5R+MUA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR04MB7130
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

=20
> This patch remove the MMC_CAP2_HS200_1_8V_SDR capacity from
> host->cap2 when the dt property mmc-hs400-1v8 set. It cause
> error and occasionally hang on boot and reboot.
> Board with this issue: rk3399 with SanDisk DG4008 eMMC.
>=20
> This patch did not change the mmc-hs400-1_2v host->cap2
> added the MMC_CAP2_HS200_1_2V_SDR.
>=20
> Log shows a boot process with a HS400 5.1 capable SanDisk 8G
> with mmc-hs400-1_8v dt property and the MMC_CAP2_HS200_1_8V_SDR
> append to the host->cap2.
>=20
> [    1.775721] mmc1: CQHCI version 5.10
> [    1.802342] mmc1: SDHCI controller on fe330000.sdhci [fe330000.sdhci]
> using ADMA
> [    2.007581] mmc1: mmc_select_hs200 failed, error -110
> [    2.007589] mmc1: error -110 whilst initialising MMC card
> [    2.413559] mmc1: mmc_select_hs200 failed, error -110
> [    2.413562] mmc1: error -110 whilst initialising MMC card
> [    3.183343] mmc1: Command Queue Engine enabled
> [    3.183355] mmc1: new HS400 MMC card at address 0001
> [    3.197163] mmcblk1: mmc1:0001 DG4008 7.28 GiB
> [    3.197256] mmcblk1boot0: mmc1:0001 DG4008 partition 1 4.00 MiB
> [    3.197360] mmcblk1boot1: mmc1:0001 DG4008 partition 2 4.00 MiB
> [    3.197479] mmcblk1rpmb: mmc1:0001 DG4008 partition 3 4.00 MiB, charde=
v
> (242:0)
>=20
> after patch applied
> [    1.746691] mmc1: CQHCI version 5.10
> [    1.773316] mmc1: SDHCI controller on fe330000.sdhci [fe330000.sdhci]
> using ADMA
> [    1.858410] mmc1: Command Queue Engine enabled
> [    1.858418] mmc1: new HS400 MMC card at address 0001
> [    1.858897] mmcblk1: mmc1:0001 DG4008 7.28 GiB
> [    1.859002] mmcblk1boot0: mmc1:0001 DG4008 partition 1 4.00 MiB
> [    1.859097] mmcblk1boot1: mmc1:0001 DG4008 partition 2 4.00 MiB
> [    1.859182] mmcblk1rpmb: mmc1:0001 DG4008 partition 3 4.00 MiB, charde=
v
> (242:0)
>=20
> Fixes: c373eb489b27b mmc: core: add DT bindings for eMMC HS400 1.8/1.2V
>=20
> Signed-off-by: Chris Ruehl <chris.ruehl@gtsys.com.hk>
Acked-by: Avri Altman <avri.altman@wdc.com>