Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp2888899pxu; Sun, 29 Nov 2020 08:04:04 -0800 (PST) X-Google-Smtp-Source: ABdhPJy4dbB5LmyVtT/jVHA6igvXnThxyyPjP8xY2z3zYFqSyQqsDOj8LF1jnn3uVODC+kMmPjG7 X-Received: by 2002:a05:6402:714:: with SMTP id w20mr9191653edx.252.1606665843914; Sun, 29 Nov 2020 08:04:03 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1606665843; cv=none; d=google.com; s=arc-20160816; b=lEWwug1aXm0yoMJrvdg1ZfOtxwofJYIWjbUdLZHQmQly+ZP2lOKZJR+OmxIHmkNCvb 8d9rhu1UtA7E4IjULWvVxXuRlfePUsk+2ECFuyjXtNpKnoejS8yLd+D7LJdC/5w9sfD5 rDg5GytF+ImVTTMzZacNKsC9/npJWHPlJHpKRNTYSI3wrxnhQtAAt+8ajx3xE+w6BnMA RqbG3Nkt/Q8ZBn2n2csWOzrOHv1rinhDOcyW0kYpV11gLItZXmnKDbGlRw54TFXXz7xI I8mPaVhjqXIm68E2anInmT9FrDuRLyzSsGFIFLKdlTo+PkuvH2qmJHd/19SCcnV7JbO5 ToaQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=hss5w1vYQvAl2iWogn6A6FdgtYlzLeUcH3sY9Pq7DZk=; b=Qi+FtCy+nVNP/a7413wt8H4poIFjaB55jY4bQtniF2ckhdSiNlCfwK5Xgu3029yyNM CDIg9oahh/dCccaaQA9/owOL9PwyRVkEpIIoy8VQGRmKGNmVp1fmCjyV7QuSigYhZdPY Gdv3uj09DUbVb3QNjZO1+Du0jgWuw21kbr5SoaHX0OpaNk7R459ROXv1VPS1WAPvzQuK VCNdFAqJnHQCeQtopZm/lJYZm8nnbSIGND1aCYsjyx2PmZjeeFlFQJSe5Ej0ohV2hYM7 ctnA/b4YKMSb5BCtP9xiiONZGPd+WkRfv7IP2r8vuUnUiJAvHXgWRAYOBXwhmJdIO0of lxsA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@posteo.net header.s=2017 header.b=f+1Hf3R+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=posteo.net Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id gv7si6204945ejb.601.2020.11.29.08.03.39; Sun, 29 Nov 2020 08:04:03 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@posteo.net header.s=2017 header.b=f+1Hf3R+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=posteo.net Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727892AbgK2Pzs (ORCPT + 99 others); Sun, 29 Nov 2020 10:55:48 -0500 Received: from mout01.posteo.de ([185.67.36.65]:35440 "EHLO mout01.posteo.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727357AbgK2Pzr (ORCPT ); Sun, 29 Nov 2020 10:55:47 -0500 Received: from submission (posteo.de [89.146.220.130]) by mout01.posteo.de (Postfix) with ESMTPS id D9C2816006C for ; Sun, 29 Nov 2020 16:54:46 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1606665286; bh=DUktSWeBkRcQjmy8lE/9yXehjpzS9dnTghZ+sTz2URs=; h=Date:From:To:Cc:Subject:From; b=f+1Hf3R+Xsn4A8DTvRP7EPu2iqnYbSo35JyZnTZkqEnMsR21hhTAx/jn9/0SLhIpa /HglSztoLzBAOHT2ht+doyz4xOBRkbCWOdMUvFuTSj2AK0mVLToEbCM6tbSYWUdESv ASVDhGsZcYIgaykfv55TgnJVzCaCGmLMsBiMKCMvZHjPe309TKYkiL00YFORSGIu3b F0OFhoNIUh/USPvRyIl1HQyHltwlbkxKT4l0NyMYoFoP3FwauvXRjGi0ee80NcpgeU LPh8rr1RPKX415/79V80sgaYFBfZwgAb8CQBctrNmElFdX/3Djbz259EZanvzKJA1V R1FtKGn+0QLxQ== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4CkXxK458jz6tmL; Sun, 29 Nov 2020 16:54:45 +0100 (CET) Date: Sun, 29 Nov 2020 16:54:43 +0100 From: Wilken Gottwalt To: Guenter Roeck Cc: Jonas Malaco , linux-kernel@vger.kernel.org, Jean Delvare , Jonathan Corbet , linux-hwmon@vger.kernel.org Subject: Re: [PATCH] hwmon: corsair-psu: update supported devices Message-ID: <20201129165443.51d22225@monster.powergraphx.local> In-Reply-To: <20201129130049.GB120875@roeck-us.net> References: <20201128113524.24f4f56f@monster.powergraphx.local> <20201129073618.082c2291@monster.powergraphx.local> <20201129130049.GB120875@roeck-us.net> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 29 Nov 2020 05:00:49 -0800 Guenter Roeck wrote: > On Sun, Nov 29, 2020 at 07:36:18AM +0100, Wilken Gottwalt wrote: > > On Sat, 28 Nov 2020 17:21:40 -0300 > > Jonas Malaco wrote: > > > > > On Sat, Nov 28, 2020 at 7:35 AM Wilken Gottwalt > > > wrote: > > > > > > > > On Sat, 28 Nov 2020 02:37:38 -0300 > > > > Jonas Malaco wrote: > > > > > > > > > On Thu, Nov 26, 2020 at 8:43 AM Wilken Gottwalt > > > > > wrote: > > > > > > > > > > > > Adds support for another Corsair PSUs series: AX760i, AX860i, AX1200i, > > > > > > AX1500i and AX1600i. The first 3 power supplies are supported through > > > > > > the Corsair Link USB Dongle which is some kind of USB/Serial/TTL > > > > > > converter especially made for the COM ports of these power supplies. > > > > > > There are 3 known revisions of these adapters. The AX1500i power supply > > > > > > has revision 3 built into the case and AX1600i is the only one in that > > > > > > series, which has an unique usb hid id like the RM/RX series. > > > > > > > > > > Can I ask what AXi power supplies were tested? > > > > > > > > > > I ask because, based on the user-space implementations I am aware of, > > > > > the AXi dongle protocol appears to be different from the RMi/HXi series. > > > > > > > > I was not able to test this against the AX power supplies, they are really > > > > hard to find (and are far to expensive). But I went through all these tools > > > > and stuck to the most common commands, which all 3 series support. Not every > > > > series supports all commands (there also seem to be different firmwares in > > > > the micro-conrollers). But this is fine, some sensors will show up as N/A. > > > > Even my HX850i does not support all commands covered in this driver. > > > > > > I think the similarities come from all using wrappers over the PMBus > > > interface to the voltage controller. But I am not sure the wrapping > > > protocols are identical. > > > > > > For example, cpsumon shows significantly more things going on during a > > > read than what is needed for the RMi/HXi series.[1] > > > > > > [1] https://github.com/ka87/cpsumon/blob/fd639684d7f9/libcpsumon/src/cpsumon.c#L213-L231 > > > > > > > > > > > > > > > AXi dongle: > > > > > - https://github.com/ka87/cpsumon > > > > > > > > This tool made me to consider including the AX series, because it uses some > > > > of the same commands on the AX760i, AX860i, AX1200i and AX1500i. But it is > > > > a usb-serial tool only. But it was nice to know, that the commands are mostly > > > > the same. I left out all the commands for configuring, PCIe power rails, > > > > efficiency and others which do not really belong into hwmon. > > > > > > > > > RMi/HXi: > > > > > - https://github.com/jonasmalacofilho/liquidctl > > > > > - https://github.com/audiohacked/OpenCorsairLink > > > > > > > > This tool made me include the AX series, because it uses the rmi protocol > > > > component for the rmi driver (RM/HX series) and the corsair dongles. > > > > > > The corsairlink_driver_dongle has no implementations for reading sensor > > > data (compare that with the corsairlink_driver_rmi).[2][3] There is > > > also no code that actually tries to read (write) from (to) the device > > > using that dongle driver.[4] > > > > > > I also looked at a few of the issues, and all of the ones I read > > > mentioned AXi support being under development, and the hypothesis of the > > > AXi series being compatible with the RMi/HXi code still remaining to be > > > confirmed. > > > > > > [2] https://github.com/audiohacked/OpenCorsairLink/blob/61d336a61b85/drivers/dongle.c#L33-L39 > > > [3] https://github.com/audiohacked/OpenCorsairLink/blob/61d336a61b85/drivers/rmi.c#L33-L57 > > > [4] https://github.com/audiohacked/OpenCorsairLink/blob/61d336a61b85/main.c#L106 > > > > > > > > > > > > > > > - https://github.com/notaz/corsairmi > > > > > > > > This one covers only some HX/RM PSUs, but is uses the rawhid access which > > > > made me looking up the actual usb chips/bridges Corsair uses. > > > > > > > > > > > > > > One additional concern is that the non-HID AXi dongles may only have bulk > > > > > USB endpoints, and this is a HID driver.[1] > > > > > > > > You are right, in the case of the dongles it could be different. But I did > > > > some research on Corsair usb driven devices and they really like to stick to > > > > the cp210x, which is an usb hid bridge. The commit > > > > b9326057a3d8447f5d2e74a7b521ccf21add2ec0 actually covers two Corsair USB > > > > dongles as a cp210x device. So it is very likely that all Corsair PSUs with > > > > such an interface/dongle use usb hid. But I'm completely open to get proven > > > > wrong. Actually I really would like to see this tested by people who have > > > > access to the more rare devices. > > > > > > I could be wrong (and I am sorry for the noise if that is the case), but > > > as far as I can see the cp210x does not create a HID device. > > > > No no, this is fine. It really helps if some more people are looking into this. > > I wish I had access to at least one of the later models (AX1500i/AX1600i), I > > make mistakes from time to time. And it really doesn't help that Corsair changes > > single devices in the same product line by firmware update. The AX1600i seems to > > be the only one, which uses exactly the same protocol like the RM/HX series, but > > is missing the actual usb hid part. But there seems to be a firmware where the > > usb hid part was available for a short time. So, what to do? Remove the AXi part > > completely or keep only the AX1600i? > > > > Guenter, what would you suggest? > > > I'd suggest to remove it completely, and explain the reason. Anything else will > just create trouble with people demanding to know why their power supply is not > supported even though it is listed as supported. And, believe me, you don't want > to be on the receiving side of those complaints. The Internet is much less > friendly nowadays than it used to be. So how is the procedure for this? Just revert it and make a common patch out of it with a proper explanation? And yeah, I know exactly what you mean. I remember very well how the "internet" got it first ugly hit in the 90s with the upcoming of Flash ... and then the "social media". :D Thanks for your help. greetings, Wilken > Guenter > > > > Thanks again, > > > Jonas > > > > > > > > > > > > > > > Thanks, > > > > > Jonas > > > > > > > > > > [1] https://github.com/ka87/cpsumon/issues/4 > > > > > > > > Yes ... that one. The last revision of the dongle could indeed be a problem. > > > > But I'm not really sure what is described here. The last commenter is actually > > > > the one who provided the cp210x patch mentioned up there. The problem here is, > > > > the AX1500i has both connectors, USB and that other one. I call it the other > > > > one because it is the only PSU where it is labeled I2C COMM instead of COMM > > > > only. But at the same time this tools uses the same commands for this PSU. > > > > > > > > So, only some real hardware tests will show. > > > > > > > > Greetings, > > > > Wilken > > > > > > > > > > > > > > > > The patch also changes the usb hid ids to use upper case letters to be > > > > > > consistent with the rest of the hex numbers in the driver and updates > > > > > > the hwmon documentation. > > > > > > > > > > > > This patch adds: > > > > > > - hwmon/corsair-psu documentation update > > > > > > - corsair-psu driver update > > > > > > > > > > > > Signed-off-by: Wilken Gottwalt > > > > > > --- > > > > > > Documentation/hwmon/corsair-psu.rst | 10 +++++++++ > > > > > > drivers/hwmon/Kconfig | 7 +++--- > > > > > > drivers/hwmon/corsair-psu.c | 33 +++++++++++++++++++---------- > > > > > > 3 files changed, 36 insertions(+), 14 deletions(-) > > > > > > > > > > > > diff --git a/Documentation/hwmon/corsair-psu.rst b/Documentation/hwmon/corsair-psu.rst > > > > > > index 396b95c9a76a..6227e9046d73 100644 > > > > > > --- a/Documentation/hwmon/corsair-psu.rst > > > > > > +++ b/Documentation/hwmon/corsair-psu.rst > > > > > > @@ -7,6 +7,16 @@ Supported devices: > > > > > > > > > > > > * Corsair Power Supplies > > > > > > > > > > > > + Corsair AX760i (by Corsair Link USB Dongle) > > > > > > + > > > > > > + Corsair AX860i (by Corsair Link USB Dongle) > > > > > > + > > > > > > + Corsair AX1200i (by Corsair Link USB Dongle) > > > > > > + > > > > > > + Corsair AX1500i (by builtin Corsair Link USB Dongle) > > > > > > + > > > > > > + Corsair AX1600i > > > > > > + > > > > > > Corsair HX550i > > > > > > > > > > > > Corsair HX650i > > > > > > diff --git a/drivers/hwmon/Kconfig b/drivers/hwmon/Kconfig > > > > > > index 716df51edc87..3c059fc23cd6 100644 > > > > > > --- a/drivers/hwmon/Kconfig > > > > > > +++ b/drivers/hwmon/Kconfig > > > > > > @@ -453,11 +453,12 @@ config SENSORS_CORSAIR_PSU > > > > > > tristate "Corsair PSU HID controller" > > > > > > depends on HID > > > > > > help > > > > > > - If you say yes here you get support for Corsair PSUs with a HID > > > > > > + If you say yes here you get support for Corsair PSUs with an USB HID > > > > > > interface. > > > > > > Currently this driver supports the (RM/HX)550i, (RM/HX)650i, > > > > > > - (RM/HX)750i, (RM/HX)850i, (RM/HX)1000i and HX1200i power supplies > > > > > > - by Corsair. > > > > > > + (RM/HX)750i, (RM/HX)850i, (RM/HX)1000i, HX1200i and AX1600i power > > > > > > + supplies by Corsair. The AX760i, AX860i, AX1200i and AX1500i > > > > > > + power supplies are supported through the Corsair Link USB Dongle. > > > > > > > > > > > > This driver can also be built as a module. If so, the module > > > > > > will be called corsair-psu. > > > > > > diff --git a/drivers/hwmon/corsair-psu.c b/drivers/hwmon/corsair-psu.c > > > > > > index 99494056f4bd..0146dda3e2c3 100644 > > > > > > --- a/drivers/hwmon/corsair-psu.c > > > > > > +++ b/drivers/hwmon/corsair-psu.c > > > > > > @@ -571,17 +571,28 @@ static int corsairpsu_raw_event(struct hid_device *hdev, struct > > > > > > hid_report *repo } > > > > > > > > > > > > static const struct hid_device_id corsairpsu_idtable[] = { > > > > > > - { HID_USB_DEVICE(0x1b1c, 0x1c03) }, /* Corsair HX550i */ > > > > > > - { HID_USB_DEVICE(0x1b1c, 0x1c04) }, /* Corsair HX650i */ > > > > > > - { HID_USB_DEVICE(0x1b1c, 0x1c05) }, /* Corsair HX750i */ > > > > > > - { HID_USB_DEVICE(0x1b1c, 0x1c06) }, /* Corsair HX850i */ > > > > > > - { HID_USB_DEVICE(0x1b1c, 0x1c07) }, /* Corsair HX1000i */ > > > > > > - { HID_USB_DEVICE(0x1b1c, 0x1c08) }, /* Corsair HX1200i */ > > > > > > - { HID_USB_DEVICE(0x1b1c, 0x1c09) }, /* Corsair RM550i */ > > > > > > - { HID_USB_DEVICE(0x1b1c, 0x1c0a) }, /* Corsair RM650i */ > > > > > > - { HID_USB_DEVICE(0x1b1c, 0x1c0b) }, /* Corsair RM750i */ > > > > > > - { HID_USB_DEVICE(0x1b1c, 0x1c0c) }, /* Corsair RM850i */ > > > > > > - { HID_USB_DEVICE(0x1b1c, 0x1c0d) }, /* Corsair RM1000i */ > > > > > > + /* > > > > > > + * The Corsair USB/COM Dongles appear in at least 3 different revisions, where > > > > > > rev 1 and 2 > > > > > > + * are commonly used with the AX760i, AX860i and AX1200i, while rev3 is rarely > > > > > > seen with > > > > > > + * these PSUs. Rev3 is also build into the AX1500i, while the AX1600i is the > > > > > > first PSU of > > > > > > + * this series which has an unique usb hid id. Though, the actual device name is > > > > > > part of > > > > > > + * the HID message protocol, so it doesn't matter which dongle is connected. > > > > > > + */ > > > > > > + { HID_USB_DEVICE(0x1B1C, 0x1C00) }, /* Corsair Link USB/COM Dongle rev1 */ > > > > > > + { HID_USB_DEVICE(0x1B1C, 0x1C01) }, /* Corsair Link USB/COM Dongle rev2 */ > > > > > > + { HID_USB_DEVICE(0x1B1C, 0x1C02) }, /* Corsair Link USB/COM Dongle rev3 > > > > > > (AX1500i) */ > > > > > > + { HID_USB_DEVICE(0x1B1C, 0x1C03) }, /* Corsair HX550i */ > > > > > > + { HID_USB_DEVICE(0x1B1C, 0x1C04) }, /* Corsair HX650i */ > > > > > > + { HID_USB_DEVICE(0x1B1C, 0x1C05) }, /* Corsair HX750i */ > > > > > > + { HID_USB_DEVICE(0x1B1C, 0x1C06) }, /* Corsair HX850i */ > > > > > > + { HID_USB_DEVICE(0x1B1C, 0x1C07) }, /* Corsair HX1000i */ > > > > > > + { HID_USB_DEVICE(0x1B1C, 0x1C08) }, /* Corsair HX1200i */ > > > > > > + { HID_USB_DEVICE(0x1B1C, 0x1C09) }, /* Corsair RM550i */ > > > > > > + { HID_USB_DEVICE(0x1B1C, 0x1C0A) }, /* Corsair RM650i */ > > > > > > + { HID_USB_DEVICE(0x1B1C, 0x1C0B) }, /* Corsair RM750i */ > > > > > > + { HID_USB_DEVICE(0x1B1C, 0x1C0C) }, /* Corsair RM850i */ > > > > > > + { HID_USB_DEVICE(0x1B1C, 0x1C0D) }, /* Corsair RM1000i */ > > > > > > + { HID_USB_DEVICE(0x1B1C, 0x1C11) }, /* Corsair AX1600i */ > > > > > > { }, > > > > > > }; > > > > > > MODULE_DEVICE_TABLE(hid, corsairpsu_idtable); > > > > > > -- > > > > > > 2.29.2 > > > > > > > > > > > >