Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] locks: remove trailing semicolon in macro definition
To:     Tom Rix <trix@redhat.com>, Matthew Wilcox <willy@infradead.org>
Cc:     jlayton@kernel.org, bfields@fieldses.org, viro@zeniv.linux.org.uk,
        linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20201127190707.2844580-1-trix@redhat.com>
 <20201127195323.GZ4327@casper.infradead.org>
 <8e7c0d56-64f3-d0b6-c1cf-9f285c59f169@redhat.com>
From:   Randy Dunlap <rdunlap@infradead.org>
Message-ID: <d65cd737-61a5-4b31-7f25-e72f0a7f4ec2@infradead.org>
Date:   Sun, 29 Nov 2020 09:52:53 -0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.4.0
MIME-Version: 1.0
In-Reply-To: <8e7c0d56-64f3-d0b6-c1cf-9f285c59f169@redhat.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 11/29/20 9:47 AM, Tom Rix wrote:
> 
> On 11/27/20 11:53 AM, Matthew Wilcox wrote:
>> On Fri, Nov 27, 2020 at 11:07:07AM -0800, trix@redhat.com wrote:
>>> +++ b/fs/fcntl.c
>>> @@ -526,7 +526,7 @@ SYSCALL_DEFINE3(fcntl64, unsigned int, fd, unsigned int, cmd,
>>>  	(dst)->l_whence = (src)->l_whence;	\
>>>  	(dst)->l_start = (src)->l_start;	\
>>>  	(dst)->l_len = (src)->l_len;		\
>>> -	(dst)->l_pid = (src)->l_pid;
>>> +	(dst)->l_pid = (src)->l_pid
>> This should be wrapped in a do { } while (0).
>>
>> Look, this warning is clearly great at finding smelly code, but the
>> fixes being generated to shut up the warning are low quality.
>>
> Multiline macros not following the do {} while (0) pattern are likely a larger problem.
> 
> I'll take a look.


Could it become a static inline function instead?
or that might expand its scope too much?

-- 
~Randy