Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Sun, 29 Nov 2020 19:55:19 +0200
From:   Cristian Ciocaltea <cristian.ciocaltea@gmail.com>
To:     Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Cc:     Rob Herring <robh+dt@kernel.org>,
        Andreas =?iso-8859-1?Q?F=E4rber?= <afaerber@suse.de>,
        devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-actions@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 01/18] arm: dts: owl-s500: Add Clock Management Unit
Message-ID: <20201129175519.GA696261@BV030612LT>
References: <cover.1605823502.git.cristian.ciocaltea@gmail.com>
 <7c45642753b94e2b2f4fcef0d3206b4c237e3135.1605823502.git.cristian.ciocaltea@gmail.com>
 <20201128072212.GP3077@thinkpad>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20201128072212.GP3077@thinkpad>
Precedence: bulk

On Sat, Nov 28, 2020 at 12:52:12PM +0530, Manivannan Sadhasivam wrote:
> On Fri, Nov 20, 2020 at 01:55:55AM +0200, Cristian Ciocaltea wrote:
> > Add Clock Management Unit for Actions Semi S500 SoC.
> > 
> > Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@gmail.com>
> 
> Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>

Thanks for taking the time to review this patch series!

Kind regards,
Cristi

> Thanks,
> Mani
> 
> > ---
> >  arch/arm/boot/dts/owl-s500.dtsi | 14 ++++++++++++++
> >  1 file changed, 14 insertions(+)
> > 
> > diff --git a/arch/arm/boot/dts/owl-s500.dtsi b/arch/arm/boot/dts/owl-s500.dtsi
> > index 1dbe4e8b38ac..5d5ad9db549b 100644
> > --- a/arch/arm/boot/dts/owl-s500.dtsi
> > +++ b/arch/arm/boot/dts/owl-s500.dtsi
> > @@ -5,6 +5,7 @@
> >   * Copyright (c) 2016-2017 Andreas F?rber
> >   */
> >  
> > +#include <dt-bindings/clock/actions,s500-cmu.h>
> >  #include <dt-bindings/interrupt-controller/arm-gic.h>
> >  #include <dt-bindings/power/owl-s500-powergate.h>
> >  
> > @@ -70,6 +71,12 @@ hosc: hosc {
> >  		#clock-cells = <0>;
> >  	};
> >  
> > +	losc: losc {
> > +		compatible = "fixed-clock";
> > +		clock-frequency = <32768>;
> > +		#clock-cells = <0>;
> > +	};
> > +
> >  	soc {
> >  		compatible = "simple-bus";
> >  		#address-cells = <1>;
> > @@ -169,6 +176,13 @@ uart6: serial@b012c000 {
> >  			status = "disabled";
> >  		};
> >  
> > +		cmu: clock-controller@b0160000 {
> > +			compatible = "actions,s500-cmu";
> > +			reg = <0xb0160000 0x8000>;
> > +			clocks = <&hosc>, <&losc>;
> > +			#clock-cells = <1>;
> > +		};
> > +
> >  		timer: timer@b0168000 {
> >  			compatible = "actions,s500-timer";
> >  			reg = <0xb0168000 0x8000>;
> > -- 
> > 2.29.2
> >