Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 30 Nov 2020 12:15:30 +0900
From:   Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
To:     Randy Dunlap <rdunlap@infradead.org>
Cc:     Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
        Christoph Hellwig <hch@lst.de>,
        "Gustavo A. R. Silva" <gustavo@embeddedor.com>,
        Namjae Jeon <linkinjeon@kernel.org>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] posix_acl.h: define missing ACL functions on
 non-posix-acl build
Message-ID: <X8Rj0s/Emv9Qmv3d@jagdpanzerIV.localdomain>
References: <20201130014404.36904-1-sergey.senozhatsky@gmail.com>
 <5b015b83-f183-526a-94e7-029f4c98b30b@infradead.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <5b015b83-f183-526a-94e7-029f4c98b30b@infradead.org>
Precedence: bulk

On (20/11/29 18:00), Randy Dunlap wrote:
> On 11/29/20 5:44 PM, Sergey Senozhatsky wrote:
> > Some functions that are declared when CONFIG_POSIX_ACL is defined
> > are not declared when CONFIG_POSIX_ACL is not defined. Add the
> > missing ones:
> >   set_posix_acl(), posix_acl_update_mode(), get_cached_acl(),
> >   get_cached_acl_rcu(), set_cached_acl(), forget_cached_acl().
> > 
> > Signed-off-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
> 
> Hi,
> 
> I can't find CONFIG_POSIX_ACL in the kernel source tree.
> Should it be CONFIG_FS_POSIX_ACL ?

Oh, yes, CONFIG_POSIX_ACL. My bad.

> How did you test this?

You know what - scratch this patch. Sorry for the noise.

Some of the posix_acl.h functions are guarded by ifdef/ifndef
CONFIG_FS_POSIX_ACL, and some are not. This can break the build
if the code in question doesn't use ifdef CONFIG_FS_POSIX_ACL
(which happens with our code). But this patch is not enough,
apparently, we need to add ifdef CONFIG_FS_POSIX_ACL to our
code anyway, because of, for instance, posix_acl_alloc() which
is undefined for !FS_POSIX_ACL builds. Sorry for the noise.

	-ss